[GitHub] [druid] clintropolis commented on pull request #12636: Today is that day - Single pass through Calcite planner

[GitBox <gi...@apache.org>]

clintropolis commented on PR #12636:
URL: https://github.com/apache/druid/pull/12636#issuecomment-1197491209

   >Argh... Tests that use mocks to enforce a call sequence of a class's implementation are quite tedious, and don't shed much light.
   
   heh, sorry, I'm responsible for that test; it was intended to ensure that state transitions were happening as expected and the actions within the state as expected, so was sort of testing implementation details on purpose, but since it was using mocks those sorts of tests are painful when refactoring stuff. Its probably worth retaining testing of some sort to ensure the state machine behaves as it is supposed to so that new callers can't mess stuff up, but not sure the best way to do that without being fragile/implementation dependent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org