You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/08 03:45:46 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDis…
AnonHxy opened a new pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161
Master Issue: https://github.com/apache/pulsar/issues/13756
### Motivation
See issue: https://github.com/apache/pulsar/issues/13756
### Modifications
* Add field `replicatorDispatchRate` in `org.apache.pulsar.common.policies.data.HierarchyTopicPolicies`
* Methods to update `replicatorDispatchRate` in `org.apache.pulsar.broker.service.AbstractTopic`
* Other Modifications are concerning on `org.apache.pulsar.broker.service.persistent.DispatchRateLimiter` where `replicatorDispatchRate` are used
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1050446660
I have resolved the conflicts, PTAL @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1042806906
@codelipenghui @315157973 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1039893070
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#discussion_r803463129
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentReplicator.java
##########
@@ -697,8 +697,8 @@ public boolean expireMessages(Position position) {
@Override
public void initializeDispatchRateLimiterIfNeeded(Optional<Policies> policies) {
Review comment:
This params is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#discussion_r801294665
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -319,6 +319,8 @@ public PersistentTopic(String topic, ManagedLedger ledger, BrokerService brokerS
this.isEncryptionRequired = policies.encryption_required;
+ this.dispatchRateLimiter.ifPresent(DispatchRateLimiter::updateDispatchRate);
Review comment:
This is unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1039893070
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1049966004
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1049836911
@AnonHxy Could you please help resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1049875888
@codelipenghui Ok, I push the code again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14161: [Issue 13756][Broker]Optimize topic policy with HierarchyTopicPolicies about replicatorDispatchRate
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14161:
URL: https://github.com/apache/pulsar/pull/14161#issuecomment-1035726246
@Jason918 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org