You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/11/17 11:01:31 UTC

[GitHub] [hbase] virajjasani commented on pull request #3852: HBASE-26458 Add UNSET_SNAPSHOT_PROP and fix TTL defaulting

virajjasani commented on pull request #3852:
URL: https://github.com/apache/hbase/pull/3852#issuecomment-971465945


   I just tested this locally on master branch.
   
   **Configs:**
     <property>
       <name>hbase.master.cleaner.snapshot.interval</name>
       <value>10000</value>
     </property>
   
   **Shell commands and respective outputs:**
   
   > snapshot 't1', 's2'
   Took 2.1034 seconds           
   
   > snapshot 't1', 's3', {TTL => -2}
   Took 1.0925 seconds                                                                                                                                                                                                                                           
   => [{"TTL"=>-2}]
   
   > snapshot 't1', 's1', {TTL => 5}
   Took 2.1023 seconds                                                                                                                                                                                                                                           
   => [{"TTL"=>5}]
   
   <img width="1630" alt="Screenshot 2021-11-17 at 4 17 11 PM" src="https://user-images.githubusercontent.com/34790606/142187725-e0f67af3-90bc-47ef-bd28-f73285c27dd3.png">
   
   
   After 5sec, the snapshot was gone.
   
   <img width="1568" alt="Screenshot 2021-11-17 at 4 19 32 PM" src="https://user-images.githubusercontent.com/34790606/142187833-749fb7a2-5a31-4956-9f65-b7fb8bda36ee.png">
   
   
   
   
   **Configs:**
     <property>
       <name>hbase.master.cleaner.snapshot.interval</name>
       <value>10000</value>
     </property>
     <property>
       <name>hbase.master.snapshot.ttl</name>
       <value>20</value>
     </property>
   
   **Shell commands and respective outputs:**
   
   > snapshot 't1', 's4'
   Took 2.7291 seconds                                                            
   
   Snapshot 's4' gets created with TTL 20 sec because of config `hbase.master.snapshot.ttl`:
   
   <img width="1584" alt="Screenshot 2021-11-17 at 4 21 49 PM" src="https://user-images.githubusercontent.com/34790606/142188010-15a2abf1-26aa-4553-a803-ec2e96b5803d.png">
   
   
   After 20s, it was gone:
   
   <img width="1539" alt="Screenshot 2021-11-17 at 4 22 04 PM" src="https://user-images.githubusercontent.com/34790606/142188219-1ada2b96-0a64-4f6c-b5f2-711b3abfc8e8.png">
   
   
   > snapshot 't1', 's5', {TTL => -10}
   Took 2.1079 seconds                                                                                                                                                                                                                                           
   => [{"TTL"=>-10}]
   
   <img width="1618" alt="Screenshot 2021-11-17 at 4 23 43 PM" src="https://user-images.githubusercontent.com/34790606/142188278-ed70511c-bea6-44f8-a3d6-c70c674bbd57.png">
   
   1.  TTL with negative values will stay forever regardless of any server side config changes. 
   2. TTL with positive values will be gone after TTL expires.
   3.  Snapshot created without specifying TTL will always have TTL values represented by config `hbase.master.snapshot.ttl`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org