You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/09 08:29:31 UTC

[GitHub] [zookeeper] ztzg edited a comment on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style" argument parsing

ztzg edited a comment on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style" argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-563119768
 
 
   Hi @symat,
   
   Thank you for the test, and report.  Nice catch!  That was a bit puzzling... but it turns out that "batch mode" has *never* been implemented in `cli_mt`.
   
   From the first day on, `cmd` was only handled [in the `#else /* !THREADED */` section](https://github.com/apache/zookeeper/commit/36ed46fc726fd#diff-419c86bcc09a6b28f27161879deed603R488-R492).
   
   I have now opened [ZOOKEEPER-3640, "Implement "batch mode" in cli_mt"](https://issues.apache.org/jira/browse/ZOOKEEPER-3640).
   
   If you are otherwise happy with the PR, could we get this moving?  I'd like to get the pipeline flushed and get a rebased/aligned SASL client sitting on top :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services