You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/24 03:47:14 UTC

[GitHub] [shardingsphere] totalo opened a new pull request, #17042: Add shardingsphere-all module to provide all-in-one jar

totalo opened a new pull request, #17042:
URL: https://github.com/apache/shardingsphere/pull/17042

   Fixes #13609.
   
   Changes proposed in this pull request:
   - add shardingsphere-all module
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1113009985

   > How to process the SPI files when shading?
   
   Merge them using ServicesResourceTransformer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#discussion_r885752283


##########
shardingsphere-distribution/pom.xml:
##########
@@ -32,6 +32,7 @@
         <module>shardingsphere-src-distribution</module>
         <module>shardingsphere-jdbc-distribution</module>
         <module>shardingsphere-proxy-distribution</module>
+        <module>shardingsphere-all</module>

Review Comment:
   It is better to rename as `shardingsphere-all-distribution`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1107716726

   <img width="1266" alt="image" src="https://user-images.githubusercontent.com/29777558/164958318-b173e4cb-1d02-4bae-beec-bef554dc7843.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add shardingsphere-all module to provide all-in-one jar [shardingsphere]

Posted by "zzyReal666 (via GitHub)" <gi...@apache.org>.
zzyReal666 commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1989971543

   Have we finish it? I still can not get a fatjar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo closed pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo closed pull request #17042: Add shardingsphere-all module to provide all-in-one jar
URL: https://github.com/apache/shardingsphere/pull/17042


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1220527663

   Hi @totalo, does this pr has any progress? Could we finish this in 5.1.3?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1113018271

   > Netty is no longer re-package all classes into one jar. [netty/netty#11732](https://github.com/netty/netty/pull/11732)
   
   I think we can provide an uber.jar, as for other optional modules included in the user's classpath, the user needs to deal with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on a diff in pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on code in PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#discussion_r885754527


##########
shardingsphere-distribution/pom.xml:
##########
@@ -32,6 +32,7 @@
         <module>shardingsphere-src-distribution</module>
         <module>shardingsphere-jdbc-distribution</module>
         <module>shardingsphere-proxy-distribution</module>
+        <module>shardingsphere-all</module>

Review Comment:
   Okay 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1144342865

   Hi @totalo @terrymanu 
   Any update here? Could we finish this in 5.1.2?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1107713601

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#17042](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9292e66) into [master](https://codecov.io/gh/apache/shardingsphere/commit/cdc12c81fcd7d24717e24cd802652efb748a1f95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc12c8) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #17042      +/-   ##
   ============================================
   + Coverage     60.30%   60.34%   +0.03%     
   - Complexity     2135     2136       +1     
   ============================================
     Files          3453     3460       +7     
     Lines         51859    51828      -31     
     Branches       8882     8853      -29     
   ============================================
   + Hits          31273    31274       +1     
   + Misses        17950    17936      -14     
   + Partials       2636     2618      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...optimizer/metadata/FederationDatabaseMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvbWV0YWRhdGEvRmVkZXJhdGlvbkRhdGFiYXNlTWV0YURhdGEuamF2YQ==) | `28.00% <0.00%> (-15.75%)` | :arrow_down: |
   | [...sphere/dbdiscovery/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9ydWxlL0RhdGFiYXNlRGlzY292ZXJ5UnVsZS5qYXZh) | `67.10% <0.00%> (-1.25%)` | :arrow_down: |
   | [...distsql/rdl/rule/RuleDefinitionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL3J1bGUvUnVsZURlZmluaXRpb25CYWNrZW5kSGFuZGxlci5qYXZh) | `52.77% <0.00%> (-0.75%)` | :arrow_down: |
   | [...e/infra/config/props/ConfigurationPropertyKey.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvcHJvcHMvQ29uZmlndXJhdGlvblByb3BlcnR5S2V5LmphdmE=) | `95.00% <0.00%> (-0.24%)` | :arrow_down: |
   | [.../loader/dialect/OpenGaussSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvbG9hZGVyL2RpYWxlY3QvT3BlbkdhdXNzU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `3.07% <0.00%> (-0.10%)` | :arrow_down: |
   | [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWFuYWdlci9Db250ZXh0TWFuYWdlci5qYXZh) | `69.40% <0.00%> (ø)` | |
   | [...ingsphere/infra/storage/StorageNodeDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zdG9yYWdlL1N0b3JhZ2VOb2RlRGF0YVNvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...here/agent/core/config/yaml/engine/YamlEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbmdpbmUvWWFtbEVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../datasource/registry/GlobalDataSourceRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhc291cmNlL3JlZ2lzdHJ5L0dsb2JhbERhdGFTb3VyY2VSZWdpc3RyeS5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | ... and [55 more](https://codecov.io/gh/apache/shardingsphere/pull/17042/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cdc12c8...9292e66](https://codecov.io/gh/apache/shardingsphere/pull/17042?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1107731245

   Netty is no longer re-package all classes into one jar. https://github.com/netty/netty/pull/11732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] TeslaCN commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1107727248

   How to process the SPI files when shading?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1108335756

   > How about move shardingsphere-all into shardingsphere-distributed module? And it is better to use maven profile to control assembly all-in-one jar or not.
   
   All right, i will check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] totalo commented on pull request #17042: Add shardingsphere-all module to provide all-in-one jar

Posted by GitBox <gi...@apache.org>.
totalo commented on PR #17042:
URL: https://github.com/apache/shardingsphere/pull/17042#issuecomment-1148292962

   > Hi @totalo @terrymanu Any update here? Could we finish this in 5.1.2?
   
   Mybe not, put it to 5.1.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org