You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/07/06 21:07:03 UTC
[PR] Skip Thin HTTP server bundle on Ruby head [thrift]
kpumuk opened a new pull request, #3627:
URL: https://github.com/apache/thrift/pull/3627
<!-- Explain the changes in the pull request below: -->
This change disables tests Ruby HTTP server powered by Thin on Ruby 4.1 (head). [Eventmachine](https://github.com/eventmachine/eventmachine), the library that powers Thin, has not been updated for 8 years, and probably never will. At this point we might as well consider Ruby HTTP server implementation non-functional, and start looking for a replacement.
https://github.com/apache/thrift/actions/runs/28798532945/job/85395896533?pr=3626
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip Thin HTTP server bundle on Ruby head [thrift]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3627:
URL: https://github.com/apache/thrift/pull/3627#discussion_r3532079145
##########
lib/rb/spec/thin_http_server_spec.rb:
##########
@@ -20,9 +20,16 @@
require 'spec_helper'
require 'rack/test'
-require 'thrift/server/thin_http_server'
-describe Thrift::ThinHTTPServer do
+begin
+ require 'thrift/server/thin_http_server'
+rescue LoadError
+ # The thin gem is optional and may be excluded on unsupported Ruby versions.
+end
+
+thin_dependency = defined?(Thin) ? {} : { :skip => "thin not available" }
+
Review Comment:
The skip metadata is derived from `defined?(Thin)`, but the `require 'thrift/server/thin_http_server'` is wrapped in `rescue LoadError`. If `Thin` is already defined for any reason while the require fails (or Thrift::ThinHTTPServer isn't loaded), this will run the examples and they can fail with NameError. Prefer basing the skip on whether the ThinHTTPServer file was successfully required (or whether `Thrift::ThinHTTPServer` is defined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip Thin HTTP server bundle on Ruby head [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on PR #3627:
URL: https://github.com/apache/thrift/pull/3627#issuecomment-4897759092
Tests run on Ruby 3.1: https://github.com/apache/thrift/actions/runs/28823367882/job/85480824529#step:9:1323
Skipped on Ruby 4.1 (head): https://github.com/apache/thrift/actions/runs/28823367882/job/85480824542#step:9:1227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip Thin HTTP server bundle on Ruby head [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk commented on code in PR #3627:
URL: https://github.com/apache/thrift/pull/3627#discussion_r3532092950
##########
lib/rb/spec/thin_http_server_spec.rb:
##########
@@ -20,9 +20,16 @@
require 'spec_helper'
require 'rack/test'
-require 'thrift/server/thin_http_server'
-describe Thrift::ThinHTTPServer do
+begin
+ require 'thrift/server/thin_http_server'
+rescue LoadError
+ # The thin gem is optional and may be excluded on unsupported Ruby versions.
+end
+
+thin_dependency = defined?(Thin) ? {} : { :skip => "thin not available" }
+
Review Comment:
If `Thin` is loaded, we do want to run the tests. I would rather see the tests fail if `Thin` is defined, but the HTTP server is not, than silently skip tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Skip Thin HTTP server bundle on Ruby head [thrift]
Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk merged PR #3627:
URL: https://github.com/apache/thrift/pull/3627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org