You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/04/16 18:43:48 UTC

[GitHub] [nifi] alopresto commented on issue #3436: NIFI-6019 Removes "Trusted Hostname" property from `InvokeHTTP` processor

alopresto commented on issue #3436: NIFI-6019 Removes "Trusted Hostname" property from `InvokeHTTP` processor
URL: https://github.com/apache/nifi/pull/3436#issuecomment-483796360
 
 
   Thanks for submitting this PR. Can you please add some unit tests demonstrating what happens when a flow which contains this property populated (i.e. set the property value when configuring the `TestRunner`) tries to run on this processor? We try to enforce backward compatibility, and while this change is definitely necessary, there needs to be a good story (documentation, process, explanation) around this change for users to maintain their existing flow behavior. 
   
   I would suggest adding an explanation of why the property no longer exists and how to resolve a problem encountered by upgrading to the `InvokeHTTP` processor documenation (perhaps in Additional Details) and perhaps adding a section in the User Guide about properly configuring/selecting a truststore for use in a [`SSLContextService`](https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi/nifi-ssl-context-service-nar/1.9.2/org.apache.nifi.ssl.StandardSSLContextService/index.html). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services