You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jansohn (via GitHub)" <gi...@apache.org> on 2024/05/17 12:33:41 UTC
[PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
jansohn opened a new pull request, #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86
Switched to `ProcessBuilder` for JDK toolchain version detection as it actually correctly handles white spaces in the executable path compared to the plexus-utils dependency.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2124037001
> `Commandline` used by constructor try to parse command .... so when we have a space it is wrong parsed ...
>
> @michael-o - next issue with parsing command line 😄
It does *not* surprise me. I have been telling that this is broken for years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2956732786
Resolve #182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jansohn (via GitHub)" <gi...@apache.org>.
jansohn commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118827018
> @jansohn can you try my proposition of fix: #87
I can test it on Tuesday but I doubt it will fix the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2956778116
Resolve #182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118807695
@jansohn - please look at comments in JIRA https://issues.apache.org/jira/browse/MJAR-310
It can be reasonable to fix a bug in plexus-utils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2143543523
@jansohn thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2122784850
`Commandline` used by constructor try to parse command .... so when we have a space it is wrong parsed ...
@michael-o - next issue with parsing command line 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jansohn (via GitHub)" <gi...@apache.org>.
jansohn commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118823265
> @jansohn can you try my proposition of fix: #87
I'll only be back in the office on Tuesday to give it a try. But I'd be surprised if this actually fixed the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jansohn (via GitHub)" <gi...@apache.org>.
jansohn commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118826793
> @jansohn - please look at comments in JIRA https://issues.apache.org/jira/browse/MJAR-310
> It can be reasonable to fix a bug in plexus-utils
Makes sense but there are already three year old PRs trying to revert the extra use of cmd.exe so I'm not keen on going down that route.
I think it makes more sense to just use ProcessBuilder directly for such a simple task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2118816933
@jansohn can you try my proposition of fix: #87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAR-310] - fixed toolchain version detection when toolchain paths contain white spaces [maven-jar-plugin]
Posted by "jansohn (via GitHub)" <gi...@apache.org>.
jansohn commented on PR #86:
URL: https://github.com/apache/maven-jar-plugin/pull/86#issuecomment-2121931086
> > @jansohn can you try my proposition of fix: #87
>
> I can test it on Tuesday but I doubt it will fix the problem.
I stand corrected and #87 actually does solve the issue with blanks in Windows paths.
Totally unintuitive that it works by setter and not by constructor argument in my opinion. While digging into the code I also saw that it actually dismisses the shell wrapping if it detects a non-Windows OS which explains why this only occurred on Windows systems.
Personally I would not rely on such an overly complex third library for such a simple use case but feel free to merge whatever PR you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org