You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by amontalenti <gi...@git.apache.org> on 2015/04/23 22:58:05 UTC

[GitHub] storm pull request: Add support for "error" command in ShellSpout

GitHub user amontalenti opened a pull request:

    https://github.com/apache/storm/pull/533

    Add support for "error" command in ShellSpout

    Addresses JIRA issue [STORM-796](https://issues.apache.org/jira/browse/STORM-796). 
    
    The symptoms a multi-lang user will see here is that if their Spout throws an error and their multi-lang implementation sends an "error" command up to the ShellSpout, the ShellSpout will respond saying that it doesn't recognize the "error" command, and thus it will crash (while swallowing the exception thrown by the underlying multi-lang component).
    
    ShellBolt already supports the error command, and ShellSpout already has a way of reporting errors -- so this was just a matter of adding similar logic to the ShellSpout.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amontalenti/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #533
    
----
commit 2c35cb4dec67604185d3b443a3e04a66fd4a6a6d
Author: Andrew Montalenti <an...@parsely.com>
Date:   2015-04-23T20:41:39Z

    add support for "error" command in ShellSpout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-796] Add support for "error" command in...

Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/533#issuecomment-97610607
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-796] Add support for "error" command in...

Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/533#issuecomment-99924195
  
    Thanks @amontalenti. I merged this into master, 0.10.x-branch, and 0.9.x-branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-796] Add support for "error" command in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Add support for "error" command in ShellSpout

Posted by amontalenti <gi...@git.apache.org>.
Github user amontalenti commented on the pull request:

    https://github.com/apache/storm/pull/533#issuecomment-95717037
  
    By the way, I added this and all the existing test cases pass via `mvn`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: [STORM-796] Add support for "error" command in...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/533#issuecomment-95723096
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---