You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/10 09:31:28 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #18406: [fix][client] Fix possible npe

tisonkun commented on code in PR #18406:
URL: https://github.com/apache/pulsar/pull/18406#discussion_r1018848938


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1296,6 +1296,9 @@ private void checkRequestTimeout() {
                 break;
             }
             request = requestTimeoutQueue.poll();
+            if (request == null){

Review Comment:
   ```suggestion
               if (request == null) {
   ```
   
   I suspect checkstyle can fail here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org