You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/04 19:54:40 UTC

[GitHub] [iceberg] wypoon commented on pull request #3799: Hotfix: Attach Test annotation to testDeleteFromTableAtSnapshot

wypoon commented on pull request #3799:
URL: https://github.com/apache/iceberg/pull/3799#issuecomment-1005124840


   @izchen thanks for the explanation. I'd forgotten about the fact that `canDeleteWhere` was added to `SupportsDelete` only in Spark 3.1 and is not present in Spark 3.0. The fact that we didn't try to clean up all such differences when we reorganized the Spark support into separate directories tripped me up. I think I inadvertently omitted the `@Test` annotation for the new test and didn't mean to disable it, but this omission led to the CI passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org