[jira] [Commented] (FLINK-1077) Flakey test CliFrontendPackageProgramTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135345#comment-14135345 ] 

ASF GitHub Bot commented on FLINK-1077:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/incubator-flink/pull/120

    [FLINK-1077] Improved error message if test fails

    I could not reproduce the mentioned error, but if the error occurs again a better error message will be printed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/incubator-flink Flink-1077

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #120
    
----
commit a71ccec4a50ee73694213dc5a5a6f476a6ad5610
Author: twalthr <in...@twalthr.com>
Date:   2014-09-16T12:05:40Z

    [FLINK-1077] Improved error message if test fails

----


> Flakey test CliFrontendPackageProgramTest
> -----------------------------------------
>
>                 Key: FLINK-1077
>                 URL: https://issues.apache.org/jira/browse/FLINK-1077
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Stephan Ewen
>            Assignee: Timo Walther
>
> Test is error is CliFrontendPackageProgramTest # testPlanWithExternalClass()
> The error occurs in my recent travis builds one in 10 times or so.
> The following stack trace describes the error:
> {code}
> java.lang.AssertionError
>  at org.junit.Assert.fail(Assert.java:86)
>  at org.junit.Assert.assertTrue(Assert.java:41)
>  at org.junit.Assert.assertTrue(Assert.java:52)
>  at org.apache.flink.client.CliFrontendPackageProgramTest$1.loadClass(CliFrontendPackageProgramTest.java:249)
> {code}
> Is it possible that race conditions cause the classloader to be used for different classes as well? In any case, the test should change the assertion to assertEquals, such that the expected name is part of the error message (helps debugging what went wrong).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)