You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/11/15 23:08:26 UTC
[GitHub] [helix] xyuanlu opened a new pull request #1905: Fix input for stoppable rest API
xyuanlu opened a new pull request #1905:
URL: https://github.com/apache/helix/pull/1905
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#1903
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
User will hit a 500 error when passing the following input to stoppable API.
`instance_name/stoppable -d '{"customized_values": {"keys" : "cc"}}'` or
`instance_name/stoppable -d '{}'`
Reason:
```
String customizedInput = null; <------------- <1>
if (node.get(InstancesAccessor.InstancesProperties.customized_values.name()) != null) {
customizedInput = node.get(InstancesAccessor.InstancesProperties.customized_values.name()).textValue(); <<<----- <2>
}
```
This is shared code that reads user input Json payload.
<1> is the cause of this problem. If there is no "customized_values" defined in the payload, "customizedInput" will be null and cause nullptr exception.
<2> is another problem we have. JsonNode.textValue() will only convert Textual value this node contains, iff it is a textual JSON node (comes from JSON String value entry). (https://fasterxml.github.io/jackson-databind/javadoc/2.7/com/fasterxml/jackson/databind/JsonNode.html#textValue()).
It will return null is user provide a KV map, witch is a container node instead of a textual node. We should use toString() here.
### Tests
- [X] The following tests are written for this issue:
NA
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #1905: Fix input for stoppable rest API
Posted by GitBox <gi...@apache.org>.
junkaixue merged pull request #1905:
URL: https://github.com/apache/helix/pull/1905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1905: Fix input for stoppable rest API
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1905:
URL: https://github.com/apache/helix/pull/1905#issuecomment-970635699
This PR is ready to be merged. Approved by @junkaixue. #Thanks!
Final commit message:
"Fix input for stoppable rest API ".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #1905: Fix input for stoppable rest API
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on pull request #1905:
URL: https://github.com/apache/helix/pull/1905#issuecomment-970635222
Before this fix, helix-rest will crush when user pass anything to
```
"customize_values": {"k": "v"}
```
And we always return an empty map when user has
```
"customize_values": {}
```
I think passing an empty may should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org