You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/18 08:58:16 UTC
[GitHub] [commons-rng] arturobernalg opened a new pull request #80: Minor Improvement:
arturobernalg opened a new pull request #80:
URL: https://github.com/apache/commons-rng/pull/80
* Add final on private variable
* fix javadoc
* Use Array Filling
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] asfgit merged pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #80:
URL: https://github.com/apache/commons-rng/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] aherbert commented on a change in pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#discussion_r559559941
##########
File path: commons-rng-simple/src/main/java/org/apache/commons/rng/simple/ThreadLocalRandomSource.java
##########
@@ -69,7 +69,7 @@
*
* <p>This should only be modified to create new instances in a synchronized block.
*/
- private static EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
+ private static final EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
Review comment:
This now fails checkstyle naming conventions. Please rename to SOURCES.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] coveralls commented on pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#issuecomment-762208005
[](https://coveralls.io/builds/36400399)
Coverage decreased (-0.0001%) to 99.508% when pulling **0a7891093683eaf3b560cabca675f9735003d9fd on arturobernalg:feature/feature/minor_improvement** into **b9f778cbf25dc4f21fb6454392424ccf7276cdeb on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] coveralls edited a comment on pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#issuecomment-762208005
[](https://coveralls.io/builds/36408460)
Coverage decreased (-0.0001%) to 99.508% when pulling **881650c63cbeefa8ba7d2f9404cf8be5de1c6e25 on arturobernalg:feature/feature/minor_improvement** into **b9f778cbf25dc4f21fb6454392424ccf7276cdeb on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] arturobernalg commented on a change in pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#discussion_r559562830
##########
File path: commons-rng-simple/src/main/java/org/apache/commons/rng/simple/ThreadLocalRandomSource.java
##########
@@ -69,7 +69,7 @@
*
* <p>This should only be modified to create new instances in a synchronized block.
*/
- private static EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
+ private static final EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
Review comment:
Changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-rng] aherbert commented on a change in pull request #80: Minor Improvement:
Posted by GitBox <gi...@apache.org>.
aherbert commented on a change in pull request #80:
URL: https://github.com/apache/commons-rng/pull/80#discussion_r559559941
##########
File path: commons-rng-simple/src/main/java/org/apache/commons/rng/simple/ThreadLocalRandomSource.java
##########
@@ -69,7 +69,7 @@
*
* <p>This should only be modified to create new instances in a synchronized block.
*/
- private static EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
+ private static final EnumMap<RandomSource, ThreadLocal<UniformRandomProvider>> sources =
Review comment:
This now fails checkstyle naming convensions. Please rename to SOURCES.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org