You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/07/11 21:08:07 UTC
Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-2988
https://issues.apache.org/jira/browse/ACCUMULO-2988
Repository: accumulo
Description
-------
forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
Diffs
-----
README c2c2446dc0312c64427c2d7205056c72b2cfdec2
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
Diff: https://reviews.apache.org/r/23413/diff/
Testing
-------
ran through test upgrade
* Install 1.4.5
* Load a variety of table storage configs
** 156M cells w/no compression, bloom filter on, block cache on
** 156M cells w/lzo compression, bloom filter off, block cache off
** 156M cells w/snappy compression, bloom filters on, block cache off
** 156M cells w/snappy compression, bloom filters off, block cache on
* Upgrade according to README to 1.6.1-SNAP+patches
* Verify correct contents readable
* force compaction
* restart cluster
* Verify correct contents readable
Thanks,
Sean Busbey
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by ke...@deenlo.com.
> On July 28, 2014, 4:04 p.m., kturner wrote:
> > When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do anything to verify delete entires for normal and metadata tablets when upgrading from 1.4 to 1.6?
>
> Sean Busbey wrote:
> I mostly focused on testing with walogs present. I also tried a clean shutdown, but I don't recall if that succeeded in avoiding all walogs.
>
> I forced delete entries by doing compactions (this is how I first found ACCUMULO-2899.
>
> 1.5 to 1.6 upgrade should still be fine. I *think* I tested that, but to be honest it's been too long now and I don't recall.
>
> Mike Drob wrote:
> Just got done testing 1.5 upgrades to 1.6+this patch. Everything is green!
>
> Sean Busbey wrote:
> Keith, any other concerns?
No concerns at the moment.
Thanks Mike.
I want to poke at this some, but I have not gotten around to it. I can do that after this applied an open issues if I find anything.
- kturner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48861
-----------------------------------------------------------
On July 26, 2014, 4:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 4:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Mike Drob <md...@mdrob.com>.
> On July 28, 2014, 4:04 p.m., kturner wrote:
> > When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do anything to verify delete entires for normal and metadata tablets when upgrading from 1.4 to 1.6?
>
> Sean Busbey wrote:
> I mostly focused on testing with walogs present. I also tried a clean shutdown, but I don't recall if that succeeded in avoiding all walogs.
>
> I forced delete entries by doing compactions (this is how I first found ACCUMULO-2899.
>
> 1.5 to 1.6 upgrade should still be fine. I *think* I tested that, but to be honest it's been too long now and I don't recall.
Just got done testing 1.5 upgrades to 1.6+this patch. Everything is green!
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48861
-----------------------------------------------------------
On July 26, 2014, 4:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 4:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
> On July 28, 2014, 4:04 p.m., kturner wrote:
> > When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do anything to verify delete entires for normal and metadata tablets when upgrading from 1.4 to 1.6?
>
> Sean Busbey wrote:
> I mostly focused on testing with walogs present. I also tried a clean shutdown, but I don't recall if that succeeded in avoiding all walogs.
>
> I forced delete entries by doing compactions (this is how I first found ACCUMULO-2899.
>
> 1.5 to 1.6 upgrade should still be fine. I *think* I tested that, but to be honest it's been too long now and I don't recall.
>
> Mike Drob wrote:
> Just got done testing 1.5 upgrades to 1.6+this patch. Everything is green!
Keith, any other concerns?
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48861
-----------------------------------------------------------
On July 26, 2014, 4:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 4:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
> On July 28, 2014, 4:04 p.m., kturner wrote:
> > When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do anything to verify delete entires for normal and metadata tablets when upgrading from 1.4 to 1.6?
I mostly focused on testing with walogs present. I also tried a clean shutdown, but I don't recall if that succeeded in avoiding all walogs.
I forced delete entries by doing compactions (this is how I first found ACCUMULO-2899.
1.5 to 1.6 upgrade should still be fine. I *think* I tested that, but to be honest it's been too long now and I don't recall.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48861
-----------------------------------------------------------
On July 26, 2014, 4:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 4:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48861
-----------------------------------------------------------
When testing the 1.4 to 1.6 upgrade, did you test with and without walogs? Does the 1.5 to 1.6 upgrade still work ok after this patch? Did you do anything to verify delete entires for normal and metadata tablets when upgrading from 1.4 to 1.6?
- kturner
On July 26, 2014, 4:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 4:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48843
-----------------------------------------------------------
Ship it!
Ship It!
- Christopher Tubbs
On July 26, 2014, 12:07 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 26, 2014, 12:07 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/
-----------------------------------------------------------
(Updated July 26, 2014, 4:07 a.m.)
Review request for accumulo.
Changes
-------
updated for additional feedback from Christopher.
Bugs: ACCUMULO-2988
https://issues.apache.org/jira/browse/ACCUMULO-2988
Repository: accumulo
Description
-------
forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
Diffs (updated)
-----
README c2c2446dc0312c64427c2d7205056c72b2cfdec2
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
Diff: https://reviews.apache.org/r/23413/diff/
Testing
-------
ran through test upgrade
* Install 1.4.5
* Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
** no compression, bloom filter on, block cache on
** lzo compression, bloom filter off, block cache off
** snappy compression, bloom filters on, block cache off
** snappy compression, bloom filters off, block cache on
* Upgrade according to README to 1.6.1-SNAP+patches
* Verify correct contents readable
* force compaction
* restart cluster
* Verify correct contents readable
Thanks,
Sean Busbey
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
> On July 17, 2014, 7:42 p.m., Bill Havanki wrote:
> > README, line 171
> > <https://reviews.apache.org/r/23413/diff/2/?file=634435#file634435line171>
> >
> > Worth explaining how to delete operations, given that the command to list them is provided above?
I am torn. I kind of want someone to have to do some digging, mostly because it is dangerous.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48040
-----------------------------------------------------------
On July 17, 2014, 7:15 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 7:15 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review48040
-----------------------------------------------------------
Ship it!
Looks good to me...
README
<https://reviews.apache.org/r/23413/#comment84288>
Worth explaining how to delete operations, given that the command to list them is provided above?
- Bill Havanki
On July 17, 2014, 3:15 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 3:15 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/
-----------------------------------------------------------
(Updated July 17, 2014, 7:15 p.m.)
Review request for accumulo.
Changes
-------
updated for feedback from Christopher.
Bugs: ACCUMULO-2988
https://issues.apache.org/jira/browse/ACCUMULO-2988
Repository: accumulo
Description
-------
forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
Diffs (updated)
-----
README c2c2446dc0312c64427c2d7205056c72b2cfdec2
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
Diff: https://reviews.apache.org/r/23413/diff/
Testing
-------
ran through test upgrade
* Install 1.4.5
* Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
** no compression, bloom filter on, block cache on
** lzo compression, bloom filter off, block cache off
** snappy compression, bloom filters on, block cache off
** snappy compression, bloom filters off, block cache on
* Upgrade according to README to 1.6.1-SNAP+patches
* Verify correct contents readable
* force compaction
* restart cluster
* Verify correct contents readable
Thanks,
Sean Busbey
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 11, 2014, 11:05 p.m., Christopher Tubbs wrote:
> > server/base/src/main/java/org/apache/accumulo/server/Accumulo.java, lines 58-60
> > <https://reviews.apache.org/r/23413/diff/1/?file=628539#file628539line58>
> >
> > I'd think this method could just be dropped in favor of the new one. Is there any reason we'd still call this?
>
> Sean Busbey wrote:
> My guess is @mdrob didn't want to figure out where it might be used since it's public. Leaving it in will help minimize code signature churn, esp if we update our upgrade process later to not allow multiple versions.
>
> Okay to fix in a follow on jira?
It's a public method, but not "public API" (nothing in the server package is). If there's any callers still using this, they should be made explicit, in case there's something that was overlooked in this transition. It's not a blocker, but I think it's sensible to do now, rather than later. It's just cleanup.
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review47681
-----------------------------------------------------------
On July 17, 2014, 3:15 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 3:15 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
> On July 12, 2014, 3:05 a.m., Christopher Tubbs wrote:
> > server/base/src/main/java/org/apache/accumulo/server/Accumulo.java, lines 58-60
> > <https://reviews.apache.org/r/23413/diff/1/?file=628539#file628539line58>
> >
> > I'd think this method could just be dropped in favor of the new one. Is there any reason we'd still call this?
My guess is @mdrob didn't want to figure out where it might be used since it's public. Leaving it in will help minimize code signature churn, esp if we update our upgrade process later to not allow multiple versions.
Okay to fix in a follow on jira?
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review47681
-----------------------------------------------------------
On July 11, 2014, 7:19 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 7:19 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/#review47681
-----------------------------------------------------------
Thanks for doing this! Would be great to see this get in for 1.6.1. Pushing ACCUMULO-2145 might make it easier to test this.
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java
<https://reviews.apache.org/r/23413/#comment83816>
I'd think this method could just be dropped in favor of the new one. Is there any reason we'd still call this?
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java
<https://reviews.apache.org/r/23413/#comment83817>
This is kind of an important check. Perhaps move this to a method like "boolean canUpgradeFromDataVersion(int version);" with a comment?
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java
<https://reviews.apache.org/r/23413/#comment83818>
We have many different kinds of versions. Please clarify the constant (something like "TWO_DATA_VERSIONS_AGO"), so it's not misused.
server/master/src/main/java/org/apache/accumulo/master/Master.java
<https://reviews.apache.org/r/23413/#comment83819>
prefer putting this check into a method (canUpgrade? needsUpgrade?... whatever is most appropriate)
server/master/src/main/java/org/apache/accumulo/master/Master.java
<https://reviews.apache.org/r/23413/#comment83820>
should be in a descriptive function (see previous comments)
server/master/src/main/java/org/apache/accumulo/master/Master.java
<https://reviews.apache.org/r/23413/#comment83821>
Avoid the string "!METADATA". Log messages should refer to a generic "metadata table" or similar, to be consistent with previous changes, which purged specific table names from being referenced (especially when it's a string literal instead of a constant). This is for future-proofing any other metadata changes we might make later.
- Christopher Tubbs
On July 11, 2014, 3:19 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23413/
> -----------------------------------------------------------
>
> (Updated July 11, 2014, 3:19 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-2988
> https://issues.apache.org/jira/browse/ACCUMULO-2988
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
>
>
> Diffs
> -----
>
> README c2c2446dc0312c64427c2d7205056c72b2cfdec2
> server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
> server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
> server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
> server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
>
> Diff: https://reviews.apache.org/r/23413/diff/
>
>
> Testing
> -------
>
> ran through test upgrade
>
> * Install 1.4.5
> * Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
> ** no compression, bloom filter on, block cache on
> ** lzo compression, bloom filter off, block cache off
> ** snappy compression, bloom filters on, block cache off
> ** snappy compression, bloom filters off, block cache on
> * Upgrade according to README to 1.6.1-SNAP+patches
> * Verify correct contents readable
> * force compaction
> * restart cluster
> * Verify correct contents readable
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 23413: ACCUMULO-2988 Upgrade from 1.4 direct to 1.6
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23413/
-----------------------------------------------------------
(Updated July 11, 2014, 7:19 p.m.)
Review request for accumulo.
Changes
-------
clarified upgrade test data
Bugs: ACCUMULO-2988
https://issues.apache.org/jira/browse/ACCUMULO-2988
Repository: accumulo
Description
-------
forward ports of some patches around 1.4 -> 1.5 upgrades to the 1.6 branch, as well as new additions.
Diffs
-----
README c2c2446dc0312c64427c2d7205056c72b2cfdec2
server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 68d862d5baaad04ff38789155c0fb60ac18f92b8
server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac
server/master/src/main/java/org/apache/accumulo/master/Master.java c367ae0c2febbb297924da4a87ef1d91104d94c4
Diff: https://reviews.apache.org/r/23413/diff/
Testing (updated)
-------
ran through test upgrade
* Install 1.4.5
* Load a variety of table storage configs, each wi/156M cells (~4GB uncompressed)
** no compression, bloom filter on, block cache on
** lzo compression, bloom filter off, block cache off
** snappy compression, bloom filters on, block cache off
** snappy compression, bloom filters off, block cache on
* Upgrade according to README to 1.6.1-SNAP+patches
* Verify correct contents readable
* force compaction
* restart cluster
* Verify correct contents readable
Thanks,
Sean Busbey