You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Yan Fang (JIRA)" <ji...@apache.org> on 2014/08/15 09:25:20 UTC
[jira] [Commented] (SAMZA-383) Switch version button may link to
invalid url when we add/delete pages in latest version
[ https://issues.apache.org/jira/browse/SAMZA-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098286#comment-14098286 ]
Yan Fang commented on SAMZA-383:
--------------------------------
For (2) situation, I have a simple proposal:
whenever we want to delete a page, we do not "really" delete it. Instead, we just change the
{code}
layout:page
{code}
to
{code}
layout:page-abandoned (or whatever name making sense)
{code}
The _layout/page-abandoned.html only shows messages saying " this page is deleted in the latest version. "
By doing this, we will not have invalid url and give friendly information.
pro:
1. it's easy to implement: add one layout html in _layout directory and one sentence in README file.
2. we do not need to change publish-site.sh, which actually never does "remove" operation for SVN files.
con:
do not delete anything actually. We may end up having more and more files in the versioned directory.
Still have no solution to (1) situation :(.
> Switch version button may link to invalid url when we add/delete pages in latest version
> ----------------------------------------------------------------------------------------
>
> Key: SAMZA-383
> URL: https://issues.apache.org/jira/browse/SAMZA-383
> Project: Samza
> Issue Type: Bug
> Components: docs
> Reporter: Yan Fang
>
> Current switch button in right-up corner has bugs in the following two situations:
> 1. if we add a new versioned page which only exists in the latest version but not previous version, when we click the switch button, it goes to an invalid url.
> e.g. we have page
> {code}
> http://samza.incubator.apache.org/learn/documentation/latest/new.html
> {code}
> the switch button in this page will link to
> {code}
> http://samza.incubator.apache.org/learn/documentation/0.7.0/new.html
> {code}
> which actually does not exist.
> 2. on the other hand, if we delete a versioned page in latest version, whenever we click the switch button in old page, it links to an invalid link too.
> e.g. we have old page
> {code}
> http://samza.incubator.apache.org/learn/documentation/0.7.0/old.html
> {code}
> The switch button in this page actually links to
> {code}
> http://samza.incubator.apache.org/learn/documentation/latest/old.html
> {code}
> However, obviously, the link is invalid because we already delete this page.
--
This message was sent by Atlassian JIRA
(v6.2#6252)