You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/28 13:49:23 UTC

[GitHub] [netbeans] jtulach opened a new pull request, #4047: Sampler module has a lot of obsolete dependencies

jtulach opened a new pull request, #4047:
URL: https://github.com/apache/netbeans/pull/4047

   We are trying to use [sampler module in our application](https://github.com/enso-org/enso/pull/3389), but we realized it has a lot of unnecessary dependencies. Ideally we just use the `org-netbeans-modules-sampler.jar` on its own - should in most cases work until one calls into `InternalSampler` - we don't.
   
   However even if one uses `InternalSampler` there are some obsoleted dependencies that make the module [too heavyweight](http://wiki.apidesign.org/wiki/HeavyWeight). This PR clears them:
   - using just simpler progress API
   - using `FileObject.getLookup()`
   - avoiding dialogs in favor of "exception like" report
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #4047: Sampler module has a lot of obsolete dependencies

Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4047:
URL: https://github.com/apache/netbeans/pull/4047#issuecomment-1112246440

   Neil is not doing RC2 removing from reviewer. Waiting for the test to complete.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni merged pull request #4047: Sampler module has a lot of obsolete dependencies

Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4047:
URL: https://github.com/apache/netbeans/pull/4047


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on pull request #4047: Sampler module has a lot of obsolete dependencies

Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4047:
URL: https://github.com/apache/netbeans/pull/4047#issuecomment-1113008429

   LGTM merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists