You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/07 03:22:03 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35123: [SPARK-37834][PYTHON][INFRA] Reenable length check in Python linter
dongjoon-hyun commented on a change in pull request #35123:
URL: https://github.com/apache/spark/pull/35123#discussion_r780003871
##########
File path: python/pyspark/resource/profile.py
##########
@@ -155,12 +155,9 @@ def require(
)
else:
if self._java_resource_profile_builder is not None:
- if (
- resourceRequest._java_executor_resource_requests is not None # type: ignore[attr-defined]
- ):
- self._java_resource_profile_builder.require(
- resourceRequest._java_executor_resource_requests # type: ignore[attr-defined]
- )
+ r = resourceRequest._java_executor_resource_requests # type: ignore[attr-defined]
Review comment:
Yes, it looks like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org