You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by er...@apache.org on 2015/03/03 05:53:42 UTC
svn commit: r1663525 - in /lucene/dev/trunk/solr: CHANGES.txt
core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
Author: erick
Date: Tue Mar 3 04:53:41 2015
New Revision: 1663525
URL: http://svn.apache.org/r1663525
Log:
SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
Modified:
lucene/dev/trunk/solr/CHANGES.txt
lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
Modified: lucene/dev/trunk/solr/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/CHANGES.txt?rev=1663525&r1=1663524&r2=1663525&view=diff
==============================================================================
--- lucene/dev/trunk/solr/CHANGES.txt (original)
+++ lucene/dev/trunk/solr/CHANGES.txt Tue Mar 3 04:53:41 2015
@@ -175,6 +175,9 @@ Bug Fixes
* SOLR-7171: BaseDistributedSearchTestCase now clones getSolrHome() for each subclass,
and consistently uses getSolrXml(). (hossman)
+* SOLR-6657: DocumentDictionaryFactory requires weightField to be mandatory, but it shouldn't
+ (Erick Erickson)
+
Optimizations
----------------------
Modified: lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java?rev=1663525&r1=1663524&r2=1663525&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java (original)
+++ lucene/dev/trunk/solr/core/src/java/org/apache/solr/spelling/suggest/DocumentDictionaryFactory.java Tue Mar 3 04:53:41 2015
@@ -46,10 +46,7 @@ public class DocumentDictionaryFactory e
if (field == null) {
throw new IllegalArgumentException(FIELD + " is a mandatory parameter");
}
- if (weightField == null) {
- throw new IllegalArgumentException(WEIGHT_FIELD + " is a mandatory parameter");
- }
-
+
return new DocumentDictionary(searcher.getIndexReader(), field, weightField, payloadField);
}