You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/08/31 20:40:27 UTC

[PR] normalize firestoreIO [beam]

aIbrahiim opened a new pull request, #39941:
URL: https://github.com/apache/beam/pull/39941

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #39941:
URL: https://github.com/apache/beam/pull/39941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3917196439


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
   This is only used in tests. Consider put it into 'test' extra and make the import optional in integration_tests.py



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39941:
URL: https://github.com/apache/beam/pull/39941#issuecomment-5539051055

   PTAL @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3944046157


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
   R: @Abacn 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3943444213


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
    I tried moving it to the test extra and made the import optional in integration_tests.py
    but with it in test, plain [test] tox envs pull in google-cloud-core without google.cloud.storage and GCS / BigQuery dataframe tests start failing (ModuleNotFoundError: google.cloud.storage, etc.)
   
   so I kept the optional import, but left the package under gcp next to the other GCP test clients (bigtable/spanner), or do you suggest another splitting approach?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39941:
URL: https://github.com/apache/beam/pull/39941#issuecomment-5496403175

   Same as other IOs, we should be able to add a basic integration test (e.g. in extended tests), one can use 'firestoredb' as default firestore database, like other tests did
   
   https://github.com/apache/beam/blob/3b476c42095684279c71518bade1dc0f1eccae08/runners/google-cloud-dataflow-java/build.gradle#L156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3944046157


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
   R: @Abacn 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3950392631


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
   R: @Abacn 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39941:
URL: https://github.com/apache/beam/pull/39941#issuecomment-5498882750

   Run Yaml_Xlang_Direct PostCommit databases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39941:
URL: https://github.com/apache/beam/pull/39941#issuecomment-5513292982

   cc: @Abacn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39941:
URL: https://github.com/apache/beam/pull/39941#issuecomment-5514310950

   Assigning reviewers:
   
   R: @shunping for label python.
   R: @Abacn for label java.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] normalize firestoreIO [beam]

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3960909567


##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
               # errors raised during async flushes instead of swallowing them.
               'google-cloud-bigtable>=2.42.0,<3',
               'google-cloud-build>=3.35.0,<4',
+              'google-cloud-firestore>=2.0.0,<3',

Review Comment:
   `beam[gcp]` depends on bigtable/spanner because Python SDK has native BigtableIO and SpannerIO (the latter is subject for removal though).
   
   I think we can create a "gcp_test" extra and add it to "beamPythonExtra" https://github.com/apache/beam/blob/6a0bd90065ac35b70fc9888055319593b392a9fc/.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml#L85 here
   
   In the future we may remove spanner dependency from `[gcp]` and also other test only dependencies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org