You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/06/01 18:56:26 UTC

[GitHub] [incubator-mxnet] Chouffe opened a new pull request #15121: [clojure] clojurify function names in image.clj namespace

Chouffe opened a new pull request #15121: [clojure] clojurify function names in image.clj namespace
URL: https://github.com/apache/incubator-mxnet/pull/15121
 
 
   ## Description ##
   
   The `image` namespace is using some functions that are not named the `clojure way`. It is an attempt to clojurify these functions.
   The namespaces are supposed to be imported qualified and having the suffix `-image` in the following functions is redundant
   * `resize-image`
   * `decode-image`
   * `read-image`
   
   One should be able to call `image/resize`, `image/decode`, `image/read` instead.
   
   The function `to-image` is misleading as we dont know what is turned into an image. I suggest to name it `ndarray->image` instead.
   
   * `deprecated` is added in metadata
   * `deprecated` is added in docstrings

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services