You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sohum2002 <gi...@git.apache.org> on 2017/10/10 03:15:25 UTC
[GitHub] spark pull request #19463: Cleanup comment in RDDSuite test
GitHub user sohum2002 opened a pull request:
https://github.com/apache/spark/pull/19463
Cleanup comment in RDDSuite test
## What changes were proposed in this pull request?
There were not changes proposed in this pull request.
## How was this patch tested?
There were not tests in this pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sohum2002/spark cleanup-RDDSuite-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19463
----
commit c83ab1e5c51311ecb293e47e9c9694a9a49cfbaa
Author: Sachathamakul, Patrachai (Agoda) <pa...@agoda.com>
Date: 2017-10-10T03:14:27Z
Cleanup comment in RDDSuite test
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19463: Cleanup comment in RDDSuite test
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19463
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19463: Cleanup comment in RDDSuite test
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19463
Could you please update the description why you want to apply this change?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19463: Cleanup comment in RDDSuite test
Posted by sohum2002 <gi...@git.apache.org>.
Github user sohum2002 closed the pull request at:
https://github.com/apache/spark/pull/19463
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19463: Cleanup comment in RDDSuite test
Posted by sohum2002 <gi...@git.apache.org>.
Github user sohum2002 commented on the issue:
https://github.com/apache/spark/pull/19463
I just added "Removed one comment from RDDSuite." to the PR description. Will this suffice?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19463: Cleanup comment in RDDSuite test
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19463
This comment seems valid. It's stating the question the test is trying to answer. I'd close this please, as it would be trivial even if valid
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org