Re: [I] Failed to execute rollback due to HoodieIOException: Could not delete instant [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #15067:
URL: https://github.com/apache/hudi/issues/15067#issuecomment-4795309365

   Triage: this looks **fixed** on current master.
   
   The contemporaneous fix is [HUDI-3604 / PR #5114](https://github.com/apache/hudi/pull/5114) — commit `484b3407e00c` (2022-03-26) — "Adjust the order of timeline changes in rollbacks". That change:
   
   1. Moved `deleteInflightAndRequestedInstant(...)` inside the transaction lock together with `finishRollback(...)`.
   2. Reordered to: write rollback metadata → delete inflight commit → transition rollback `inflight → completed`, so a partial crash leaves a re-driveable `rollback.requested`.
   
   Follow-on hardening makes the originally reported failure mode (continuous Deltastreamer + COW + async clustering & cleaning racing the upgrade-time `rollbackFailedWrites`) unreachable on master:
   - Subsequent reaffirmation of the ordering invariant in HUDI-6736 (#9521).
   - Locking improvements in HUDI-9387 (commit-time created and persisted in one transaction).
   - Recent rollback-concurrency fixes: PR #18089 (detect rollback conflicts with ongoing commits), PR #18093 (don't delete pending rollback plan on read failure), PR #18033 (allow MDT bootstrap when pending commits are being rolled back), HUDI-9559 (#13497, account for failed deletion in rollback execution).
   
   Current code: see `BaseRollbackActionExecutor.finishRollback` (`hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java#L268-L298`) — `txnManager.beginStateChange(...)` now wraps both the metadata write and `deleteInflightAndRequestedInstant`.
   
   If anyone is still able to reproduce on a recent release (≥0.12, ideally master), please share a repro and re-open. Otherwise this can be closed.
   
   — triaged via static-code review, not a runtime repro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org