You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/09 00:05:58 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4005: Set key for message when using function publish

sijie commented on a change in pull request #4005: Set key for message when using function publish
URL: https://github.com/apache/pulsar/pull/4005#discussion_r273283165
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/functions/context.py
 ##########
 @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value):
   @abstractmethod
   def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None):
 
 Review comment:
   I am not a python expert. but this PR doesn't seem to specify `partition_key` in the method signature. how does that work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services