Re: [PR] fix: include port id in materialization reader actor id to fix self-join deadlock [texera]

["Yicong-Huang (via GitHub)" <gi...@apache.org>]

Yicong-Huang commented on PR #4985:
URL: https://github.com/apache/texera/pull/4985#issuecomment-4407608269

   I don't think fixing the port id into the actor's name is the right way to go. port id shouldn't be part of actor name and Actor name should be unique. If we have an operator with 5 input ports, this fix would name the actor to 5 different names.
    
   
   The bug should be on the other lower layer: an actor could have multiple channels, and channels are connected between different ports. I think we did not differentiate channels well, and the fix is deeper than just renames, the gateway logic might also require fix. To fix it you need a deeper understanding of amber. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org