[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10616: usbdev: Fix build error with BOARD_USBDEV_SERIALSTR

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #10616:
URL: https://github.com/apache/nuttx/pull/10616#discussion_r1325291190


##########
drivers/usbdev/composite.h:
##########
@@ -50,6 +50,13 @@
 #define COMPOSITE_CONFIGIDNONE        (0)  /* Config ID = 0 means to return to address mode */
 #define COMPOSITE_CONFIGID            (1)  /* The only supported configuration ID */
 
+/* Descriptor strings */
+
+#define COMPOSITE_MANUFACTURERSTRID     (1)

Review Comment:
   these string is only used in drivers/usbdev/composite_desc.c, so don't need expose to public interface



##########
drivers/usbdev/composite.c:
##########
@@ -38,6 +38,10 @@
 #include <nuttx/usb/usbdev.h>
 #include <nuttx/usb/usbdev_trace.h>
 
+#ifdef CONFIG_BOARD_USBDEV_SERIALSTR
+#include <nuttx/board.h>

Review Comment:
   could you point out where composite driver use the interface from nuttx/board.h?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org