You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/12 19:11:00 UTC
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[ https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=790124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790124 ]
ASF GitHub Bot logged work on HIVE-21456:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/22 19:10
Start Date: 12/Jul/22 19:10
Worklog Time Spent: 10m
Work Description: nrg4878 commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r919315254
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -398,18 +404,16 @@ private static ThriftServer startHttpMetastore(int port, Configuration conf)
// Server thread pool
// Start with minWorkerThreads, expand till maxWorkerThreads and reject
// subsequent requests
- final String threadPoolNamePrefix = "HiveMetastore-HttpHandler-Pool";
- ExecutorService executorService = new ThreadPoolExecutor(
- minWorkerThreads, maxWorkerThreads, 60, TimeUnit.SECONDS,
- new SynchronousQueue<>(), new ThreadFactory() {
- @Override
- public Thread newThread(@NotNull Runnable r) {
- Thread newThread = new Thread(r);
- newThread.setName(threadPoolNamePrefix + ": Thread-" + newThread.getId());
- return newThread;
- }
+ final String threadPoolNameFormat = "Metastore-HTTPHandler-Pool: Thread-%s";
+ // TODO: Add a config for keepAlive time of threads ?
+ ExecutorService executorService = new ThreadPoolExecutor(minWorkerThreads, maxWorkerThreads, 60L,
+ TimeUnit.SECONDS, new SynchronousQueue<>(), r -> {
+ Thread thread = new Thread(r);
+ thread.setDaemon(true);
+ thread.setName("Metastore-HttpHandler-Pool: Thread-" + thread.getId());
Review Comment:
nit: should you use the "threadPoolNameFormat" variable above?
Issue Time Tracking
-------------------
Worklog Id: (was: 790124)
Time Spent: 9.5h (was: 9h 20m)
> Hive Metastore Thrift over HTTP
> -------------------------------
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
> Reporter: Amit Khanna
> Assignee: Sourabh Goyal
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of which it is not possible to access it via Knox. Adding support for Thrift over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.10#820010)