[GitHub] [arrow] kou commented on a diff in pull request #13169: ARROW-16588: [C++][FlightRPC] Don't subclass GTest in test helpers

[GitBox <gi...@apache.org>]

kou commented on code in PR #13169:
URL: https://github.com/apache/arrow/pull/13169#discussion_r874343098


##########
cpp/CMakeLists.txt:
##########
@@ -827,11 +827,6 @@ if(ARROW_USE_XSIMD)
   list(APPEND ARROW_STATIC_LINK_LIBS xsimd)
 endif()
 
-if(ARROW_WITH_UCX)
-  list(APPEND ARROW_LINK_LIBS ucx::ucx)
-  list(APPEND ARROW_STATIC_LINK_LIBS ucx::ucx)
-endif()
-

Review Comment:
   Could you try the following patch?
   
   ```diff
   diff --git a/cpp/src/arrow/flight/transport/ucx/CMakeLists.txt b/cpp/src/arrow/flight/transport/ucx/CMakeLists.txt
   index 71392ec0af..d682ead633 100644
   --- a/cpp/src/arrow/flight/transport/ucx/CMakeLists.txt
   +++ b/cpp/src/arrow/flight/transport/ucx/CMakeLists.txt
   @@ -53,6 +53,7 @@ if(ARROW_BUILD_TESTS)
            arrow_flight_static
            arrow_flight_testing_static
            arrow_flight_transport_ucx_static
   +        ucx::ucx
            ${ARROW_TEST_LINK_LIBS})
      else()
        set(ARROW_FLIGHT_UCX_TEST_LINK_LIBS
   @@ -60,6 +61,7 @@ if(ARROW_BUILD_TESTS)
            arrow_flight_shared
            arrow_flight_testing_shared
            arrow_flight_transport_ucx_shared
   +        ucx::ucx
            ${ARROW_TEST_LINK_LIBS})
      endif()
      add_arrow_test(flight_transport_ucx_test
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org