[GitHub] [solr] madrob commented on a change in pull request #399: SOLR-15776 Make Admin UI play well with Authorization

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #399:
URL: https://github.com/apache/solr/pull/399#discussion_r785269023



##########
File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java
##########
@@ -110,6 +113,19 @@ public AuthorizationResponse authorize(AuthorizationContext context) {
     return flag.rsp;
   }
 
+  /**
+   * Retrieves permission names for a given set of roles
+   */
+  public Set<String> getPermissionNamesForRoles(Set<String> roles) {
+    Set<String> permissions = new HashSet<>();
+    for (String r : roles) {
+      if (roleToPermissionsMap.containsKey(r)) {

Review comment:
       Let’s use a fully functional approach with flat map rather than mixing here

##########
File path: solr/webapp/web/js/angular/permissions.js
##########
@@ -0,0 +1,51 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+const permissions = {
+  COLL_EDIT_PERM: "collection-admin-edit",

Review comment:
       I really don’t like that this is duplicated but I don’t have a better approach 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org