[jira] [Comment Edited] (HBASE-25279) Non-daemon thread in ZKWatcher

["Josh Elser (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264535#comment-17264535 ] 

Josh Elser edited comment on HBASE-25279 at 1/14/21, 1:49 AM:
--------------------------------------------------------------

bq. Don't commit it there, please. Not everyone agrees it is the right approach.

Uh.. ok? What's the issue? What's your expectation in re-opening this then (if not to just change the fixVersion).

I'm confused why we don't fix the bug and then you (or whomever has objections) can make whatever changes they like. I'm genuinely confused how this change is contentious.


was (Author: elserj):
bq. Don't commit it there, please. Not everyone agrees it is the right approach.

Uh.. ok? What's the issue? What's your expectation in re-opening this then (if not to just change the fixVersion).

I'm confused why we don't fix the bug and then you (or whomever has objections) can fix make whatever changes they like. I'm genuinely confused how this change is contentious.

> Non-daemon thread in ZKWatcher
> ------------------------------
>
>                 Key: HBASE-25279
>                 URL: https://issues.apache.org/jira/browse/HBASE-25279
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons which will prevent clean shut downs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)