[GitHub] [spark] mathewjacob1002 commented on a diff in pull request #42308: [Spark Ticket][WIP]Added a warning to pop up in the case the user doesn't use gpus

["mathewjacob1002 (via GitHub)" <gi...@apache.org>]

mathewjacob1002 commented on code in PR #42308:
URL: https://github.com/apache/spark/pull/42308#discussion_r1283481714


##########
python/pyspark/ml/deepspeed/deepspeed_distributor.py:
##########
@@ -97,6 +98,8 @@ def __init__(
             _ssl_conf=DeepspeedTorchDistributor._DEEPSPEED_SSL_CONF,
         )
         self.cleanup_deepspeed_conf = False
+        if not useGpu:
+            warnings.warn(message="Deepspeed usage with CPUs is not very well supported at this time.")

Review Comment:
   we want the phrase to be more of a warning rather than a flat statement. Technically, I think Deepspeed supports *some* CPU use cases but it's very unstable + flaky. If the user knows their program will work, we might as well let them try it right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org