You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/14 17:12:41 UTC

[jira] [Commented] (NIFI-3478) GeoEnrich Processor's 'IP Address Attribute' Should Support Expression Language

    [ https://issues.apache.org/jira/browse/NIFI-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866148#comment-15866148 ] 

ASF GitHub Bot commented on NIFI-3478:
--------------------------------------

GitHub user jjmeyer0 opened a pull request:

    https://github.com/apache/nifi/pull/1507

    NIFI-3478: Added Support for EL in GeoEnrichIP

    NIFI-3478: added tests for GeoEnrichIP and added support for expression language on 'IP Address Attribute' property.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jjmeyer0/nifi NIFI-3478

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1507
    
----
commit 5209cd4b94283590415a993065fad16b9bed13d4
Author: JJ <jj...@gmail.com>
Date:   2017-02-14T17:05:51Z

    NIFI-3478: added tests for GeoEnrichIP and added support for expression language on 'IP Address Attribute' property.

----


> GeoEnrich Processor's 'IP Address Attribute' Should Support Expression Language 
> --------------------------------------------------------------------------------
>
>                 Key: NIFI-3478
>                 URL: https://issues.apache.org/jira/browse/NIFI-3478
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Josh Meyer
>            Assignee: Josh Meyer
>            Priority: Trivial
>
> It would be beneficial if the GeoEnrich processor supported expression language. This could be helpful if for some reason a user needs to build the attribute name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)