You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Deshani Geethika <de...@gmail.com> on 2018/07/06 19:13:24 UTC
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I've started to work on Followers Section and pushed the current code to my
fork. (https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
)
I need to create activity_app instance in class FollowersSection in
allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
In class ForgeActivityProfileSection which is in forgeactivity/main.py, the
activity_app instance is created by accessing project instance as
self.activity_app
= self.project.app_instance('activity'). (Line #278)
How can I create activity_app instance in dashboard without a project
instance?
Regards!
On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <de...@gmail.com>
wrote:
> Hi Dave,
>
> I've completed the Tickets section and added a merge request
> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
>
> Please review it and let me know if any improvements required.
>
> Regards!
>
> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
> deshanigeethika@gmail.com> wrote:
>
>> Hi Dave,
>>
>> Thanks. I'm still working on it. Will give you an update soon.
>>
>> Regards!
>>
>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema <da...@brondsema.net>
>> wrote:
>>
>>> Hey Deshani,
>>>
>>> Just wondering how things are going? If you want to push your current
>>> branch,
>>> and let me know if any questions or issues, I can offer some more help.
>>>
>>> I am impressed with how much you've figured out on your own. I'm here
>>> to mentor
>>> and help though too :)
>>>
>>> -Dave
>>>
>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
>>> > Thanks. I'll be there today at 11am EDT.
>>> >
>>> > On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema <dave@brondsema.net
>>> > <ma...@brondsema.net>> wrote:
>>> >
>>> > Thanks, I've taken a look at the code to get familiar with it and
>>> have some
>>> > ideas.
>>> >
>>> > Today I am available today much any time from now until 6pm EDT.
>>> Or tomorrow
>>> > 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can switch
>>> over to chat to
>>> > coordinate too.
>>> >
>>> >
>>> > On 6/26/18 4:04 AM, Deshani Geethika wrote:
>>> > > Hi Dave,
>>> > >
>>> > > I have pushed the current code into my fork.
>>> > >
>>> > (
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
>>> )
>>> > >
>>> > > Please let me know a convenient slot to have a call.
>>> > >
>>> > > Regards!
>>> > >
>>> > > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
>>> dave@brondsema.net
>>> > <ma...@brondsema.net>
>>> > > <mailto:dave@brondsema.net <ma...@brondsema.net>>> wrote:
>>> > >
>>> > > Hey Deshani, do you want to do another video call? If you
>>> want to
>>> > push your
>>> > > current code to a branch then I could take a look at it too,
>>> and
>>> > understand what
>>> > > you have so far. Then we could do a video/screenshare call,
>>> continue with
>>> > > emails, or do chats. Whatever you prefer.
>>> > >
>>> > > -Dave
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > *Deshani Geethika*
>>> > > Undergraduate at Department of Computer Science and Engineering
>>> > > Faculty of Engineering - University of Moratuwa Sri Lanka
>>> > > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>> > > <https://github.com/deshanigtk> | Mobile - +94776383034
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> > Dave Brondsema : dave@brondsema.net <ma...@brondsema.net>
>>> > http://www.brondsema.net : personal
>>> > http://www.splike.com : programming
>>> > <><
>>> >
>>> >
>>> >
>>> > --
>>> > *Deshani Geethika*
>>> > Undergraduate at Department of Computer Science and Engineering
>>> > Faculty of Engineering - University of Moratuwa Sri Lanka
>>> > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>> > <https://github.com/deshanigtk> | Mobile - +94776383034
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Brondsema : dave@brondsema.net
>>> http://www.brondsema.net : personal
>>> http://www.splike.com : programming
>>> <><
>>>
>>
>>
>> --
>> *Deshani Geethika*
>> Undergraduate at Department of Computer Science and Engineering
>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>
>>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
Nice - with this merged it seems like a good spot to do a release of Allura. I
will get that started soon, probably tomorrow.
On 9/18/18 3:14 AM, Deshani Geethika wrote:
> Thanks a lot. I've changed the entry point name into "activity" and added a
> merge request (
> https://forge-allura.apache.org/p/allura/git/merge-requests/282/)
>
> On Tue, Sep 18, 2018 at 3:18 AM Dave Brondsema <da...@brondsema.net> wrote:
>
>> I added some logging to SectionsUtil.load_sections to see what it was
>> getting
>> from the config, and other variables. Looks like the problem is that the
>> section name (entry point name) is "followers" so that needs to be used.
>>
>>
>> On 9/16/18 2:37 PM, Deshani Geethika wrote:
>>> Hi Dave,
>>>
>>> To move up the activity section in dashboard and profile I've modified
>> the
>>> development.ini file. For the user profile, the section order was there
>> but
>>> commented, so that I've uncommented the line. For the dashboard section
>>> order, I've added a similar line, but it doesn't work. (activity section
>> is
>>> not moving up) Do you have any idea about this?
>>> I have committed my changes to the repo. (
>>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/1955539543430eb71e56a995307135d258247b74/
>>> )
>>>
>>> Regards!
>>>
>>> On Thu, Aug 30, 2018 at 1:27 AM Dave Brondsema <da...@brondsema.net>
>> wrote:
>>>
>>>> Hi!
>>>>
>>>> I've merged that merge request, it looks good. I think the title text
>> is
>>>> ok.
>>>> The layout of the logo runs into the main gray content though. It'd be
>>>> nice if
>>>> it had a bit of space like it does on the user profile page, for
>> example.
>>>> I see
>>>> on the user profile page there is an empty <h2 class="project_summary">
>>>> that
>>>> helps push it down.
>>>>
>>>> Another thing that could be polished is the placement of the Activity
>> box
>>>> in the
>>>> right column. On both the dashboard and the profile pages it is part
>> way
>>>> down
>>>> the column, and I think it'd be better at the top of the column. That
>>>> might be
>>>> fixable by CSS rules, but also by the ordering of the widgets. If it is
>>>> the
>>>> first widget then when it floats to the right its ok at the top of the
>>>> column.
>>>> So either by code, or .ini config file you could make it first in the
>>>> profile_sections.order and personal_dashboard_sections.order
>>>>
>>>> On 8/29/18 6:44 AM, Deshani Geethika wrote:
>>>>> Hi Dave,
>>>>>
>>>>> Sorry for the delays. I've done some fixes on dashboard styles and
>> added
>>>> a
>>>>> merge request (
>>>>> https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
>>>>> Please review it and let me know if any improvements required.
>>>>>
>>>>> Also, for the dashboard title, currently it is shown as *username /
>>>>> Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you
>>>> have
>>>>> a better idea for the dashboard title?
>>>>>
>>>>> Regards!
>>>>>
>>>>> On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <
>>>> deshanigeethika@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Thanks a lot. Will try these and let you know
>>>>>>
>>>>>> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net>
>>>> wrote:
>>>>>>
>>>>>>> Sure, here's some thoughts:
>>>>>>>
>>>>>>> Inheriting from TestGitRepo means it gets all the test_* functions,
>> so
>>>>>>> when I
>>>>>>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
>>>>>>> don't want
>>>>>>> to happen. So I'd remove that inheritance. You probably will have
>> to
>>>>>>> duplicate
>>>>>>> the setup_with_tools() function in this file then.
>>>>>>>
>>>>>>> Actually, inheriting from _TestCase in
>>>>>>> forgegit/tests/functional/test_controllers.py might be a good option.
>>>> It
>>>>>>> has
>>>>>>> some setup functions you can use (so you don't have to duplicate
>>>>>>> setup_with_tools) and it doesn't have any test_* functions.
>>>>>>>
>>>>>>> The super() call is supposed to use its own name, like
>>>>>>> super(TestMergeRequestsSection, self).setUp() Not sure if that
>> makes a
>>>>>>> difference here or not.
>>>>>>>
>>>>>>> merge_request() is a function but you don't have parenthesis on `mr=
>>>>>>> self.merge_request` so that function isn't running.
>>>>>>>
>>>>>>> I realized what happened earlier when I didn't see the "Tickets"
>>>> section
>>>>>>> in the
>>>>>>> HTML output of the tickets test! When I was trying this test now, I
>>>> got a
>>>>>>> similar situation where the "Merge Requests" section isn't in the
>> HTML
>>>>>>> output at
>>>>>>> all either. So I looked in the 'test.log' file (where logging goes
>> to
>>>>>>> during
>>>>>>> tests) and saw "Error rendering section MergeRequestsSection: ..."
>> with
>>>>>>> error
>>>>>>> details. So these sections trap errors and log them, instead of
>>>> letting
>>>>>>> the
>>>>>>> whole page error. So looking at the test.log output can help see
>> those
>>>>>>> errors
>>>>>>> when they happen.
>>>>>>>
>>>>>>> You may need to run ThreadLocalODMSession.flush_all() after creating
>>>> the
>>>>>>> merge
>>>>>>> request object. That is a common test pattern we have when tests
>>>> create
>>>>>>> something and then need to view it. (Mainly needed in tests, since
>>>>>>> regular web
>>>>>>> pages will flush at the end of each request).
>>>>>>>
>>>>>>> Hope that helps, let me know how far you get, and I can look at it
>> some
>>>>>>> more if
>>>>>>> needed :)
>>>>>>>
>>>>>>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have started to write a test case for Merge Requests Section. For
>>>>>>> that I
>>>>>>>> have followed ForgeGit tests but it doesn't work for me. I was
>> trying
>>>> to
>>>>>>>> create a merge request and see whether it appears in dashboard.
>>>>>>>>
>>>>>>>> I've pushed the code into my fork
>>>>>>>> <
>>>>>>>
>>>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
>>>>>>>> .
>>>>>>>> Can you kindly take a look at that? Also, please let me know any
>>>>>>> debugging
>>>>>>>> process can be done for methods called internally when creating a
>>>> merge
>>>>>>>> request.
>>>>>>>>
>>>>>>>> Regards!
>>>>>>>>
>>>>>>>> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
>>>>>>> deshanigeethika@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> Thank you for sharing these valuable information. I have added a
>>>> merge
>>>>>>>>> request <
>>>>>>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
>>>>>>>>> Please review it and let me know any further improvements.
>>>>>>>>>
>>>>>>>>> Regards!
>>>>>>>>>
>>>>>>>>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <dave@brondsema.net
>>>
>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>
>>>>>>>>>>> I have tried with adding above lines, but still doesn't work. Can
>>>> you
>>>>>>>>>> take
>>>>>>>>>>> a look at my implementation
>>>>>>>>>>> <
>>>>>>>>>>
>>>>>>>
>>>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>>>>>>>>>>>
>>>>>>>>>>> ?
>>>>>>>>>>>
>>>>>>>>>>> Thanks!
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Here's some debugging process I did, you can try it too:
>>>>>>>>>>
>>>>>>>>>> Tests use the MockSOLR class instead of a real solr instance (so
>>>> that
>>>>>>> you
>>>>>>>>>> don't
>>>>>>>>>> need solr to run tests). I knew that, so I started by going to
>>>>>>>>>> MockSOLR.search() and putting in some print statements to debug
>> it.
>>>>>>> At
>>>>>>>>>> the
>>>>>>>>>> beginning of search() I added:
>>>>>>>>>>
>>>>>>>>>> print q
>>>>>>>>>> print fq
>>>>>>>>>>
>>>>>>>>>> And inside the "for obj in self.db.values():" loop, I added "print
>>>>>>> obj"
>>>>>>>>>>
>>>>>>>>>> My idea was to see what query is happening and what the stored
>>>> objects
>>>>>>>>>> are, and
>>>>>>>>>> see what's not working. I ran just the single test with
>> `nosetests
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>
>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>>>>>>>>>> I noticed there was a 'project_id_s' in the search query, and
>> there
>>>>>>>>>> shouldn't
>>>>>>>>>> be. But after a bit of trial & error to see what was happening, I
>>>>>>>>>> realized that
>>>>>>>>>> was coming from a "update_bin_count" background task, and that
>>>> wasn't
>>>>>>>>>> related to
>>>>>>>>>> the test really.
>>>>>>>>>>
>>>>>>>>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all
>> the
>>>>>>>>>> background
>>>>>>>>>> tasks for now and did it again, and there wasn't any of my print
>>>>>>>>>> statements
>>>>>>>>>> occurring. So the dashboard ticket search wasn't even happening
>> it
>>>>>>> seems.
>>>>>>>>>>
>>>>>>>>>> Then I printed the "response.html" variable to look at the whole
>>>>>>>>>> dashboard page
>>>>>>>>>> and I didn't see the Tickets section in it at all. So indeed,
>> that
>>>>>>>>>> section
>>>>>>>>>> isn't included in this test at all for some reason.
>>>>>>>>>>
>>>>>>>>>> Hopefully those are some helpful examples for this particular
>>>>>>> situation
>>>>>>>>>> and also
>>>>>>>>>> ideas for how to debug high level (like "is it even running?") and
>>>> low
>>>>>>>>>> level (to
>>>>>>>>>> see where things might be not working).
>>>>>>>>>>
>>>>>>>>>> Next step of course is to figure out why in this test the
>> dashboard
>>>>>>>>>> section
>>>>>>>>>> isn't even running. I'll let you work on that. My general
>> strategy
>>>>>>> is
>>>>>>>>>> to put
>>>>>>>>>> debugging in various places to confirm if things are running with
>>>> the
>>>>>>>>>> right
>>>>>>>>>> values, or where they aren't, and narrow down to the spot where it
>>>>>>> goes
>>>>>>>>>> wrong.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Brondsema : dave@brondsema.net
>>>>>>>>>> http://www.brondsema.net : personal
>>>>>>>>>> http://www.splike.com : programming
>>>>>>>>>> <><
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Deshani Geethika*
>>>>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Brondsema : dave@brondsema.net
>>>>>>> http://www.brondsema.net : personal
>>>>>>> http://www.splike.com : programming
>>>>>>> <><
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Deshani Geethika*
>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Brondsema : dave@brondsema.net
>>>> http://www.brondsema.net : personal
>>>> http://www.splike.com : programming
>>>> <><
>>>>
>>>
>>>
>>
>>
>>
>> --
>> Dave Brondsema : dave@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Thanks a lot. I've changed the entry point name into "activity" and added a
merge request (
https://forge-allura.apache.org/p/allura/git/merge-requests/282/)
On Tue, Sep 18, 2018 at 3:18 AM Dave Brondsema <da...@brondsema.net> wrote:
> I added some logging to SectionsUtil.load_sections to see what it was
> getting
> from the config, and other variables. Looks like the problem is that the
> section name (entry point name) is "followers" so that needs to be used.
>
>
> On 9/16/18 2:37 PM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > To move up the activity section in dashboard and profile I've modified
> the
> > development.ini file. For the user profile, the section order was there
> but
> > commented, so that I've uncommented the line. For the dashboard section
> > order, I've added a similar line, but it doesn't work. (activity section
> is
> > not moving up) Do you have any idea about this?
> > I have committed my changes to the repo. (
> >
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/1955539543430eb71e56a995307135d258247b74/
> > )
> >
> > Regards!
> >
> > On Thu, Aug 30, 2018 at 1:27 AM Dave Brondsema <da...@brondsema.net>
> wrote:
> >
> >> Hi!
> >>
> >> I've merged that merge request, it looks good. I think the title text
> is
> >> ok.
> >> The layout of the logo runs into the main gray content though. It'd be
> >> nice if
> >> it had a bit of space like it does on the user profile page, for
> example.
> >> I see
> >> on the user profile page there is an empty <h2 class="project_summary">
> >> that
> >> helps push it down.
> >>
> >> Another thing that could be polished is the placement of the Activity
> box
> >> in the
> >> right column. On both the dashboard and the profile pages it is part
> way
> >> down
> >> the column, and I think it'd be better at the top of the column. That
> >> might be
> >> fixable by CSS rules, but also by the ordering of the widgets. If it is
> >> the
> >> first widget then when it floats to the right its ok at the top of the
> >> column.
> >> So either by code, or .ini config file you could make it first in the
> >> profile_sections.order and personal_dashboard_sections.order
> >>
> >> On 8/29/18 6:44 AM, Deshani Geethika wrote:
> >>> Hi Dave,
> >>>
> >>> Sorry for the delays. I've done some fixes on dashboard styles and
> added
> >> a
> >>> merge request (
> >>> https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
> >>> Please review it and let me know if any improvements required.
> >>>
> >>> Also, for the dashboard title, currently it is shown as *username /
> >>> Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you
> >> have
> >>> a better idea for the dashboard title?
> >>>
> >>> Regards!
> >>>
> >>> On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <
> >> deshanigeethika@gmail.com>
> >>> wrote:
> >>>
> >>>> Thanks a lot. Will try these and let you know
> >>>>
> >>>> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net>
> >> wrote:
> >>>>
> >>>>> Sure, here's some thoughts:
> >>>>>
> >>>>> Inheriting from TestGitRepo means it gets all the test_* functions,
> so
> >>>>> when I
> >>>>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
> >>>>> don't want
> >>>>> to happen. So I'd remove that inheritance. You probably will have
> to
> >>>>> duplicate
> >>>>> the setup_with_tools() function in this file then.
> >>>>>
> >>>>> Actually, inheriting from _TestCase in
> >>>>> forgegit/tests/functional/test_controllers.py might be a good option.
> >> It
> >>>>> has
> >>>>> some setup functions you can use (so you don't have to duplicate
> >>>>> setup_with_tools) and it doesn't have any test_* functions.
> >>>>>
> >>>>> The super() call is supposed to use its own name, like
> >>>>> super(TestMergeRequestsSection, self).setUp() Not sure if that
> makes a
> >>>>> difference here or not.
> >>>>>
> >>>>> merge_request() is a function but you don't have parenthesis on `mr=
> >>>>> self.merge_request` so that function isn't running.
> >>>>>
> >>>>> I realized what happened earlier when I didn't see the "Tickets"
> >> section
> >>>>> in the
> >>>>> HTML output of the tickets test! When I was trying this test now, I
> >> got a
> >>>>> similar situation where the "Merge Requests" section isn't in the
> HTML
> >>>>> output at
> >>>>> all either. So I looked in the 'test.log' file (where logging goes
> to
> >>>>> during
> >>>>> tests) and saw "Error rendering section MergeRequestsSection: ..."
> with
> >>>>> error
> >>>>> details. So these sections trap errors and log them, instead of
> >> letting
> >>>>> the
> >>>>> whole page error. So looking at the test.log output can help see
> those
> >>>>> errors
> >>>>> when they happen.
> >>>>>
> >>>>> You may need to run ThreadLocalODMSession.flush_all() after creating
> >> the
> >>>>> merge
> >>>>> request object. That is a common test pattern we have when tests
> >> create
> >>>>> something and then need to view it. (Mainly needed in tests, since
> >>>>> regular web
> >>>>> pages will flush at the end of each request).
> >>>>>
> >>>>> Hope that helps, let me know how far you get, and I can look at it
> some
> >>>>> more if
> >>>>> needed :)
> >>>>>
> >>>>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
> >>>>>> Hi Dave,
> >>>>>>
> >>>>>> I have started to write a test case for Merge Requests Section. For
> >>>>> that I
> >>>>>> have followed ForgeGit tests but it doesn't work for me. I was
> trying
> >> to
> >>>>>> create a merge request and see whether it appears in dashboard.
> >>>>>>
> >>>>>> I've pushed the code into my fork
> >>>>>> <
> >>>>>
> >>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
> >>>>>> .
> >>>>>> Can you kindly take a look at that? Also, please let me know any
> >>>>> debugging
> >>>>>> process can be done for methods called internally when creating a
> >> merge
> >>>>>> request.
> >>>>>>
> >>>>>> Regards!
> >>>>>>
> >>>>>> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
> >>>>> deshanigeethika@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Hi Dave,
> >>>>>>>
> >>>>>>> Thank you for sharing these valuable information. I have added a
> >> merge
> >>>>>>> request <
> >>>>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
> >>>>>>> Please review it and let me know any further improvements.
> >>>>>>>
> >>>>>>> Regards!
> >>>>>>>
> >>>>>>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <dave@brondsema.net
> >
> >>>>> wrote:
> >>>>>>>
> >>>>>>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
> >>>>>>>>> Hi Dave,
> >>>>>>>>>
> >>>>>>>>> I have tried with adding above lines, but still doesn't work. Can
> >> you
> >>>>>>>> take
> >>>>>>>>> a look at my implementation
> >>>>>>>>> <
> >>>>>>>>
> >>>>>
> >>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
> >>>>>>>>>
> >>>>>>>>> ?
> >>>>>>>>>
> >>>>>>>>> Thanks!
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>> Here's some debugging process I did, you can try it too:
> >>>>>>>>
> >>>>>>>> Tests use the MockSOLR class instead of a real solr instance (so
> >> that
> >>>>> you
> >>>>>>>> don't
> >>>>>>>> need solr to run tests). I knew that, so I started by going to
> >>>>>>>> MockSOLR.search() and putting in some print statements to debug
> it.
> >>>>> At
> >>>>>>>> the
> >>>>>>>> beginning of search() I added:
> >>>>>>>>
> >>>>>>>> print q
> >>>>>>>> print fq
> >>>>>>>>
> >>>>>>>> And inside the "for obj in self.db.values():" loop, I added "print
> >>>>> obj"
> >>>>>>>>
> >>>>>>>> My idea was to see what query is happening and what the stored
> >> objects
> >>>>>>>> are, and
> >>>>>>>> see what's not working. I ran just the single test with
> `nosetests
> >>>>>>>>
> >>>>>>>>
> >>>>>
> >>
> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
> >>>>>>>> I noticed there was a 'project_id_s' in the search query, and
> there
> >>>>>>>> shouldn't
> >>>>>>>> be. But after a bit of trial & error to see what was happening, I
> >>>>>>>> realized that
> >>>>>>>> was coming from a "update_bin_count" background task, and that
> >> wasn't
> >>>>>>>> related to
> >>>>>>>> the test really.
> >>>>>>>>
> >>>>>>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all
> the
> >>>>>>>> background
> >>>>>>>> tasks for now and did it again, and there wasn't any of my print
> >>>>>>>> statements
> >>>>>>>> occurring. So the dashboard ticket search wasn't even happening
> it
> >>>>> seems.
> >>>>>>>>
> >>>>>>>> Then I printed the "response.html" variable to look at the whole
> >>>>>>>> dashboard page
> >>>>>>>> and I didn't see the Tickets section in it at all. So indeed,
> that
> >>>>>>>> section
> >>>>>>>> isn't included in this test at all for some reason.
> >>>>>>>>
> >>>>>>>> Hopefully those are some helpful examples for this particular
> >>>>> situation
> >>>>>>>> and also
> >>>>>>>> ideas for how to debug high level (like "is it even running?") and
> >> low
> >>>>>>>> level (to
> >>>>>>>> see where things might be not working).
> >>>>>>>>
> >>>>>>>> Next step of course is to figure out why in this test the
> dashboard
> >>>>>>>> section
> >>>>>>>> isn't even running. I'll let you work on that. My general
> strategy
> >>>>> is
> >>>>>>>> to put
> >>>>>>>> debugging in various places to confirm if things are running with
> >> the
> >>>>>>>> right
> >>>>>>>> values, or where they aren't, and narrow down to the spot where it
> >>>>> goes
> >>>>>>>> wrong.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Dave Brondsema : dave@brondsema.net
> >>>>>>>> http://www.brondsema.net : personal
> >>>>>>>> http://www.splike.com : programming
> >>>>>>>> <><
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> *Deshani Geethika*
> >>>>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Dave Brondsema : dave@brondsema.net
> >>>>> http://www.brondsema.net : personal
> >>>>> http://www.splike.com : programming
> >>>>> <><
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> *Deshani Geethika*
> >>>> Undergraduate at Department of Computer Science and Engineering
> >>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>
> >>>>
> >>>
> >>
> >>
> >>
> >> --
> >> Dave Brondsema : dave@brondsema.net
> >> http://www.brondsema.net : personal
> >> http://www.splike.com : programming
> >> <><
> >>
> >
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
I added some logging to SectionsUtil.load_sections to see what it was getting
from the config, and other variables. Looks like the problem is that the
section name (entry point name) is "followers" so that needs to be used.
On 9/16/18 2:37 PM, Deshani Geethika wrote:
> Hi Dave,
>
> To move up the activity section in dashboard and profile I've modified the
> development.ini file. For the user profile, the section order was there but
> commented, so that I've uncommented the line. For the dashboard section
> order, I've added a similar line, but it doesn't work. (activity section is
> not moving up) Do you have any idea about this?
> I have committed my changes to the repo. (
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/1955539543430eb71e56a995307135d258247b74/
> )
>
> Regards!
>
> On Thu, Aug 30, 2018 at 1:27 AM Dave Brondsema <da...@brondsema.net> wrote:
>
>> Hi!
>>
>> I've merged that merge request, it looks good. I think the title text is
>> ok.
>> The layout of the logo runs into the main gray content though. It'd be
>> nice if
>> it had a bit of space like it does on the user profile page, for example.
>> I see
>> on the user profile page there is an empty <h2 class="project_summary">
>> that
>> helps push it down.
>>
>> Another thing that could be polished is the placement of the Activity box
>> in the
>> right column. On both the dashboard and the profile pages it is part way
>> down
>> the column, and I think it'd be better at the top of the column. That
>> might be
>> fixable by CSS rules, but also by the ordering of the widgets. If it is
>> the
>> first widget then when it floats to the right its ok at the top of the
>> column.
>> So either by code, or .ini config file you could make it first in the
>> profile_sections.order and personal_dashboard_sections.order
>>
>> On 8/29/18 6:44 AM, Deshani Geethika wrote:
>>> Hi Dave,
>>>
>>> Sorry for the delays. I've done some fixes on dashboard styles and added
>> a
>>> merge request (
>>> https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
>>> Please review it and let me know if any improvements required.
>>>
>>> Also, for the dashboard title, currently it is shown as *username /
>>> Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you
>> have
>>> a better idea for the dashboard title?
>>>
>>> Regards!
>>>
>>> On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <
>> deshanigeethika@gmail.com>
>>> wrote:
>>>
>>>> Thanks a lot. Will try these and let you know
>>>>
>>>> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net>
>> wrote:
>>>>
>>>>> Sure, here's some thoughts:
>>>>>
>>>>> Inheriting from TestGitRepo means it gets all the test_* functions, so
>>>>> when I
>>>>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
>>>>> don't want
>>>>> to happen. So I'd remove that inheritance. You probably will have to
>>>>> duplicate
>>>>> the setup_with_tools() function in this file then.
>>>>>
>>>>> Actually, inheriting from _TestCase in
>>>>> forgegit/tests/functional/test_controllers.py might be a good option.
>> It
>>>>> has
>>>>> some setup functions you can use (so you don't have to duplicate
>>>>> setup_with_tools) and it doesn't have any test_* functions.
>>>>>
>>>>> The super() call is supposed to use its own name, like
>>>>> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
>>>>> difference here or not.
>>>>>
>>>>> merge_request() is a function but you don't have parenthesis on `mr=
>>>>> self.merge_request` so that function isn't running.
>>>>>
>>>>> I realized what happened earlier when I didn't see the "Tickets"
>> section
>>>>> in the
>>>>> HTML output of the tickets test! When I was trying this test now, I
>> got a
>>>>> similar situation where the "Merge Requests" section isn't in the HTML
>>>>> output at
>>>>> all either. So I looked in the 'test.log' file (where logging goes to
>>>>> during
>>>>> tests) and saw "Error rendering section MergeRequestsSection: ..." with
>>>>> error
>>>>> details. So these sections trap errors and log them, instead of
>> letting
>>>>> the
>>>>> whole page error. So looking at the test.log output can help see those
>>>>> errors
>>>>> when they happen.
>>>>>
>>>>> You may need to run ThreadLocalODMSession.flush_all() after creating
>> the
>>>>> merge
>>>>> request object. That is a common test pattern we have when tests
>> create
>>>>> something and then need to view it. (Mainly needed in tests, since
>>>>> regular web
>>>>> pages will flush at the end of each request).
>>>>>
>>>>> Hope that helps, let me know how far you get, and I can look at it some
>>>>> more if
>>>>> needed :)
>>>>>
>>>>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
>>>>>> Hi Dave,
>>>>>>
>>>>>> I have started to write a test case for Merge Requests Section. For
>>>>> that I
>>>>>> have followed ForgeGit tests but it doesn't work for me. I was trying
>> to
>>>>>> create a merge request and see whether it appears in dashboard.
>>>>>>
>>>>>> I've pushed the code into my fork
>>>>>> <
>>>>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
>>>>>> .
>>>>>> Can you kindly take a look at that? Also, please let me know any
>>>>> debugging
>>>>>> process can be done for methods called internally when creating a
>> merge
>>>>>> request.
>>>>>>
>>>>>> Regards!
>>>>>>
>>>>>> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
>>>>> deshanigeethika@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Thank you for sharing these valuable information. I have added a
>> merge
>>>>>>> request <
>>>>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
>>>>>>> Please review it and let me know any further improvements.
>>>>>>>
>>>>>>> Regards!
>>>>>>>
>>>>>>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net>
>>>>> wrote:
>>>>>>>
>>>>>>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have tried with adding above lines, but still doesn't work. Can
>> you
>>>>>>>> take
>>>>>>>>> a look at my implementation
>>>>>>>>> <
>>>>>>>>
>>>>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>>>>>>>>>
>>>>>>>>> ?
>>>>>>>>>
>>>>>>>>> Thanks!
>>>>>>>>>
>>>>>>>>
>>>>>>>> Here's some debugging process I did, you can try it too:
>>>>>>>>
>>>>>>>> Tests use the MockSOLR class instead of a real solr instance (so
>> that
>>>>> you
>>>>>>>> don't
>>>>>>>> need solr to run tests). I knew that, so I started by going to
>>>>>>>> MockSOLR.search() and putting in some print statements to debug it.
>>>>> At
>>>>>>>> the
>>>>>>>> beginning of search() I added:
>>>>>>>>
>>>>>>>> print q
>>>>>>>> print fq
>>>>>>>>
>>>>>>>> And inside the "for obj in self.db.values():" loop, I added "print
>>>>> obj"
>>>>>>>>
>>>>>>>> My idea was to see what query is happening and what the stored
>> objects
>>>>>>>> are, and
>>>>>>>> see what's not working. I ran just the single test with `nosetests
>>>>>>>>
>>>>>>>>
>>>>>
>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>>>>>>>> I noticed there was a 'project_id_s' in the search query, and there
>>>>>>>> shouldn't
>>>>>>>> be. But after a bit of trial & error to see what was happening, I
>>>>>>>> realized that
>>>>>>>> was coming from a "update_bin_count" background task, and that
>> wasn't
>>>>>>>> related to
>>>>>>>> the test really.
>>>>>>>>
>>>>>>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
>>>>>>>> background
>>>>>>>> tasks for now and did it again, and there wasn't any of my print
>>>>>>>> statements
>>>>>>>> occurring. So the dashboard ticket search wasn't even happening it
>>>>> seems.
>>>>>>>>
>>>>>>>> Then I printed the "response.html" variable to look at the whole
>>>>>>>> dashboard page
>>>>>>>> and I didn't see the Tickets section in it at all. So indeed, that
>>>>>>>> section
>>>>>>>> isn't included in this test at all for some reason.
>>>>>>>>
>>>>>>>> Hopefully those are some helpful examples for this particular
>>>>> situation
>>>>>>>> and also
>>>>>>>> ideas for how to debug high level (like "is it even running?") and
>> low
>>>>>>>> level (to
>>>>>>>> see where things might be not working).
>>>>>>>>
>>>>>>>> Next step of course is to figure out why in this test the dashboard
>>>>>>>> section
>>>>>>>> isn't even running. I'll let you work on that. My general strategy
>>>>> is
>>>>>>>> to put
>>>>>>>> debugging in various places to confirm if things are running with
>> the
>>>>>>>> right
>>>>>>>> values, or where they aren't, and narrow down to the spot where it
>>>>> goes
>>>>>>>> wrong.
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Brondsema : dave@brondsema.net
>>>>>>>> http://www.brondsema.net : personal
>>>>>>>> http://www.splike.com : programming
>>>>>>>> <><
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Deshani Geethika*
>>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Brondsema : dave@brondsema.net
>>>>> http://www.brondsema.net : personal
>>>>> http://www.splike.com : programming
>>>>> <><
>>>>>
>>>>
>>>>
>>>> --
>>>> *Deshani Geethika*
>>>> Undergraduate at Department of Computer Science and Engineering
>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Dave Brondsema : dave@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
To move up the activity section in dashboard and profile I've modified the
development.ini file. For the user profile, the section order was there but
commented, so that I've uncommented the line. For the dashboard section
order, I've added a similar line, but it doesn't work. (activity section is
not moving up) Do you have any idea about this?
I have committed my changes to the repo. (
https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/1955539543430eb71e56a995307135d258247b74/
)
Regards!
On Thu, Aug 30, 2018 at 1:27 AM Dave Brondsema <da...@brondsema.net> wrote:
> Hi!
>
> I've merged that merge request, it looks good. I think the title text is
> ok.
> The layout of the logo runs into the main gray content though. It'd be
> nice if
> it had a bit of space like it does on the user profile page, for example.
> I see
> on the user profile page there is an empty <h2 class="project_summary">
> that
> helps push it down.
>
> Another thing that could be polished is the placement of the Activity box
> in the
> right column. On both the dashboard and the profile pages it is part way
> down
> the column, and I think it'd be better at the top of the column. That
> might be
> fixable by CSS rules, but also by the ordering of the widgets. If it is
> the
> first widget then when it floats to the right its ok at the top of the
> column.
> So either by code, or .ini config file you could make it first in the
> profile_sections.order and personal_dashboard_sections.order
>
> On 8/29/18 6:44 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > Sorry for the delays. I've done some fixes on dashboard styles and added
> a
> > merge request (
> > https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
> > Please review it and let me know if any improvements required.
> >
> > Also, for the dashboard title, currently it is shown as *username /
> > Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you
> have
> > a better idea for the dashboard title?
> >
> > Regards!
> >
> > On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <
> deshanigeethika@gmail.com>
> > wrote:
> >
> >> Thanks a lot. Will try these and let you know
> >>
> >> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net>
> wrote:
> >>
> >>> Sure, here's some thoughts:
> >>>
> >>> Inheriting from TestGitRepo means it gets all the test_* functions, so
> >>> when I
> >>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
> >>> don't want
> >>> to happen. So I'd remove that inheritance. You probably will have to
> >>> duplicate
> >>> the setup_with_tools() function in this file then.
> >>>
> >>> Actually, inheriting from _TestCase in
> >>> forgegit/tests/functional/test_controllers.py might be a good option.
> It
> >>> has
> >>> some setup functions you can use (so you don't have to duplicate
> >>> setup_with_tools) and it doesn't have any test_* functions.
> >>>
> >>> The super() call is supposed to use its own name, like
> >>> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
> >>> difference here or not.
> >>>
> >>> merge_request() is a function but you don't have parenthesis on `mr=
> >>> self.merge_request` so that function isn't running.
> >>>
> >>> I realized what happened earlier when I didn't see the "Tickets"
> section
> >>> in the
> >>> HTML output of the tickets test! When I was trying this test now, I
> got a
> >>> similar situation where the "Merge Requests" section isn't in the HTML
> >>> output at
> >>> all either. So I looked in the 'test.log' file (where logging goes to
> >>> during
> >>> tests) and saw "Error rendering section MergeRequestsSection: ..." with
> >>> error
> >>> details. So these sections trap errors and log them, instead of
> letting
> >>> the
> >>> whole page error. So looking at the test.log output can help see those
> >>> errors
> >>> when they happen.
> >>>
> >>> You may need to run ThreadLocalODMSession.flush_all() after creating
> the
> >>> merge
> >>> request object. That is a common test pattern we have when tests
> create
> >>> something and then need to view it. (Mainly needed in tests, since
> >>> regular web
> >>> pages will flush at the end of each request).
> >>>
> >>> Hope that helps, let me know how far you get, and I can look at it some
> >>> more if
> >>> needed :)
> >>>
> >>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
> >>>> Hi Dave,
> >>>>
> >>>> I have started to write a test case for Merge Requests Section. For
> >>> that I
> >>>> have followed ForgeGit tests but it doesn't work for me. I was trying
> to
> >>>> create a merge request and see whether it appears in dashboard.
> >>>>
> >>>> I've pushed the code into my fork
> >>>> <
> >>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
> >>>> .
> >>>> Can you kindly take a look at that? Also, please let me know any
> >>> debugging
> >>>> process can be done for methods called internally when creating a
> merge
> >>>> request.
> >>>>
> >>>> Regards!
> >>>>
> >>>> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
> >>> deshanigeethika@gmail.com>
> >>>> wrote:
> >>>>
> >>>>> Hi Dave,
> >>>>>
> >>>>> Thank you for sharing these valuable information. I have added a
> merge
> >>>>> request <
> >>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
> >>>>> Please review it and let me know any further improvements.
> >>>>>
> >>>>> Regards!
> >>>>>
> >>>>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net>
> >>> wrote:
> >>>>>
> >>>>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
> >>>>>>> Hi Dave,
> >>>>>>>
> >>>>>>> I have tried with adding above lines, but still doesn't work. Can
> you
> >>>>>> take
> >>>>>>> a look at my implementation
> >>>>>>> <
> >>>>>>
> >>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
> >>>>>>>
> >>>>>>> ?
> >>>>>>>
> >>>>>>> Thanks!
> >>>>>>>
> >>>>>>
> >>>>>> Here's some debugging process I did, you can try it too:
> >>>>>>
> >>>>>> Tests use the MockSOLR class instead of a real solr instance (so
> that
> >>> you
> >>>>>> don't
> >>>>>> need solr to run tests). I knew that, so I started by going to
> >>>>>> MockSOLR.search() and putting in some print statements to debug it.
> >>> At
> >>>>>> the
> >>>>>> beginning of search() I added:
> >>>>>>
> >>>>>> print q
> >>>>>> print fq
> >>>>>>
> >>>>>> And inside the "for obj in self.db.values():" loop, I added "print
> >>> obj"
> >>>>>>
> >>>>>> My idea was to see what query is happening and what the stored
> objects
> >>>>>> are, and
> >>>>>> see what's not working. I ran just the single test with `nosetests
> >>>>>>
> >>>>>>
> >>>
> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
> >>>>>> I noticed there was a 'project_id_s' in the search query, and there
> >>>>>> shouldn't
> >>>>>> be. But after a bit of trial & error to see what was happening, I
> >>>>>> realized that
> >>>>>> was coming from a "update_bin_count" background task, and that
> wasn't
> >>>>>> related to
> >>>>>> the test really.
> >>>>>>
> >>>>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
> >>>>>> background
> >>>>>> tasks for now and did it again, and there wasn't any of my print
> >>>>>> statements
> >>>>>> occurring. So the dashboard ticket search wasn't even happening it
> >>> seems.
> >>>>>>
> >>>>>> Then I printed the "response.html" variable to look at the whole
> >>>>>> dashboard page
> >>>>>> and I didn't see the Tickets section in it at all. So indeed, that
> >>>>>> section
> >>>>>> isn't included in this test at all for some reason.
> >>>>>>
> >>>>>> Hopefully those are some helpful examples for this particular
> >>> situation
> >>>>>> and also
> >>>>>> ideas for how to debug high level (like "is it even running?") and
> low
> >>>>>> level (to
> >>>>>> see where things might be not working).
> >>>>>>
> >>>>>> Next step of course is to figure out why in this test the dashboard
> >>>>>> section
> >>>>>> isn't even running. I'll let you work on that. My general strategy
> >>> is
> >>>>>> to put
> >>>>>> debugging in various places to confirm if things are running with
> the
> >>>>>> right
> >>>>>> values, or where they aren't, and narrow down to the spot where it
> >>> goes
> >>>>>> wrong.
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Dave Brondsema : dave@brondsema.net
> >>>>>> http://www.brondsema.net : personal
> >>>>>> http://www.splike.com : programming
> >>>>>> <><
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> *Deshani Geethika*
> >>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Dave Brondsema : dave@brondsema.net
> >>> http://www.brondsema.net : personal
> >>> http://www.splike.com : programming
> >>> <><
> >>>
> >>
> >>
> >> --
> >> *Deshani Geethika*
> >> Undergraduate at Department of Computer Science and Engineering
> >> Faculty of Engineering - University of Moratuwa Sri Lanka
> >> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>
> >>
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
Hi!
I've merged that merge request, it looks good. I think the title text is ok.
The layout of the logo runs into the main gray content though. It'd be nice if
it had a bit of space like it does on the user profile page, for example. I see
on the user profile page there is an empty <h2 class="project_summary"> that
helps push it down.
Another thing that could be polished is the placement of the Activity box in the
right column. On both the dashboard and the profile pages it is part way down
the column, and I think it'd be better at the top of the column. That might be
fixable by CSS rules, but also by the ordering of the widgets. If it is the
first widget then when it floats to the right its ok at the top of the column.
So either by code, or .ini config file you could make it first in the
profile_sections.order and personal_dashboard_sections.order
On 8/29/18 6:44 AM, Deshani Geethika wrote:
> Hi Dave,
>
> Sorry for the delays. I've done some fixes on dashboard styles and added a
> merge request (
> https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
> Please review it and let me know if any improvements required.
>
> Also, for the dashboard title, currently it is shown as *username /
> Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you have
> a better idea for the dashboard title?
>
> Regards!
>
> On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <de...@gmail.com>
> wrote:
>
>> Thanks a lot. Will try these and let you know
>>
>> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net> wrote:
>>
>>> Sure, here's some thoughts:
>>>
>>> Inheriting from TestGitRepo means it gets all the test_* functions, so
>>> when I
>>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
>>> don't want
>>> to happen. So I'd remove that inheritance. You probably will have to
>>> duplicate
>>> the setup_with_tools() function in this file then.
>>>
>>> Actually, inheriting from _TestCase in
>>> forgegit/tests/functional/test_controllers.py might be a good option. It
>>> has
>>> some setup functions you can use (so you don't have to duplicate
>>> setup_with_tools) and it doesn't have any test_* functions.
>>>
>>> The super() call is supposed to use its own name, like
>>> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
>>> difference here or not.
>>>
>>> merge_request() is a function but you don't have parenthesis on `mr=
>>> self.merge_request` so that function isn't running.
>>>
>>> I realized what happened earlier when I didn't see the "Tickets" section
>>> in the
>>> HTML output of the tickets test! When I was trying this test now, I got a
>>> similar situation where the "Merge Requests" section isn't in the HTML
>>> output at
>>> all either. So I looked in the 'test.log' file (where logging goes to
>>> during
>>> tests) and saw "Error rendering section MergeRequestsSection: ..." with
>>> error
>>> details. So these sections trap errors and log them, instead of letting
>>> the
>>> whole page error. So looking at the test.log output can help see those
>>> errors
>>> when they happen.
>>>
>>> You may need to run ThreadLocalODMSession.flush_all() after creating the
>>> merge
>>> request object. That is a common test pattern we have when tests create
>>> something and then need to view it. (Mainly needed in tests, since
>>> regular web
>>> pages will flush at the end of each request).
>>>
>>> Hope that helps, let me know how far you get, and I can look at it some
>>> more if
>>> needed :)
>>>
>>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
>>>> Hi Dave,
>>>>
>>>> I have started to write a test case for Merge Requests Section. For
>>> that I
>>>> have followed ForgeGit tests but it doesn't work for me. I was trying to
>>>> create a merge request and see whether it appears in dashboard.
>>>>
>>>> I've pushed the code into my fork
>>>> <
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
>>>> .
>>>> Can you kindly take a look at that? Also, please let me know any
>>> debugging
>>>> process can be done for methods called internally when creating a merge
>>>> request.
>>>>
>>>> Regards!
>>>>
>>>> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
>>> deshanigeethika@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Thank you for sharing these valuable information. I have added a merge
>>>>> request <
>>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
>>>>> Please review it and let me know any further improvements.
>>>>>
>>>>> Regards!
>>>>>
>>>>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net>
>>> wrote:
>>>>>
>>>>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I have tried with adding above lines, but still doesn't work. Can you
>>>>>> take
>>>>>>> a look at my implementation
>>>>>>> <
>>>>>>
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>>>>>>>
>>>>>>> ?
>>>>>>>
>>>>>>> Thanks!
>>>>>>>
>>>>>>
>>>>>> Here's some debugging process I did, you can try it too:
>>>>>>
>>>>>> Tests use the MockSOLR class instead of a real solr instance (so that
>>> you
>>>>>> don't
>>>>>> need solr to run tests). I knew that, so I started by going to
>>>>>> MockSOLR.search() and putting in some print statements to debug it.
>>> At
>>>>>> the
>>>>>> beginning of search() I added:
>>>>>>
>>>>>> print q
>>>>>> print fq
>>>>>>
>>>>>> And inside the "for obj in self.db.values():" loop, I added "print
>>> obj"
>>>>>>
>>>>>> My idea was to see what query is happening and what the stored objects
>>>>>> are, and
>>>>>> see what's not working. I ran just the single test with `nosetests
>>>>>>
>>>>>>
>>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>>>>>> I noticed there was a 'project_id_s' in the search query, and there
>>>>>> shouldn't
>>>>>> be. But after a bit of trial & error to see what was happening, I
>>>>>> realized that
>>>>>> was coming from a "update_bin_count" background task, and that wasn't
>>>>>> related to
>>>>>> the test really.
>>>>>>
>>>>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
>>>>>> background
>>>>>> tasks for now and did it again, and there wasn't any of my print
>>>>>> statements
>>>>>> occurring. So the dashboard ticket search wasn't even happening it
>>> seems.
>>>>>>
>>>>>> Then I printed the "response.html" variable to look at the whole
>>>>>> dashboard page
>>>>>> and I didn't see the Tickets section in it at all. So indeed, that
>>>>>> section
>>>>>> isn't included in this test at all for some reason.
>>>>>>
>>>>>> Hopefully those are some helpful examples for this particular
>>> situation
>>>>>> and also
>>>>>> ideas for how to debug high level (like "is it even running?") and low
>>>>>> level (to
>>>>>> see where things might be not working).
>>>>>>
>>>>>> Next step of course is to figure out why in this test the dashboard
>>>>>> section
>>>>>> isn't even running. I'll let you work on that. My general strategy
>>> is
>>>>>> to put
>>>>>> debugging in various places to confirm if things are running with the
>>>>>> right
>>>>>> values, or where they aren't, and narrow down to the spot where it
>>> goes
>>>>>> wrong.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Brondsema : dave@brondsema.net
>>>>>> http://www.brondsema.net : personal
>>>>>> http://www.splike.com : programming
>>>>>> <><
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Deshani Geethika*
>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Brondsema : dave@brondsema.net
>>> http://www.brondsema.net : personal
>>> http://www.splike.com : programming
>>> <><
>>>
>>
>>
>> --
>> *Deshani Geethika*
>> Undergraduate at Department of Computer Science and Engineering
>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>
>>
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
Sorry for the delays. I've done some fixes on dashboard styles and added a
merge request (
https://forge-allura.apache.org/p/allura/git/merge-requests/271/)
Please review it and let me know if any improvements required.
Also, for the dashboard title, currently it is shown as *username /
Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you have
a better idea for the dashboard title?
Regards!
On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika <de...@gmail.com>
wrote:
> Thanks a lot. Will try these and let you know
>
> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net> wrote:
>
>> Sure, here's some thoughts:
>>
>> Inheriting from TestGitRepo means it gets all the test_* functions, so
>> when I
>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
>> don't want
>> to happen. So I'd remove that inheritance. You probably will have to
>> duplicate
>> the setup_with_tools() function in this file then.
>>
>> Actually, inheriting from _TestCase in
>> forgegit/tests/functional/test_controllers.py might be a good option. It
>> has
>> some setup functions you can use (so you don't have to duplicate
>> setup_with_tools) and it doesn't have any test_* functions.
>>
>> The super() call is supposed to use its own name, like
>> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
>> difference here or not.
>>
>> merge_request() is a function but you don't have parenthesis on `mr=
>> self.merge_request` so that function isn't running.
>>
>> I realized what happened earlier when I didn't see the "Tickets" section
>> in the
>> HTML output of the tickets test! When I was trying this test now, I got a
>> similar situation where the "Merge Requests" section isn't in the HTML
>> output at
>> all either. So I looked in the 'test.log' file (where logging goes to
>> during
>> tests) and saw "Error rendering section MergeRequestsSection: ..." with
>> error
>> details. So these sections trap errors and log them, instead of letting
>> the
>> whole page error. So looking at the test.log output can help see those
>> errors
>> when they happen.
>>
>> You may need to run ThreadLocalODMSession.flush_all() after creating the
>> merge
>> request object. That is a common test pattern we have when tests create
>> something and then need to view it. (Mainly needed in tests, since
>> regular web
>> pages will flush at the end of each request).
>>
>> Hope that helps, let me know how far you get, and I can look at it some
>> more if
>> needed :)
>>
>> On 7/27/18 9:11 AM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > I have started to write a test case for Merge Requests Section. For
>> that I
>> > have followed ForgeGit tests but it doesn't work for me. I was trying to
>> > create a merge request and see whether it appears in dashboard.
>> >
>> > I've pushed the code into my fork
>> > <
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
>> >.
>> > Can you kindly take a look at that? Also, please let me know any
>> debugging
>> > process can be done for methods called internally when creating a merge
>> > request.
>> >
>> > Regards!
>> >
>> > On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
>> deshanigeethika@gmail.com>
>> > wrote:
>> >
>> >> Hi Dave,
>> >>
>> >> Thank you for sharing these valuable information. I have added a merge
>> >> request <
>> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
>> >> Please review it and let me know any further improvements.
>> >>
>> >> Regards!
>> >>
>> >> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net>
>> wrote:
>> >>
>> >>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>> >>>> Hi Dave,
>> >>>>
>> >>>> I have tried with adding above lines, but still doesn't work. Can you
>> >>> take
>> >>>> a look at my implementation
>> >>>> <
>> >>>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>> >>>>
>> >>>> ?
>> >>>>
>> >>>> Thanks!
>> >>>>
>> >>>
>> >>> Here's some debugging process I did, you can try it too:
>> >>>
>> >>> Tests use the MockSOLR class instead of a real solr instance (so that
>> you
>> >>> don't
>> >>> need solr to run tests). I knew that, so I started by going to
>> >>> MockSOLR.search() and putting in some print statements to debug it.
>> At
>> >>> the
>> >>> beginning of search() I added:
>> >>>
>> >>> print q
>> >>> print fq
>> >>>
>> >>> And inside the "for obj in self.db.values():" loop, I added "print
>> obj"
>> >>>
>> >>> My idea was to see what query is happening and what the stored objects
>> >>> are, and
>> >>> see what's not working. I ran just the single test with `nosetests
>> >>>
>> >>>
>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>> >>> I noticed there was a 'project_id_s' in the search query, and there
>> >>> shouldn't
>> >>> be. But after a bit of trial & error to see what was happening, I
>> >>> realized that
>> >>> was coming from a "update_bin_count" background task, and that wasn't
>> >>> related to
>> >>> the test really.
>> >>>
>> >>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
>> >>> background
>> >>> tasks for now and did it again, and there wasn't any of my print
>> >>> statements
>> >>> occurring. So the dashboard ticket search wasn't even happening it
>> seems.
>> >>>
>> >>> Then I printed the "response.html" variable to look at the whole
>> >>> dashboard page
>> >>> and I didn't see the Tickets section in it at all. So indeed, that
>> >>> section
>> >>> isn't included in this test at all for some reason.
>> >>>
>> >>> Hopefully those are some helpful examples for this particular
>> situation
>> >>> and also
>> >>> ideas for how to debug high level (like "is it even running?") and low
>> >>> level (to
>> >>> see where things might be not working).
>> >>>
>> >>> Next step of course is to figure out why in this test the dashboard
>> >>> section
>> >>> isn't even running. I'll let you work on that. My general strategy
>> is
>> >>> to put
>> >>> debugging in various places to confirm if things are running with the
>> >>> right
>> >>> values, or where they aren't, and narrow down to the spot where it
>> goes
>> >>> wrong.
>> >>>
>> >>>
>> >>> --
>> >>> Dave Brondsema : dave@brondsema.net
>> >>> http://www.brondsema.net : personal
>> >>> http://www.splike.com : programming
>> >>> <><
>> >>>
>> >>
>> >>
>> >> --
>> >> *Deshani Geethika*
>> >> Undergraduate at Department of Computer Science and Engineering
>> >> Faculty of Engineering - University of Moratuwa Sri Lanka
>> >> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> >> <https://github.com/deshanigtk> | Mobile - +94776383034
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Brondsema : dave@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Thanks a lot. Will try these and let you know
On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema <da...@brondsema.net> wrote:
> Sure, here's some thoughts:
>
> Inheriting from TestGitRepo means it gets all the test_* functions, so
> when I
> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we
> don't want
> to happen. So I'd remove that inheritance. You probably will have to
> duplicate
> the setup_with_tools() function in this file then.
>
> Actually, inheriting from _TestCase in
> forgegit/tests/functional/test_controllers.py might be a good option. It
> has
> some setup functions you can use (so you don't have to duplicate
> setup_with_tools) and it doesn't have any test_* functions.
>
> The super() call is supposed to use its own name, like
> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
> difference here or not.
>
> merge_request() is a function but you don't have parenthesis on `mr=
> self.merge_request` so that function isn't running.
>
> I realized what happened earlier when I didn't see the "Tickets" section
> in the
> HTML output of the tickets test! When I was trying this test now, I got a
> similar situation where the "Merge Requests" section isn't in the HTML
> output at
> all either. So I looked in the 'test.log' file (where logging goes to
> during
> tests) and saw "Error rendering section MergeRequestsSection: ..." with
> error
> details. So these sections trap errors and log them, instead of letting
> the
> whole page error. So looking at the test.log output can help see those
> errors
> when they happen.
>
> You may need to run ThreadLocalODMSession.flush_all() after creating the
> merge
> request object. That is a common test pattern we have when tests create
> something and then need to view it. (Mainly needed in tests, since
> regular web
> pages will flush at the end of each request).
>
> Hope that helps, let me know how far you get, and I can look at it some
> more if
> needed :)
>
> On 7/27/18 9:11 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > I have started to write a test case for Merge Requests Section. For that
> I
> > have followed ForgeGit tests but it doesn't work for me. I was trying to
> > create a merge request and see whether it appears in dashboard.
> >
> > I've pushed the code into my fork
> > <
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/
> >.
> > Can you kindly take a look at that? Also, please let me know any
> debugging
> > process can be done for methods called internally when creating a merge
> > request.
> >
> > Regards!
> >
> > On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <
> deshanigeethika@gmail.com>
> > wrote:
> >
> >> Hi Dave,
> >>
> >> Thank you for sharing these valuable information. I have added a merge
> >> request <
> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
> >> Please review it and let me know any further improvements.
> >>
> >> Regards!
> >>
> >> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net>
> wrote:
> >>
> >>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
> >>>> Hi Dave,
> >>>>
> >>>> I have tried with adding above lines, but still doesn't work. Can you
> >>> take
> >>>> a look at my implementation
> >>>> <
> >>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
> >>>>
> >>>> ?
> >>>>
> >>>> Thanks!
> >>>>
> >>>
> >>> Here's some debugging process I did, you can try it too:
> >>>
> >>> Tests use the MockSOLR class instead of a real solr instance (so that
> you
> >>> don't
> >>> need solr to run tests). I knew that, so I started by going to
> >>> MockSOLR.search() and putting in some print statements to debug it. At
> >>> the
> >>> beginning of search() I added:
> >>>
> >>> print q
> >>> print fq
> >>>
> >>> And inside the "for obj in self.db.values():" loop, I added "print obj"
> >>>
> >>> My idea was to see what query is happening and what the stored objects
> >>> are, and
> >>> see what's not working. I ran just the single test with `nosetests
> >>>
> >>>
> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
> >>> I noticed there was a 'project_id_s' in the search query, and there
> >>> shouldn't
> >>> be. But after a bit of trial & error to see what was happening, I
> >>> realized that
> >>> was coming from a "update_bin_count" background task, and that wasn't
> >>> related to
> >>> the test really.
> >>>
> >>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
> >>> background
> >>> tasks for now and did it again, and there wasn't any of my print
> >>> statements
> >>> occurring. So the dashboard ticket search wasn't even happening it
> seems.
> >>>
> >>> Then I printed the "response.html" variable to look at the whole
> >>> dashboard page
> >>> and I didn't see the Tickets section in it at all. So indeed, that
> >>> section
> >>> isn't included in this test at all for some reason.
> >>>
> >>> Hopefully those are some helpful examples for this particular situation
> >>> and also
> >>> ideas for how to debug high level (like "is it even running?") and low
> >>> level (to
> >>> see where things might be not working).
> >>>
> >>> Next step of course is to figure out why in this test the dashboard
> >>> section
> >>> isn't even running. I'll let you work on that. My general strategy is
> >>> to put
> >>> debugging in various places to confirm if things are running with the
> >>> right
> >>> values, or where they aren't, and narrow down to the spot where it goes
> >>> wrong.
> >>>
> >>>
> >>> --
> >>> Dave Brondsema : dave@brondsema.net
> >>> http://www.brondsema.net : personal
> >>> http://www.splike.com : programming
> >>> <><
> >>>
> >>
> >>
> >> --
> >> *Deshani Geethika*
> >> Undergraduate at Department of Computer Science and Engineering
> >> Faculty of Engineering - University of Moratuwa Sri Lanka
> >> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>
> >>
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
Sure, here's some thoughts:
Inheriting from TestGitRepo means it gets all the test_* functions, so when I
ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we don't want
to happen. So I'd remove that inheritance. You probably will have to duplicate
the setup_with_tools() function in this file then.
Actually, inheriting from _TestCase in
forgegit/tests/functional/test_controllers.py might be a good option. It has
some setup functions you can use (so you don't have to duplicate
setup_with_tools) and it doesn't have any test_* functions.
The super() call is supposed to use its own name, like
super(TestMergeRequestsSection, self).setUp() Not sure if that makes a
difference here or not.
merge_request() is a function but you don't have parenthesis on `mr=
self.merge_request` so that function isn't running.
I realized what happened earlier when I didn't see the "Tickets" section in the
HTML output of the tickets test! When I was trying this test now, I got a
similar situation where the "Merge Requests" section isn't in the HTML output at
all either. So I looked in the 'test.log' file (where logging goes to during
tests) and saw "Error rendering section MergeRequestsSection: ..." with error
details. So these sections trap errors and log them, instead of letting the
whole page error. So looking at the test.log output can help see those errors
when they happen.
You may need to run ThreadLocalODMSession.flush_all() after creating the merge
request object. That is a common test pattern we have when tests create
something and then need to view it. (Mainly needed in tests, since regular web
pages will flush at the end of each request).
Hope that helps, let me know how far you get, and I can look at it some more if
needed :)
On 7/27/18 9:11 AM, Deshani Geethika wrote:
> Hi Dave,
>
> I have started to write a test case for Merge Requests Section. For that I
> have followed ForgeGit tests but it doesn't work for me. I was trying to
> create a merge request and see whether it appears in dashboard.
>
> I've pushed the code into my fork
> <https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/>.
> Can you kindly take a look at that? Also, please let me know any debugging
> process can be done for methods called internally when creating a merge
> request.
>
> Regards!
>
> On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <de...@gmail.com>
> wrote:
>
>> Hi Dave,
>>
>> Thank you for sharing these valuable information. I have added a merge
>> request <https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
>> Please review it and let me know any further improvements.
>>
>> Regards!
>>
>> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net> wrote:
>>
>>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>>>> Hi Dave,
>>>>
>>>> I have tried with adding above lines, but still doesn't work. Can you
>>> take
>>>> a look at my implementation
>>>> <
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>>>>
>>>> ?
>>>>
>>>> Thanks!
>>>>
>>>
>>> Here's some debugging process I did, you can try it too:
>>>
>>> Tests use the MockSOLR class instead of a real solr instance (so that you
>>> don't
>>> need solr to run tests). I knew that, so I started by going to
>>> MockSOLR.search() and putting in some print statements to debug it. At
>>> the
>>> beginning of search() I added:
>>>
>>> print q
>>> print fq
>>>
>>> And inside the "for obj in self.db.values():" loop, I added "print obj"
>>>
>>> My idea was to see what query is happening and what the stored objects
>>> are, and
>>> see what's not working. I ran just the single test with `nosetests
>>>
>>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>>> I noticed there was a 'project_id_s' in the search query, and there
>>> shouldn't
>>> be. But after a bit of trial & error to see what was happening, I
>>> realized that
>>> was coming from a "update_bin_count" background task, and that wasn't
>>> related to
>>> the test really.
>>>
>>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
>>> background
>>> tasks for now and did it again, and there wasn't any of my print
>>> statements
>>> occurring. So the dashboard ticket search wasn't even happening it seems.
>>>
>>> Then I printed the "response.html" variable to look at the whole
>>> dashboard page
>>> and I didn't see the Tickets section in it at all. So indeed, that
>>> section
>>> isn't included in this test at all for some reason.
>>>
>>> Hopefully those are some helpful examples for this particular situation
>>> and also
>>> ideas for how to debug high level (like "is it even running?") and low
>>> level (to
>>> see where things might be not working).
>>>
>>> Next step of course is to figure out why in this test the dashboard
>>> section
>>> isn't even running. I'll let you work on that. My general strategy is
>>> to put
>>> debugging in various places to confirm if things are running with the
>>> right
>>> values, or where they aren't, and narrow down to the spot where it goes
>>> wrong.
>>>
>>>
>>> --
>>> Dave Brondsema : dave@brondsema.net
>>> http://www.brondsema.net : personal
>>> http://www.splike.com : programming
>>> <><
>>>
>>
>>
>> --
>> *Deshani Geethika*
>> Undergraduate at Department of Computer Science and Engineering
>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>
>>
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
I have started to write a test case for Merge Requests Section. For that I
have followed ForgeGit tests but it doesn't work for me. I was trying to
create a merge request and see whether it appears in dashboard.
I've pushed the code into my fork
<https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/>.
Can you kindly take a look at that? Also, please let me know any debugging
process can be done for methods called internally when creating a merge
request.
Regards!
On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika <de...@gmail.com>
wrote:
> Hi Dave,
>
> Thank you for sharing these valuable information. I have added a merge
> request <https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
> Please review it and let me know any further improvements.
>
> Regards!
>
> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net> wrote:
>
>> On 7/16/18 9:49 AM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > I have tried with adding above lines, but still doesn't work. Can you
>> take
>> > a look at my implementation
>> > <
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
>> >
>> > ?
>> >
>> > Thanks!
>> >
>>
>> Here's some debugging process I did, you can try it too:
>>
>> Tests use the MockSOLR class instead of a real solr instance (so that you
>> don't
>> need solr to run tests). I knew that, so I started by going to
>> MockSOLR.search() and putting in some print statements to debug it. At
>> the
>> beginning of search() I added:
>>
>> print q
>> print fq
>>
>> And inside the "for obj in self.db.values():" loop, I added "print obj"
>>
>> My idea was to see what query is happening and what the stored objects
>> are, and
>> see what's not working. I ran just the single test with `nosetests
>>
>> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
>> I noticed there was a 'project_id_s' in the search query, and there
>> shouldn't
>> be. But after a bit of trial & error to see what was happening, I
>> realized that
>> was coming from a "update_bin_count" background task, and that wasn't
>> related to
>> the test really.
>>
>> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
>> background
>> tasks for now and did it again, and there wasn't any of my print
>> statements
>> occurring. So the dashboard ticket search wasn't even happening it seems.
>>
>> Then I printed the "response.html" variable to look at the whole
>> dashboard page
>> and I didn't see the Tickets section in it at all. So indeed, that
>> section
>> isn't included in this test at all for some reason.
>>
>> Hopefully those are some helpful examples for this particular situation
>> and also
>> ideas for how to debug high level (like "is it even running?") and low
>> level (to
>> see where things might be not working).
>>
>> Next step of course is to figure out why in this test the dashboard
>> section
>> isn't even running. I'll let you work on that. My general strategy is
>> to put
>> debugging in various places to confirm if things are running with the
>> right
>> values, or where they aren't, and narrow down to the spot where it goes
>> wrong.
>>
>>
>> --
>> Dave Brondsema : dave@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
Thank you for sharing these valuable information. I have added a merge
request <https://forge-allura.apache.org/p/allura/git/merge-requests/269/>.
Please review it and let me know any further improvements.
Regards!
On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema <da...@brondsema.net> wrote:
> On 7/16/18 9:49 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > I have tried with adding above lines, but still doesn't work. Can you
> take
> > a look at my implementation
> > <
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/
> >
> > ?
> >
> > Thanks!
> >
>
> Here's some debugging process I did, you can try it too:
>
> Tests use the MockSOLR class instead of a real solr instance (so that you
> don't
> need solr to run tests). I knew that, so I started by going to
> MockSOLR.search() and putting in some print statements to debug it. At the
> beginning of search() I added:
>
> print q
> print fq
>
> And inside the "for obj in self.db.values():" loop, I added "print obj"
>
> My idea was to see what query is happening and what the stored objects
> are, and
> see what's not working. I ran just the single test with `nosetests
>
> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
> I noticed there was a 'project_id_s' in the search query, and there
> shouldn't
> be. But after a bit of trial & error to see what was happening, I
> realized that
> was coming from a "update_bin_count" background task, and that wasn't
> related to
> the test really.
>
> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the
> background
> tasks for now and did it again, and there wasn't any of my print statements
> occurring. So the dashboard ticket search wasn't even happening it seems.
>
> Then I printed the "response.html" variable to look at the whole dashboard
> page
> and I didn't see the Tickets section in it at all. So indeed, that section
> isn't included in this test at all for some reason.
>
> Hopefully those are some helpful examples for this particular situation
> and also
> ideas for how to debug high level (like "is it even running?") and low
> level (to
> see where things might be not working).
>
> Next step of course is to figure out why in this test the dashboard section
> isn't even running. I'll let you work on that. My general strategy is to
> put
> debugging in various places to confirm if things are running with the right
> values, or where they aren't, and narrow down to the spot where it goes
> wrong.
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
On 7/16/18 9:49 AM, Deshani Geethika wrote:
> Hi Dave,
>
> I have tried with adding above lines, but still doesn't work. Can you take
> a look at my implementation
> <https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/>
> ?
>
> Thanks!
>
Here's some debugging process I did, you can try it too:
Tests use the MockSOLR class instead of a real solr instance (so that you don't
need solr to run tests). I knew that, so I started by going to
MockSOLR.search() and putting in some print statements to debug it. At the
beginning of search() I added:
print q
print fq
And inside the "for obj in self.db.values():" loop, I added "print obj"
My idea was to see what query is happening and what the stored objects are, and
see what's not working. I ran just the single test with `nosetests
allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section`
I noticed there was a 'project_id_s' in the search query, and there shouldn't
be. But after a bit of trial & error to see what was happening, I realized that
was coming from a "update_bin_count" background task, and that wasn't related to
the test really.
So I commented-out the tasks M.MonQTask.run_ready() to avoid all the background
tasks for now and did it again, and there wasn't any of my print statements
occurring. So the dashboard ticket search wasn't even happening it seems.
Then I printed the "response.html" variable to look at the whole dashboard page
and I didn't see the Tickets section in it at all. So indeed, that section
isn't included in this test at all for some reason.
Hopefully those are some helpful examples for this particular situation and also
ideas for how to debug high level (like "is it even running?") and low level (to
see where things might be not working).
Next step of course is to figure out why in this test the dashboard section
isn't even running. I'll let you work on that. My general strategy is to put
debugging in various places to confirm if things are running with the right
values, or where they aren't, and narrow down to the spot where it goes wrong.
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
I have tried with adding above lines, but still doesn't work. Can you take
a look at my implementation
<https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/>
?
Thanks!
On Fri, Jul 13, 2018 at 7:31 PM Dave Brondsema <da...@brondsema.net> wrote:
> My first thought is that it probably is not getting indexed in solr. That
> runs
> in a background task, so during tests it won't happen automatically. Try
> adding
> this:
>
> ThreadLocalORMSession.flush_all()
> M.MonQTask.run_ready()
> ThreadLocalORMSession.flush_all()
>
> The run_ready() call will run the background tasks that are queued up. The
> flush_all() lines might not be necessary, but I see them in other tests.
> You
> can try with and without them. What they do is ensure all changes to
> models are
> flushed to mongo.
>
> Let me know if that doesn't help and I'll take a closer look.
>
> On 7/13/18 8:41 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > I have started to create a test case for Tickets Section.
> >
> > I was trying to create a new ticket and check whether it appears in
> > Dashboard, but it doesn't work. It seems like I've done something wrong
> > when creating new ticket.
> >
> > Could you kindly take a look at my implementation
> > <
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/56062d5c56aad503e022727b0dd5b67d37133b2e/
> >
> > and help me to sort out the issue?
> >
> > Thanks!
> >
> > On Thu, Jul 12, 2018 at 10:04 PM Deshani Geethika <
> deshanigeethika@gmail.com>
> > wrote:
> >
> >> Thanks. I'll start working on it and give you updates
> >>
> >> On Thu, Jul 12, 2018 at 8:57 PM Dave Brondsema <da...@brondsema.net>
> wrote:
> >>
> >>> I think it would be good to have a test of each of the sections. At
> least
> >>> tickets & merge requests. For projects and activity, they are very
> >>> similar &
> >>> re-use code from the profile sections. So you could either copy the
> test
> >>> structure and have very similar tests to the user profile tests, or
> omit
> >>> the
> >>> tests for those.
> >>>
> >>> For tickets & merge requests I think good tests would create a few
> >>> tickets (or
> >>> merge requests) and then get the /dashboard URL and assert that they
> >>> showed up.
> >>> The ForgeTracker suite should have plenty of examples of making tickets
> >>> without
> >>> having to do mocking probably. To make a merge request,
> >>> allura.tests.model.test_repo.TestMergeRequest has an abstract test that
> >>> uses
> >>> some mocking. It'd be better though to use a more real merge request
> like
> >>> ForgeGit's tests do.
> >>>
> >>>
> >>> On 7/11/18 1:06 PM, Deshani Geethika wrote:
> >>>> Hi Dave,
> >>>>
> >>>> I've created a test case for Dashboard sections and added a merge
> >>> request
> >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/268/>.
> >>> Please
> >>>> review it and let me know if any improvements required.
> >>>>
> >>>> Also, could you let me know what are the other functionalities should
> be
> >>>> tested in Dashboard?
> >>>>
> >>>> Regards!
> >>>>
> >>>> On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema <da...@brondsema.net>
> >>> wrote:
> >>>>
> >>>>> Hi.
> >>>>>
> >>>>> On profile pages, the self.project refers to that user-project
> >>> /u/brondsem
> >>>>> for
> >>>>> example. You can get a reference to the same project in the
> dashboard
> >>> with
> >>>>> c.user.private_project()
> >>>>>
> >>>>> On another note, the title "My Followers" sounds like it would be
> >>> people
> >>>>> who
> >>>>> follow me, which isn't correct. On profile pages (if you click to
> view
> >>>>> all) it
> >>>>> says "Activity from people you follow" which is lengthy but better.
> Or
> >>>>> just
> >>>>> "Activity" would be ok.
> >>>>>
> >>>>> -Dave
> >>>>>
> >>>>> On 7/6/18 3:13 PM, Deshani Geethika wrote:
> >>>>>> Hi Dave,
> >>>>>>
> >>>>>> I've started to work on Followers Section and pushed the current
> code
> >>> to
> >>>>> my
> >>>>>> fork. (
> >>>>>
> >>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
> >>>>>> )
> >>>>>>
> >>>>>> I need to create activity_app instance in class FollowersSection in
> >>>>>> allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
> >>>>>>
> >>>>>> In class ForgeActivityProfileSection which is in
> >>> forgeactivity/main.py,
> >>>>> the
> >>>>>> activity_app instance is created by accessing project instance as
> >>>>>> self.activity_app
> >>>>>> = self.project.app_instance('activity'). (Line #278)
> >>>>>>
> >>>>>> How can I create activity_app instance in dashboard without a
> project
> >>>>>> instance?
> >>>>>>
> >>>>>> Regards!
> >>>>>>
> >>>>>> On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
> >>>>> deshanigeethika@gmail.com>
> >>>>>> wrote:
> >>>>>>
> >>>>>>> Hi Dave,
> >>>>>>>
> >>>>>>> I've completed the Tickets section and added a merge request
> >>>>>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
> >>>>>>>
> >>>>>>> Please review it and let me know if any improvements required.
> >>>>>>>
> >>>>>>> Regards!
> >>>>>>>
> >>>>>>> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
> >>>>>>> deshanigeethika@gmail.com> wrote:
> >>>>>>>
> >>>>>>>> Hi Dave,
> >>>>>>>>
> >>>>>>>> Thanks. I'm still working on it. Will give you an update soon.
> >>>>>>>>
> >>>>>>>> Regards!
> >>>>>>>>
> >>>>>>>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema <
> dave@brondsema.net>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hey Deshani,
> >>>>>>>>>
> >>>>>>>>> Just wondering how things are going? If you want to push your
> >>> current
> >>>>>>>>> branch,
> >>>>>>>>> and let me know if any questions or issues, I can offer some more
> >>>>> help.
> >>>>>>>>>
> >>>>>>>>> I am impressed with how much you've figured out on your own. I'm
> >>> here
> >>>>>>>>> to mentor
> >>>>>>>>> and help though too :)
> >>>>>>>>>
> >>>>>>>>> -Dave
> >>>>>>>>>
> >>>>>>>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
> >>>>>>>>>> Thanks. I'll be there today at 11am EDT.
> >>>>>>>>>>
> >>>>>>>>>> On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema <
> >>> dave@brondsema.net
> >>>>>>>>>> <ma...@brondsema.net>> wrote:
> >>>>>>>>>>
> >>>>>>>>>> Thanks, I've taken a look at the code to get familiar with
> it
> >>> and
> >>>>>>>>> have some
> >>>>>>>>>> ideas.
> >>>>>>>>>>
> >>>>>>>>>> Today I am available today much any time from now until 6pm
> >>> EDT.
> >>>>>>>>> Or tomorrow
> >>>>>>>>>> 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can
> >>> switch
> >>>>>>>>> over to chat to
> >>>>>>>>>> coordinate too.
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On 6/26/18 4:04 AM, Deshani Geethika wrote:
> >>>>>>>>>> > Hi Dave,
> >>>>>>>>>> >
> >>>>>>>>>> > I have pushed the current code into my fork.
> >>>>>>>>>> >
> >>>>>>>>>> (
> >>>>>>>>>
> >>>>>
> >>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
> >>>>>>>>> )
> >>>>>>>>>> >
> >>>>>>>>>> > Please let me know a convenient slot to have a call.
> >>>>>>>>>> >
> >>>>>>>>>> > Regards!
> >>>>>>>>>> >
> >>>>>>>>>> > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
> >>>>>>>>> dave@brondsema.net
> >>>>>>>>>> <ma...@brondsema.net>
> >>>>>>>>>> > <mailto:dave@brondsema.net <ma...@brondsema.net>>>
> >>>>> wrote:
> >>>>>>>>>> >
> >>>>>>>>>> > Hey Deshani, do you want to do another video call? If
> >>> you
> >>>>>>>>> want to
> >>>>>>>>>> push your
> >>>>>>>>>> > current code to a branch then I could take a look at
> it
> >>>>> too,
> >>>>>>>>> and
> >>>>>>>>>> understand what
> >>>>>>>>>> > you have so far. Then we could do a video/screenshare
> >>>>> call,
> >>>>>>>>> continue with
> >>>>>>>>>> > emails, or do chats. Whatever you prefer.
> >>>>>>>>>> >
> >>>>>>>>>> > -Dave
> >>>>>>>>>> >
> >>>>>>>>>> >
> >>>>>>>>>> >
> >>>>>>>>>> > --
> >>>>>>>>>> > *Deshani Geethika*
> >>>>>>>>>> > Undergraduate at Department of Computer Science and
> >>> Engineering
> >>>>>>>>>> > Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>>>>>>> > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> |
> >>>>> GitHub
> >>>>>>>>>> > <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>>>>>> >
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Dave Brondsema : dave@brondsema.net <mailto:
> >>> dave@brondsema.net>
> >>>>>>>>>> http://www.brondsema.net : personal
> >>>>>>>>>> http://www.splike.com : programming
> >>>>>>>>>> <><
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> *Deshani Geethika*
> >>>>>>>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> |
> GitHub
> >>>>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> Dave Brondsema : dave@brondsema.net
> >>>>>>>>> http://www.brondsema.net : personal
> >>>>>>>>> http://www.splike.com : programming
> >>>>>>>>> <><
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> *Deshani Geethika*
> >>>>>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> *Deshani Geethika*
> >>>>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Dave Brondsema : dave@brondsema.net
> >>>>> http://www.brondsema.net : personal
> >>>>> http://www.splike.com : programming
> >>>>> <><
> >>>>>
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Dave Brondsema : dave@brondsema.net
> >>> http://www.brondsema.net : personal
> >>> http://www.splike.com : programming
> >>> <><
> >>>
> >>
> >>
> >> --
> >> *Deshani Geethika*
> >> Undergraduate at Department of Computer Science and Engineering
> >> Faculty of Engineering - University of Moratuwa Sri Lanka
> >> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>
> >>
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Dave Brondsema <da...@brondsema.net>.
My first thought is that it probably is not getting indexed in solr. That runs
in a background task, so during tests it won't happen automatically. Try adding
this:
ThreadLocalORMSession.flush_all()
M.MonQTask.run_ready()
ThreadLocalORMSession.flush_all()
The run_ready() call will run the background tasks that are queued up. The
flush_all() lines might not be necessary, but I see them in other tests. You
can try with and without them. What they do is ensure all changes to models are
flushed to mongo.
Let me know if that doesn't help and I'll take a closer look.
On 7/13/18 8:41 AM, Deshani Geethika wrote:
> Hi Dave,
>
> I have started to create a test case for Tickets Section.
>
> I was trying to create a new ticket and check whether it appears in
> Dashboard, but it doesn't work. It seems like I've done something wrong
> when creating new ticket.
>
> Could you kindly take a look at my implementation
> <https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/56062d5c56aad503e022727b0dd5b67d37133b2e/>
> and help me to sort out the issue?
>
> Thanks!
>
> On Thu, Jul 12, 2018 at 10:04 PM Deshani Geethika <de...@gmail.com>
> wrote:
>
>> Thanks. I'll start working on it and give you updates
>>
>> On Thu, Jul 12, 2018 at 8:57 PM Dave Brondsema <da...@brondsema.net> wrote:
>>
>>> I think it would be good to have a test of each of the sections. At least
>>> tickets & merge requests. For projects and activity, they are very
>>> similar &
>>> re-use code from the profile sections. So you could either copy the test
>>> structure and have very similar tests to the user profile tests, or omit
>>> the
>>> tests for those.
>>>
>>> For tickets & merge requests I think good tests would create a few
>>> tickets (or
>>> merge requests) and then get the /dashboard URL and assert that they
>>> showed up.
>>> The ForgeTracker suite should have plenty of examples of making tickets
>>> without
>>> having to do mocking probably. To make a merge request,
>>> allura.tests.model.test_repo.TestMergeRequest has an abstract test that
>>> uses
>>> some mocking. It'd be better though to use a more real merge request like
>>> ForgeGit's tests do.
>>>
>>>
>>> On 7/11/18 1:06 PM, Deshani Geethika wrote:
>>>> Hi Dave,
>>>>
>>>> I've created a test case for Dashboard sections and added a merge
>>> request
>>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/268/>.
>>> Please
>>>> review it and let me know if any improvements required.
>>>>
>>>> Also, could you let me know what are the other functionalities should be
>>>> tested in Dashboard?
>>>>
>>>> Regards!
>>>>
>>>> On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema <da...@brondsema.net>
>>> wrote:
>>>>
>>>>> Hi.
>>>>>
>>>>> On profile pages, the self.project refers to that user-project
>>> /u/brondsem
>>>>> for
>>>>> example. You can get a reference to the same project in the dashboard
>>> with
>>>>> c.user.private_project()
>>>>>
>>>>> On another note, the title "My Followers" sounds like it would be
>>> people
>>>>> who
>>>>> follow me, which isn't correct. On profile pages (if you click to view
>>>>> all) it
>>>>> says "Activity from people you follow" which is lengthy but better. Or
>>>>> just
>>>>> "Activity" would be ok.
>>>>>
>>>>> -Dave
>>>>>
>>>>> On 7/6/18 3:13 PM, Deshani Geethika wrote:
>>>>>> Hi Dave,
>>>>>>
>>>>>> I've started to work on Followers Section and pushed the current code
>>> to
>>>>> my
>>>>>> fork. (
>>>>>
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
>>>>>> )
>>>>>>
>>>>>> I need to create activity_app instance in class FollowersSection in
>>>>>> allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
>>>>>>
>>>>>> In class ForgeActivityProfileSection which is in
>>> forgeactivity/main.py,
>>>>> the
>>>>>> activity_app instance is created by accessing project instance as
>>>>>> self.activity_app
>>>>>> = self.project.app_instance('activity'). (Line #278)
>>>>>>
>>>>>> How can I create activity_app instance in dashboard without a project
>>>>>> instance?
>>>>>>
>>>>>> Regards!
>>>>>>
>>>>>> On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
>>>>> deshanigeethika@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I've completed the Tickets section and added a merge request
>>>>>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
>>>>>>>
>>>>>>> Please review it and let me know if any improvements required.
>>>>>>>
>>>>>>> Regards!
>>>>>>>
>>>>>>> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
>>>>>>> deshanigeethika@gmail.com> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> Thanks. I'm still working on it. Will give you an update soon.
>>>>>>>>
>>>>>>>> Regards!
>>>>>>>>
>>>>>>>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema <da...@brondsema.net>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hey Deshani,
>>>>>>>>>
>>>>>>>>> Just wondering how things are going? If you want to push your
>>> current
>>>>>>>>> branch,
>>>>>>>>> and let me know if any questions or issues, I can offer some more
>>>>> help.
>>>>>>>>>
>>>>>>>>> I am impressed with how much you've figured out on your own. I'm
>>> here
>>>>>>>>> to mentor
>>>>>>>>> and help though too :)
>>>>>>>>>
>>>>>>>>> -Dave
>>>>>>>>>
>>>>>>>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
>>>>>>>>>> Thanks. I'll be there today at 11am EDT.
>>>>>>>>>>
>>>>>>>>>> On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema <
>>> dave@brondsema.net
>>>>>>>>>> <ma...@brondsema.net>> wrote:
>>>>>>>>>>
>>>>>>>>>> Thanks, I've taken a look at the code to get familiar with it
>>> and
>>>>>>>>> have some
>>>>>>>>>> ideas.
>>>>>>>>>>
>>>>>>>>>> Today I am available today much any time from now until 6pm
>>> EDT.
>>>>>>>>> Or tomorrow
>>>>>>>>>> 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can
>>> switch
>>>>>>>>> over to chat to
>>>>>>>>>> coordinate too.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 6/26/18 4:04 AM, Deshani Geethika wrote:
>>>>>>>>>> > Hi Dave,
>>>>>>>>>> >
>>>>>>>>>> > I have pushed the current code into my fork.
>>>>>>>>>> >
>>>>>>>>>> (
>>>>>>>>>
>>>>>
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
>>>>>>>>> )
>>>>>>>>>> >
>>>>>>>>>> > Please let me know a convenient slot to have a call.
>>>>>>>>>> >
>>>>>>>>>> > Regards!
>>>>>>>>>> >
>>>>>>>>>> > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
>>>>>>>>> dave@brondsema.net
>>>>>>>>>> <ma...@brondsema.net>
>>>>>>>>>> > <mailto:dave@brondsema.net <ma...@brondsema.net>>>
>>>>> wrote:
>>>>>>>>>> >
>>>>>>>>>> > Hey Deshani, do you want to do another video call? If
>>> you
>>>>>>>>> want to
>>>>>>>>>> push your
>>>>>>>>>> > current code to a branch then I could take a look at it
>>>>> too,
>>>>>>>>> and
>>>>>>>>>> understand what
>>>>>>>>>> > you have so far. Then we could do a video/screenshare
>>>>> call,
>>>>>>>>> continue with
>>>>>>>>>> > emails, or do chats. Whatever you prefer.
>>>>>>>>>> >
>>>>>>>>>> > -Dave
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > --
>>>>>>>>>> > *Deshani Geethika*
>>>>>>>>>> > Undergraduate at Department of Computer Science and
>>> Engineering
>>>>>>>>>> > Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>>>>> > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> |
>>>>> GitHub
>>>>>>>>>> > <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>>>> >
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Brondsema : dave@brondsema.net <mailto:
>>> dave@brondsema.net>
>>>>>>>>>> http://www.brondsema.net : personal
>>>>>>>>>> http://www.splike.com : programming
>>>>>>>>>> <><
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> *Deshani Geethika*
>>>>>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Brondsema : dave@brondsema.net
>>>>>>>>> http://www.brondsema.net : personal
>>>>>>>>> http://www.splike.com : programming
>>>>>>>>> <><
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Deshani Geethika*
>>>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Deshani Geethika*
>>>>>>> Undergraduate at Department of Computer Science and Engineering
>>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Brondsema : dave@brondsema.net
>>>>> http://www.brondsema.net : personal
>>>>> http://www.splike.com : programming
>>>>> <><
>>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Brondsema : dave@brondsema.net
>>> http://www.brondsema.net : personal
>>> http://www.splike.com : programming
>>> <><
>>>
>>
>>
>> --
>> *Deshani Geethika*
>> Undergraduate at Department of Computer Science and Engineering
>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> <https://github.com/deshanigtk> | Mobile - +94776383034
>>
>>
>
--
Dave Brondsema : dave@brondsema.net
http://www.brondsema.net : personal
http://www.splike.com : programming
<><
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
I have started to create a test case for Tickets Section.
I was trying to create a new ticket and check whether it appears in
Dashboard, but it doesn't work. It seems like I've done something wrong
when creating new ticket.
Could you kindly take a look at my implementation
<https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/56062d5c56aad503e022727b0dd5b67d37133b2e/>
and help me to sort out the issue?
Thanks!
On Thu, Jul 12, 2018 at 10:04 PM Deshani Geethika <de...@gmail.com>
wrote:
> Thanks. I'll start working on it and give you updates
>
> On Thu, Jul 12, 2018 at 8:57 PM Dave Brondsema <da...@brondsema.net> wrote:
>
>> I think it would be good to have a test of each of the sections. At least
>> tickets & merge requests. For projects and activity, they are very
>> similar &
>> re-use code from the profile sections. So you could either copy the test
>> structure and have very similar tests to the user profile tests, or omit
>> the
>> tests for those.
>>
>> For tickets & merge requests I think good tests would create a few
>> tickets (or
>> merge requests) and then get the /dashboard URL and assert that they
>> showed up.
>> The ForgeTracker suite should have plenty of examples of making tickets
>> without
>> having to do mocking probably. To make a merge request,
>> allura.tests.model.test_repo.TestMergeRequest has an abstract test that
>> uses
>> some mocking. It'd be better though to use a more real merge request like
>> ForgeGit's tests do.
>>
>>
>> On 7/11/18 1:06 PM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > I've created a test case for Dashboard sections and added a merge
>> request
>> > <https://forge-allura.apache.org/p/allura/git/merge-requests/268/>.
>> Please
>> > review it and let me know if any improvements required.
>> >
>> > Also, could you let me know what are the other functionalities should be
>> > tested in Dashboard?
>> >
>> > Regards!
>> >
>> > On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema <da...@brondsema.net>
>> wrote:
>> >
>> >> Hi.
>> >>
>> >> On profile pages, the self.project refers to that user-project
>> /u/brondsem
>> >> for
>> >> example. You can get a reference to the same project in the dashboard
>> with
>> >> c.user.private_project()
>> >>
>> >> On another note, the title "My Followers" sounds like it would be
>> people
>> >> who
>> >> follow me, which isn't correct. On profile pages (if you click to view
>> >> all) it
>> >> says "Activity from people you follow" which is lengthy but better. Or
>> >> just
>> >> "Activity" would be ok.
>> >>
>> >> -Dave
>> >>
>> >> On 7/6/18 3:13 PM, Deshani Geethika wrote:
>> >>> Hi Dave,
>> >>>
>> >>> I've started to work on Followers Section and pushed the current code
>> to
>> >> my
>> >>> fork. (
>> >>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
>> >>> )
>> >>>
>> >>> I need to create activity_app instance in class FollowersSection in
>> >>> allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
>> >>>
>> >>> In class ForgeActivityProfileSection which is in
>> forgeactivity/main.py,
>> >> the
>> >>> activity_app instance is created by accessing project instance as
>> >>> self.activity_app
>> >>> = self.project.app_instance('activity'). (Line #278)
>> >>>
>> >>> How can I create activity_app instance in dashboard without a project
>> >>> instance?
>> >>>
>> >>> Regards!
>> >>>
>> >>> On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
>> >> deshanigeethika@gmail.com>
>> >>> wrote:
>> >>>
>> >>>> Hi Dave,
>> >>>>
>> >>>> I've completed the Tickets section and added a merge request
>> >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
>> >>>>
>> >>>> Please review it and let me know if any improvements required.
>> >>>>
>> >>>> Regards!
>> >>>>
>> >>>> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
>> >>>> deshanigeethika@gmail.com> wrote:
>> >>>>
>> >>>>> Hi Dave,
>> >>>>>
>> >>>>> Thanks. I'm still working on it. Will give you an update soon.
>> >>>>>
>> >>>>> Regards!
>> >>>>>
>> >>>>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema <da...@brondsema.net>
>> >>>>> wrote:
>> >>>>>
>> >>>>>> Hey Deshani,
>> >>>>>>
>> >>>>>> Just wondering how things are going? If you want to push your
>> current
>> >>>>>> branch,
>> >>>>>> and let me know if any questions or issues, I can offer some more
>> >> help.
>> >>>>>>
>> >>>>>> I am impressed with how much you've figured out on your own. I'm
>> here
>> >>>>>> to mentor
>> >>>>>> and help though too :)
>> >>>>>>
>> >>>>>> -Dave
>> >>>>>>
>> >>>>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
>> >>>>>>> Thanks. I'll be there today at 11am EDT.
>> >>>>>>>
>> >>>>>>> On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema <
>> dave@brondsema.net
>> >>>>>>> <ma...@brondsema.net>> wrote:
>> >>>>>>>
>> >>>>>>> Thanks, I've taken a look at the code to get familiar with it
>> and
>> >>>>>> have some
>> >>>>>>> ideas.
>> >>>>>>>
>> >>>>>>> Today I am available today much any time from now until 6pm
>> EDT.
>> >>>>>> Or tomorrow
>> >>>>>>> 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can
>> switch
>> >>>>>> over to chat to
>> >>>>>>> coordinate too.
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> On 6/26/18 4:04 AM, Deshani Geethika wrote:
>> >>>>>>> > Hi Dave,
>> >>>>>>> >
>> >>>>>>> > I have pushed the current code into my fork.
>> >>>>>>> >
>> >>>>>>> (
>> >>>>>>
>> >>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
>> >>>>>> )
>> >>>>>>> >
>> >>>>>>> > Please let me know a convenient slot to have a call.
>> >>>>>>> >
>> >>>>>>> > Regards!
>> >>>>>>> >
>> >>>>>>> > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
>> >>>>>> dave@brondsema.net
>> >>>>>>> <ma...@brondsema.net>
>> >>>>>>> > <mailto:dave@brondsema.net <ma...@brondsema.net>>>
>> >> wrote:
>> >>>>>>> >
>> >>>>>>> > Hey Deshani, do you want to do another video call? If
>> you
>> >>>>>> want to
>> >>>>>>> push your
>> >>>>>>> > current code to a branch then I could take a look at it
>> >> too,
>> >>>>>> and
>> >>>>>>> understand what
>> >>>>>>> > you have so far. Then we could do a video/screenshare
>> >> call,
>> >>>>>> continue with
>> >>>>>>> > emails, or do chats. Whatever you prefer.
>> >>>>>>> >
>> >>>>>>> > -Dave
>> >>>>>>> >
>> >>>>>>> >
>> >>>>>>> >
>> >>>>>>> > --
>> >>>>>>> > *Deshani Geethika*
>> >>>>>>> > Undergraduate at Department of Computer Science and
>> Engineering
>> >>>>>>> > Faculty of Engineering - University of Moratuwa Sri Lanka
>> >>>>>>> > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> |
>> >> GitHub
>> >>>>>>> > <https://github.com/deshanigtk> | Mobile - +94776383034
>> >>>>>>> >
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> --
>> >>>>>>> Dave Brondsema : dave@brondsema.net <mailto:
>> dave@brondsema.net>
>> >>>>>>> http://www.brondsema.net : personal
>> >>>>>>> http://www.splike.com : programming
>> >>>>>>> <><
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> --
>> >>>>>>> *Deshani Geethika*
>> >>>>>>> Undergraduate at Department of Computer Science and Engineering
>> >>>>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> >>>>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> >>>>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>> >>>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>> --
>> >>>>>> Dave Brondsema : dave@brondsema.net
>> >>>>>> http://www.brondsema.net : personal
>> >>>>>> http://www.splike.com : programming
>> >>>>>> <><
>> >>>>>>
>> >>>>>
>> >>>>>
>> >>>>> --
>> >>>>> *Deshani Geethika*
>> >>>>> Undergraduate at Department of Computer Science and Engineering
>> >>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> >>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> >>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>> >>>>>
>> >>>>>
>> >>>>
>> >>>> --
>> >>>> *Deshani Geethika*
>> >>>> Undergraduate at Department of Computer Science and Engineering
>> >>>> Faculty of Engineering - University of Moratuwa Sri Lanka
>> >>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>> >>>> <https://github.com/deshanigtk> | Mobile - +94776383034
>> >>>>
>> >>>>
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Brondsema : dave@brondsema.net
>> >> http://www.brondsema.net : personal
>> >> http://www.splike.com : programming
>> >> <><
>> >>
>> >
>> >
>>
>>
>>
>> --
>> Dave Brondsema : dave@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Posted by Deshani Geethika <de...@gmail.com>.
Hi Dave,
I've created a test case for Dashboard sections and added a merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/268/>. Please
review it and let me know if any improvements required.
Also, could you let me know what are the other functionalities should be
tested in Dashboard?
Regards!
On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema <da...@brondsema.net> wrote:
> Hi.
>
> On profile pages, the self.project refers to that user-project /u/brondsem
> for
> example. You can get a reference to the same project in the dashboard with
> c.user.private_project()
>
> On another note, the title "My Followers" sounds like it would be people
> who
> follow me, which isn't correct. On profile pages (if you click to view
> all) it
> says "Activity from people you follow" which is lengthy but better. Or
> just
> "Activity" would be ok.
>
> -Dave
>
> On 7/6/18 3:13 PM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > I've started to work on Followers Section and pushed the current code to
> my
> > fork. (
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
> > )
> >
> > I need to create activity_app instance in class FollowersSection in
> > allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
> >
> > In class ForgeActivityProfileSection which is in forgeactivity/main.py,
> the
> > activity_app instance is created by accessing project instance as
> > self.activity_app
> > = self.project.app_instance('activity'). (Line #278)
> >
> > How can I create activity_app instance in dashboard without a project
> > instance?
> >
> > Regards!
> >
> > On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
> deshanigeethika@gmail.com>
> > wrote:
> >
> >> Hi Dave,
> >>
> >> I've completed the Tickets section and added a merge request
> >> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
> >>
> >> Please review it and let me know if any improvements required.
> >>
> >> Regards!
> >>
> >> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
> >> deshanigeethika@gmail.com> wrote:
> >>
> >>> Hi Dave,
> >>>
> >>> Thanks. I'm still working on it. Will give you an update soon.
> >>>
> >>> Regards!
> >>>
> >>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema <da...@brondsema.net>
> >>> wrote:
> >>>
> >>>> Hey Deshani,
> >>>>
> >>>> Just wondering how things are going? If you want to push your current
> >>>> branch,
> >>>> and let me know if any questions or issues, I can offer some more
> help.
> >>>>
> >>>> I am impressed with how much you've figured out on your own. I'm here
> >>>> to mentor
> >>>> and help though too :)
> >>>>
> >>>> -Dave
> >>>>
> >>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
> >>>>> Thanks. I'll be there today at 11am EDT.
> >>>>>
> >>>>> On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema <dave@brondsema.net
> >>>>> <ma...@brondsema.net>> wrote:
> >>>>>
> >>>>> Thanks, I've taken a look at the code to get familiar with it and
> >>>> have some
> >>>>> ideas.
> >>>>>
> >>>>> Today I am available today much any time from now until 6pm EDT.
> >>>> Or tomorrow
> >>>>> 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can switch
> >>>> over to chat to
> >>>>> coordinate too.
> >>>>>
> >>>>>
> >>>>> On 6/26/18 4:04 AM, Deshani Geethika wrote:
> >>>>> > Hi Dave,
> >>>>> >
> >>>>> > I have pushed the current code into my fork.
> >>>>> >
> >>>>> (
> >>>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
> >>>> )
> >>>>> >
> >>>>> > Please let me know a convenient slot to have a call.
> >>>>> >
> >>>>> > Regards!
> >>>>> >
> >>>>> > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
> >>>> dave@brondsema.net
> >>>>> <ma...@brondsema.net>
> >>>>> > <mailto:dave@brondsema.net <ma...@brondsema.net>>>
> wrote:
> >>>>> >
> >>>>> > Hey Deshani, do you want to do another video call? If you
> >>>> want to
> >>>>> push your
> >>>>> > current code to a branch then I could take a look at it
> too,
> >>>> and
> >>>>> understand what
> >>>>> > you have so far. Then we could do a video/screenshare
> call,
> >>>> continue with
> >>>>> > emails, or do chats. Whatever you prefer.
> >>>>> >
> >>>>> > -Dave
> >>>>> >
> >>>>> >
> >>>>> >
> >>>>> > --
> >>>>> > *Deshani Geethika*
> >>>>> > Undergraduate at Department of Computer Science and Engineering
> >>>>> > Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>> > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> |
> GitHub
> >>>>> > <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>> >
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Dave Brondsema : dave@brondsema.net <ma...@brondsema.net>
> >>>>> http://www.brondsema.net : personal
> >>>>> http://www.splike.com : programming
> >>>>> <><
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> *Deshani Geethika*
> >>>>> Undergraduate at Department of Computer Science and Engineering
> >>>>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>>>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>>>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>>>
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Dave Brondsema : dave@brondsema.net
> >>>> http://www.brondsema.net : personal
> >>>> http://www.splike.com : programming
> >>>> <><
> >>>>
> >>>
> >>>
> >>> --
> >>> *Deshani Geethika*
> >>> Undergraduate at Department of Computer Science and Engineering
> >>> Faculty of Engineering - University of Moratuwa Sri Lanka
> >>> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >>> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>>
> >>>
> >>
> >> --
> >> *Deshani Geethika*
> >> Undergraduate at Department of Computer Science and Engineering
> >> Faculty of Engineering - University of Moratuwa Sri Lanka
> >> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> >> <https://github.com/deshanigtk> | Mobile - +94776383034
> >>
> >>
> >
>
>
>
> --
> Dave Brondsema : dave@brondsema.net
> http://www.brondsema.net : personal
> http://www.splike.com : programming
> <><
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034