[GitHub] [daffodil] stevedlawrence commented on pull request #947: Add scalafmt

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on PR #947:
URL: https://github.com/apache/daffodil/pull/947#issuecomment-1419770132

   This needs to be rebased to fix the conflicts now that OSGI is merged.
   
   Also, we need to figure out how to handle the windows failures. Git on windows enables autocrlf so all the files end in CRLF instead of LF and scalafmt complains. We could just add a condition so the check only runs on linux. Or maybe a better options is to split it off into another job? We really don't need to run scalafmt on multiple OSes--running once on ubuntu should be fine. We may want to also make the OSGI check and Rat check also be separate jobs, or maybe combine those three checks into some generic job that does checks that aren't os/environment specific?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org