You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by pavan kumar kolamuri <pa...@gmail.com> on 2016/01/11 13:44:49 UTC

Review Request 42139: Falcon Server starts even though Servlet context initialization fails.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1682
    https://issues.apache.org/jira/browse/FALCON-1682


Repository: falcon-git


Description
-------

Server starts even though servlet context initialization fails.


Diffs
-----

  src/bin/falcon-start 3f5a9d8 
  src/bin/service-stop.sh 5c08c29 

Diff: https://reviews.apache.org/r/42139/diff/


Testing
-------

Manual testing done.


Thanks,

pavan kumar kolamuri


Re: Review Request 42139: Falcon Server starts even though Servlet context initialization fails.

Posted by pavan kumar kolamuri <pa...@gmail.com>.

> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 34
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line34>
> >
> >     service-start starts the Falcon server in the background. So, Falcon might not have really started when we issue this command. 
> >     
> >     Consider using retries.
> 
> pavan kumar kolamuri wrote:
>     I tried to look into this. Falcon Server is not running as background, next statements are executing only when that cmd executes.
> 
> pavan kumar kolamuri wrote:
>     My bad i am mistaken. Will fix this as well.

I dont think we can use retries also since we are not sure how much falcon server takes to start, initialization of services might take longer for the server which has more load.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/#review113929
-----------------------------------------------------------


On Jan. 11, 2016, 12:44 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42139/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1682
>     https://issues.apache.org/jira/browse/FALCON-1682
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Server starts even though servlet context initialization fails.
> 
> 
> Diffs
> -----
> 
>   src/bin/falcon-start 3f5a9d8 
>   src/bin/service-stop.sh 5c08c29 
> 
> Diff: https://reviews.apache.org/r/42139/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Re: Review Request 42139: Falcon Server starts even though Servlet context initialization fails.

Posted by pavan kumar kolamuri <pa...@gmail.com>.

> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 34
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line34>
> >
> >     service-start starts the Falcon server in the background. So, Falcon might not have really started when we issue this command. 
> >     
> >     Consider using retries.

I tried to look into this. Falcon Server is not running as background, next statements are executing only when that cmd executes.


> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 39
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line39>
> >
> >     Rephrase: Falon Server has not started yet. To ensure that the server has indeed started, check logs in ${BASEDIR}/logs/falcon.application.log
> >     
> >     (This is in case the Server takes too long to start.)

sure will fix


> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 40
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line40>
> >
> >     Can we also update falcon-stop to use the force stop option?

sure will do


> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/service-stop.sh, line 37
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192094#file1192094line37>
> >
> >     Use -force or -f. With a hyphen it clear that it is an arg.

sure will fix.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/#review113929
-----------------------------------------------------------


On Jan. 11, 2016, 12:44 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42139/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1682
>     https://issues.apache.org/jira/browse/FALCON-1682
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Server starts even though servlet context initialization fails.
> 
> 
> Diffs
> -----
> 
>   src/bin/falcon-start 3f5a9d8 
>   src/bin/service-stop.sh 5c08c29 
> 
> Diff: https://reviews.apache.org/r/42139/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Re: Review Request 42139: Falcon Server starts even though Servlet context initialization fails.

Posted by pavan kumar kolamuri <pa...@gmail.com>.

> On Jan. 12, 2016, 4:54 a.m., Pallavi Rao wrote:
> > src/bin/falcon-start, line 34
> > <https://reviews.apache.org/r/42139/diff/1/?file=1192093#file1192093line34>
> >
> >     service-start starts the Falcon server in the background. So, Falcon might not have really started when we issue this command. 
> >     
> >     Consider using retries.
> 
> pavan kumar kolamuri wrote:
>     I tried to look into this. Falcon Server is not running as background, next statements are executing only when that cmd executes.

My bad i am mistaken. Will fix this as well.


- pavan kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/#review113929
-----------------------------------------------------------


On Jan. 11, 2016, 12:44 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42139/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1682
>     https://issues.apache.org/jira/browse/FALCON-1682
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Server starts even though servlet context initialization fails.
> 
> 
> Diffs
> -----
> 
>   src/bin/falcon-start 3f5a9d8 
>   src/bin/service-stop.sh 5c08c29 
> 
> Diff: https://reviews.apache.org/r/42139/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>


Re: Review Request 42139: Falcon Server starts even though Servlet context initialization fails.

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42139/#review113929
-----------------------------------------------------------



src/bin/falcon-start (line 34)
<https://reviews.apache.org/r/42139/#comment174718>

    service-start starts the Falcon server in the background. So, Falcon might not have really started when we issue this command. 
    
    Consider using retries.



src/bin/falcon-start (line 39)
<https://reviews.apache.org/r/42139/#comment174715>

    Rephrase: Falon Server has not started yet. To ensure that the server has indeed started, check logs in ${BASEDIR}/logs/falcon.application.log
    
    (This is in case the Server takes too long to start.)



src/bin/falcon-start (line 40)
<https://reviews.apache.org/r/42139/#comment174717>

    Can we also update falcon-stop to use the force stop option?



src/bin/service-stop.sh (line 37)
<https://reviews.apache.org/r/42139/#comment174716>

    Use -force or -f. With a hyphen it clear that it is an arg.


- Pallavi Rao


On Jan. 11, 2016, 12:44 p.m., pavan kumar kolamuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42139/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1682
>     https://issues.apache.org/jira/browse/FALCON-1682
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Server starts even though servlet context initialization fails.
> 
> 
> Diffs
> -----
> 
>   src/bin/falcon-start 3f5a9d8 
>   src/bin/service-stop.sh 5c08c29 
> 
> Diff: https://reviews.apache.org/r/42139/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> pavan kumar kolamuri
> 
>