You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Juan Pablo Santos Rodríguez <ju...@gmail.com> on 2012/07/06 00:05:03 UTC

3rd RC?

Hi,

couple of days ago I was finally able to solve my problems regarding the
Lucene exceptions, as sad as it looks, in the most ancient windows-way:
rebooting (computer at home is up 99% of the time..). So I was feeling now
would be a good moment to push a new RC, hoping that this time it will
become the first ASF release. Before doing that however, I was thinking of
pushing a coulpe of small changes:

- upgrading commons-lang to commons-lang3: aside from the code, this could
imply upgrading other commons-* libraries, if they do depend on
commons-lang and don't know if that would cause to 3rd party plugins, if
they do depend on that library. Another possibility could be simply upgrade
commons-lang to 2.6, which is the latest from 2.x and most probably won't
break anything.

- a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
retrieve and close Lucene indexes. Have that small change from days ago,
when I was pursuing ghosts; the functionally of the class remains exactly
the same, it's just a bit tinier.

WDYT? Does anyone want to push in (or get pushed in) any other thing before
making the next RC?


br,
juan pablo

[#1]
http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html

Re: 3rd RC?

Posted by Dirk Frederickx <di...@gmail.com>.
Juan,

Also committed 2 minor fixes.
OK for RC,

txs
   dirk

On Fri, Jul 6, 2012 at 7:29 PM, Harry Metske <ha...@gmail.com> wrote:

> Juan Pablo,
>
> no problem with the suggested upgrades and refactoring.
> I just committed some minor (doc) corrections for JSPWIKI-731.
>
> Thanks for all your work !
>
> regards,
> Harry
>
>
> 2012/7/6 Juan Pablo Santos Rodríguez <ju...@gmail.com>
>
> > Hi,
> >
> > couple of days ago I was finally able to solve my problems regarding the
> > Lucene exceptions, as sad as it looks, in the most ancient windows-way:
> > rebooting (computer at home is up 99% of the time..). So I was feeling
> now
> > would be a good moment to push a new RC, hoping that this time it will
> > become the first ASF release. Before doing that however, I was thinking
> of
> > pushing a coulpe of small changes:
> >
> > - upgrading commons-lang to commons-lang3: aside from the code, this
> could
> > imply upgrading other commons-* libraries, if they do depend on
> > commons-lang and don't know if that would cause to 3rd party plugins, if
> > they do depend on that library. Another possibility could be simply
> upgrade
> > commons-lang to 2.6, which is the latest from 2.x and most probably won't
> > break anything.
> >
> > - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
> > retrieve and close Lucene indexes. Have that small change from days ago,
> > when I was pursuing ghosts; the functionally of the class remains exactly
> > the same, it's just a bit tinier.
> >
> > WDYT? Does anyone want to push in (or get pushed in) any other thing
> before
> > making the next RC?
> >
> >
> > br,
> > juan pablo
> >
> > [#1]
> >
> >
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
> >
>

Re: 3rd RC?

Posted by Harry Metske <ha...@gmail.com>.
Juan Pablo,

no problem with the suggested upgrades and refactoring.
I just committed some minor (doc) corrections for JSPWIKI-731.

Thanks for all your work !

regards,
Harry


2012/7/6 Juan Pablo Santos Rodríguez <ju...@gmail.com>

> Hi,
>
> couple of days ago I was finally able to solve my problems regarding the
> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
> rebooting (computer at home is up 99% of the time..). So I was feeling now
> would be a good moment to push a new RC, hoping that this time it will
> become the first ASF release. Before doing that however, I was thinking of
> pushing a coulpe of small changes:
>
> - upgrading commons-lang to commons-lang3: aside from the code, this could
> imply upgrading other commons-* libraries, if they do depend on
> commons-lang and don't know if that would cause to 3rd party plugins, if
> they do depend on that library. Another possibility could be simply upgrade
> commons-lang to 2.6, which is the latest from 2.x and most probably won't
> break anything.
>
> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
> retrieve and close Lucene indexes. Have that small change from days ago,
> when I was pursuing ghosts; the functionally of the class remains exactly
> the same, it's just a bit tinier.
>
> WDYT? Does anyone want to push in (or get pushed in) any other thing before
> making the next RC?
>
>
> br,
> juan pablo
>
> [#1]
>
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>

Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Hi Juan Pablo,

ok, if it's like that, the current solution is fine. Thanks for clarifying this!

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Samstag, 11. August 2012 18:50:16
Betreff: Re: 3rd RC?

Hi!

the vote is made against a SVN tag, which should be clean of external jars;
the artifacts are generated for convenience. Each jar in svn.lib is named
with its version so, as long as build.xml refers to the appropiate
versions, there shouldn't be any problem with newer libs. We can have
external jars on our svn, but not alongside with code.

To ease versioning, I initially thought of having different sub-folders
inside svn.lib, according to released versions, but that would mean on most
cases having copies of the same jars on those sub-folders so I preferred to
stay on a single libs dir.


br,
juan pablo


On Fri, Aug 10, 2012 at 8:49 AM, Florian Holeczek <fl...@holeczek.de>wrote:

> Hi Juan Pablo,
>
> haven't been looking at incubating-10 yet, but replying on 2):
>
> According to your answer in the related JIRA issue, we should return to
> the previous libs place for the ones which can't be downloaded from maven
> central. There doesn't seem to be any requirement saying that the libs
> aren't allowed in the repository; they're just not allowed in the src
> artifact, which can be achieved by excluding them from packaging.
> In build.xml, one can then for the libraries refer to the svn.tag, like
> it's done for the src checkout, too. The current solution means that there
> is no versioning in the libs directory, so it would have to stay there
> forever (i.e. as long as related releases should be buildable) and would
> probably grow over time.
> WDYT?
>
> Regarding upgrading: Fully agree! Not now, but definitely later. There are
> even some libraries which aren't maintained anymore.
>
> Regards
>  Florian
>
>
> ----- Ursprüngliche Mail -----
> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Donnerstag, 9. August 2012 22:38:40
> Betreff: Re: 3rd RC?
>
> Hi,
>
> 2.9.0-incubating-10 should run cleanly everytime, fixes the clean and
> hsqldb issues. Also, the libraries are downloaded from Central whenever is
> possible. Which leads me to a couple of questions:
>
> 1) what RC3 should be: as we haven't voted on it yet, I'd like that
> 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
> specially for Janne who is building and pushing the signed artifacts all
> along, so it would be ok for me if we vote on current RC3 tag / generated
> artifacts.
>
> 2) what to do with the jars placed at libs folder in svn: if we vote on
> current RC3 tag / artifacts, they should all remain there. If we vote on a
> tag based on 2.9.0-incubating-10, we could delete a big bunch of files. In
> any case, the jars remaining there after the release, should be there like,
> forever. As there are a few jars that aren't present on Central (i.e. jrcs,
> sandler and a few others), some jars are going to be in svn anyways.
>
> Also, there are some jars that could be downloaded from Central if we
> upgrade them to newer versions, but I think it's safer to do this later on,
> just to freeze the release..
>
> thoughts?
>
>
> rgrds,
> juan pablo
>
>
> On Mon, Aug 6, 2012 at 12:54 AM, Juan Pablo Santos Rodríguez <
> juanpablo.santos@gmail.com> wrote:
>
> > Hi,
> >
> > just added some comments there. Regarding the clean target + hsqldb
> > shutdown, I'll take a look at it this week [1], plus downloading the jars
> > from Central (whenever is possible), to avoid having a big libs folder in
> > our svn. No need to have this in the 3rd rc, but I'd like to have this
> > before graduating
> >
> >
> > br,
> > juan pablo
> >
> > [1]: the clean target should be a no-brainer, for hsqldb I was thinking
> of
> > pulling from build.xml into the appropiate setUp/tearDown methods, in
> order
> > to ensure it gets properly closed.
> >
> >
> >
> > On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <florian@holeczek.de
> >wrote:
> >
> >> Thanks Janne,
> >>
> >> true, I had already written down some notes on that before. There's
> >> pretty much to clean and simplify in our build process. But it's
> obviously
> >> been good enough until now, so that can wait till after graduation, I'd
> >> think.
> >>
> >> However, I'm wondering whether the library handling introduced in
> >> JSPWIKI-738 could lead to problems later on. I've added some notes in
> JIRA.
> >>
> >> Regards
> >>  Florian
> >>
> >>
> >> ----- Ursprüngliche Mail -----
> >> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> An: jspwiki-dev@incubator.apache.org
> >> Gesendet: Sonntag, 5. August 2012 13:20:59
> >> Betreff: Re: 3rd RC?
> >>
> >>
> >> Okay, got it building. Artifacts are now again at
> >> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >>
> >> The problem is that the ant scripts (nor ant clean) don't seem to do a
> >> proper cleanup. I don't check out a clean copy, I just svn switch my
> >> working copy around, and since ant clean doesn't really clean
> everything,
> >> old stuff is still out there.  For example, hsqldb is not properly
> >> terminated at the end of run nor by ant clean.
> >>
> >> By running "svn status" and manually removing all the files that were
> >> autogenerated I can rebuild it without problem.
> >>
> >> /Janne
> >>
> >> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:
> >>
> >> > Hi!
> >> >
> >> > done a fresh checkout from rc3 and could finish the ant clean
> signeddist
> >> > without problems
> >> >
> >> >
> >> > br,
> >> > juan pablo
> >> >
> >> >
> >> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <
> >> Janne.Jalkanen@ecyrd.com>wrote:
> >> >
> >> >>
> >> >> checked out the rc3, ant signeddist, no worky.
> >> >>
> >> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
> >> >>
> >> >>> Hi Janne,
> >> >>>
> >> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
> >> >> Windows. Both are working fine.
> >> >>>
> >> >>> Name  Status  Type    Time(s)
> >> >>> testIfPluginUserAllowed       Success         0.946
> >> >>> testIfPluginUserNotAllowed    Success         0.126
> >> >>> testIfPluginIPAllowed Success         0.083
> >> >>> testIfPluginIPNotAllowed      Success         0.115
> >> >>>
> >> >>> These tests will fail on older versions of JSPWiki (see
> JSPWIKI-737).
> >> Is
> >> >> v2.9.0-incubating-9 running in your test environment?
> >> >>>
> >> >>> Regards
> >> >>> Florian
> >> >>>
> >> >>>
> >> >>> ----- Ursprüngliche Mail -----
> >> >>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>> An: jspwiki-dev@incubator.apache.org
> >> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
> >> >>> Betreff: Re: 3rd RC?
> >> >>>
> >> >>>
> >> >>> D'oh... I'd roll a new release but I've got failing unit tests
> >> >> (IfPluginTest).
> >> >>>
> >> >>> /Janne
> >> >>>
> >> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
> >> >>>
> >> >>>> Now that's funny: What should have avoided confusion obviously led
> to
> >> >> confusion :-)
> >> >>>>
> >> >>>> Janne, these are the old artifacts!
> >> >>>>
> >> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
> >> >> tags/jspwiki_2_9_0_incubating_rc2.
> >> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> >> >>>>
> >> >>>> Regards
> >> >>>> Florian
> >> >>>>
> >> >>>>
> >> >>>> ----- Ursprüngliche Mail -----
> >> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>>> An: jspwiki-dev@incubator.apache.org
> >> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02
> >> >>>> Betreff: Re: 3rd RC?
> >> >>>>
> >> >>>>
> >> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >> >>>>
> >> >>>> /Janne
> >> >>>>
> >> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> >> >>>>
> >> >>>>> Hi!
> >> >>>>>
> >> >>>>> I've just renamed rc2 to avoid confusion.
> >> >>>>>
> >> >>>>> 2.9.0 should be real near now :-)
> >> >>>>>
> >> >>>>>
> >> >>>>> br,
> >> >>>>> juan pablo
> >> >>>>>
> >> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
> >> >> florian@holeczek.de>wrote:
> >> >>>>>
> >> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
> >> >>>>>>
> >> >>>>>> Regards
> >> >>>>>> Florian
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> ----- Ursprüngliche Mail -----
> >> >>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>>>>> An: jspwiki-dev@incubator.apache.org
> >> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
> >> >>>>>> Betreff: Re: 3rd RC?
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> Just tag it and I'll build it from that tag :-)
> >> >>>>>>
> >> >>>>>> /Janne
> >> >>>>>>
> >> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
> >> >>>>>>
> >> >>>>>>> Hi all,
> >> >>>>>>>
> >> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
> >> >>>>>>>
> >> >>>>>>> Regards
> >> >>>>>>> Florian
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> ----- Ursprüngliche Mail -----
> >> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> >> >>>>>>> An: jspwiki-dev@incubator.apache.org
> >> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
> >> >>>>>>> Betreff: 3rd RC?
> >> >>>>>>>
> >> >>>>>>> Hi,
> >> >>>>>>>
> >> >>>>>>> couple of days ago I was finally able to solve my problems
> >> regarding
> >> >> the
> >> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
> >> >> windows-way:
> >> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was
> >> >> feeling
> >> >>>>>> now
> >> >>>>>>> would be a good moment to push a new RC, hoping that this time
> it
> >> >> will
> >> >>>>>>> become the first ASF release. Before doing that however, I was
> >> >> thinking
> >> >>>>>> of
> >> >>>>>>> pushing a coulpe of small changes:
> >> >>>>>>>
> >> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code,
> >> this
> >> >>>>>> could
> >> >>>>>>> imply upgrading other commons-* libraries, if they do depend on
> >> >>>>>>> commons-lang and don't know if that would cause to 3rd party
> >> >> plugins, if
> >> >>>>>>> they do depend on that library. Another possibility could be
> >> simply
> >> >>>>>> upgrade
> >> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most
> >> probably
> >> >> won't
> >> >>>>>>> break anything.
> >> >>>>>>>
> >> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
> >> >> 505-530, to
> >> >>>>>>> retrieve and close Lucene indexes. Have that small change from
> >> days
> >> >> ago,
> >> >>>>>>> when I was pursuing ghosts; the functionally of the class
> remains
> >> >> exactly
> >> >>>>>>> the same, it's just a bit tinier.
> >> >>>>>>>
> >> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other
> >> thing
> >> >>>>>> before
> >> >>>>>>> making the next RC?
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> br,
> >> >>>>>>> juan pablo
> >> >>>>>>>
> >> >>>>>>> [#1]
> >> >>>>>>>
> >> >>>>>>
> >> >>
> >>
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
> >> >>>>>>
> >> >>>>>>
> >> >>
> >> >>
> >>
> >>
> >
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi!

the vote is made against a SVN tag, which should be clean of external jars;
the artifacts are generated for convenience. Each jar in svn.lib is named
with its version so, as long as build.xml refers to the appropiate
versions, there shouldn't be any problem with newer libs. We can have
external jars on our svn, but not alongside with code.

To ease versioning, I initially thought of having different sub-folders
inside svn.lib, according to released versions, but that would mean on most
cases having copies of the same jars on those sub-folders so I preferred to
stay on a single libs dir.


br,
juan pablo


On Fri, Aug 10, 2012 at 8:49 AM, Florian Holeczek <fl...@holeczek.de>wrote:

> Hi Juan Pablo,
>
> haven't been looking at incubating-10 yet, but replying on 2):
>
> According to your answer in the related JIRA issue, we should return to
> the previous libs place for the ones which can't be downloaded from maven
> central. There doesn't seem to be any requirement saying that the libs
> aren't allowed in the repository; they're just not allowed in the src
> artifact, which can be achieved by excluding them from packaging.
> In build.xml, one can then for the libraries refer to the svn.tag, like
> it's done for the src checkout, too. The current solution means that there
> is no versioning in the libs directory, so it would have to stay there
> forever (i.e. as long as related releases should be buildable) and would
> probably grow over time.
> WDYT?
>
> Regarding upgrading: Fully agree! Not now, but definitely later. There are
> even some libraries which aren't maintained anymore.
>
> Regards
>  Florian
>
>
> ----- Ursprüngliche Mail -----
> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Donnerstag, 9. August 2012 22:38:40
> Betreff: Re: 3rd RC?
>
> Hi,
>
> 2.9.0-incubating-10 should run cleanly everytime, fixes the clean and
> hsqldb issues. Also, the libraries are downloaded from Central whenever is
> possible. Which leads me to a couple of questions:
>
> 1) what RC3 should be: as we haven't voted on it yet, I'd like that
> 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
> specially for Janne who is building and pushing the signed artifacts all
> along, so it would be ok for me if we vote on current RC3 tag / generated
> artifacts.
>
> 2) what to do with the jars placed at libs folder in svn: if we vote on
> current RC3 tag / artifacts, they should all remain there. If we vote on a
> tag based on 2.9.0-incubating-10, we could delete a big bunch of files. In
> any case, the jars remaining there after the release, should be there like,
> forever. As there are a few jars that aren't present on Central (i.e. jrcs,
> sandler and a few others), some jars are going to be in svn anyways.
>
> Also, there are some jars that could be downloaded from Central if we
> upgrade them to newer versions, but I think it's safer to do this later on,
> just to freeze the release..
>
> thoughts?
>
>
> rgrds,
> juan pablo
>
>
> On Mon, Aug 6, 2012 at 12:54 AM, Juan Pablo Santos Rodríguez <
> juanpablo.santos@gmail.com> wrote:
>
> > Hi,
> >
> > just added some comments there. Regarding the clean target + hsqldb
> > shutdown, I'll take a look at it this week [1], plus downloading the jars
> > from Central (whenever is possible), to avoid having a big libs folder in
> > our svn. No need to have this in the 3rd rc, but I'd like to have this
> > before graduating
> >
> >
> > br,
> > juan pablo
> >
> > [1]: the clean target should be a no-brainer, for hsqldb I was thinking
> of
> > pulling from build.xml into the appropiate setUp/tearDown methods, in
> order
> > to ensure it gets properly closed.
> >
> >
> >
> > On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <florian@holeczek.de
> >wrote:
> >
> >> Thanks Janne,
> >>
> >> true, I had already written down some notes on that before. There's
> >> pretty much to clean and simplify in our build process. But it's
> obviously
> >> been good enough until now, so that can wait till after graduation, I'd
> >> think.
> >>
> >> However, I'm wondering whether the library handling introduced in
> >> JSPWIKI-738 could lead to problems later on. I've added some notes in
> JIRA.
> >>
> >> Regards
> >>  Florian
> >>
> >>
> >> ----- Ursprüngliche Mail -----
> >> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> An: jspwiki-dev@incubator.apache.org
> >> Gesendet: Sonntag, 5. August 2012 13:20:59
> >> Betreff: Re: 3rd RC?
> >>
> >>
> >> Okay, got it building. Artifacts are now again at
> >> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >>
> >> The problem is that the ant scripts (nor ant clean) don't seem to do a
> >> proper cleanup. I don't check out a clean copy, I just svn switch my
> >> working copy around, and since ant clean doesn't really clean
> everything,
> >> old stuff is still out there.  For example, hsqldb is not properly
> >> terminated at the end of run nor by ant clean.
> >>
> >> By running "svn status" and manually removing all the files that were
> >> autogenerated I can rebuild it without problem.
> >>
> >> /Janne
> >>
> >> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:
> >>
> >> > Hi!
> >> >
> >> > done a fresh checkout from rc3 and could finish the ant clean
> signeddist
> >> > without problems
> >> >
> >> >
> >> > br,
> >> > juan pablo
> >> >
> >> >
> >> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <
> >> Janne.Jalkanen@ecyrd.com>wrote:
> >> >
> >> >>
> >> >> checked out the rc3, ant signeddist, no worky.
> >> >>
> >> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
> >> >>
> >> >>> Hi Janne,
> >> >>>
> >> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
> >> >> Windows. Both are working fine.
> >> >>>
> >> >>> Name  Status  Type    Time(s)
> >> >>> testIfPluginUserAllowed       Success         0.946
> >> >>> testIfPluginUserNotAllowed    Success         0.126
> >> >>> testIfPluginIPAllowed Success         0.083
> >> >>> testIfPluginIPNotAllowed      Success         0.115
> >> >>>
> >> >>> These tests will fail on older versions of JSPWiki (see
> JSPWIKI-737).
> >> Is
> >> >> v2.9.0-incubating-9 running in your test environment?
> >> >>>
> >> >>> Regards
> >> >>> Florian
> >> >>>
> >> >>>
> >> >>> ----- Ursprüngliche Mail -----
> >> >>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>> An: jspwiki-dev@incubator.apache.org
> >> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
> >> >>> Betreff: Re: 3rd RC?
> >> >>>
> >> >>>
> >> >>> D'oh... I'd roll a new release but I've got failing unit tests
> >> >> (IfPluginTest).
> >> >>>
> >> >>> /Janne
> >> >>>
> >> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
> >> >>>
> >> >>>> Now that's funny: What should have avoided confusion obviously led
> to
> >> >> confusion :-)
> >> >>>>
> >> >>>> Janne, these are the old artifacts!
> >> >>>>
> >> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
> >> >> tags/jspwiki_2_9_0_incubating_rc2.
> >> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> >> >>>>
> >> >>>> Regards
> >> >>>> Florian
> >> >>>>
> >> >>>>
> >> >>>> ----- Ursprüngliche Mail -----
> >> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>>> An: jspwiki-dev@incubator.apache.org
> >> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02
> >> >>>> Betreff: Re: 3rd RC?
> >> >>>>
> >> >>>>
> >> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >> >>>>
> >> >>>> /Janne
> >> >>>>
> >> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> >> >>>>
> >> >>>>> Hi!
> >> >>>>>
> >> >>>>> I've just renamed rc2 to avoid confusion.
> >> >>>>>
> >> >>>>> 2.9.0 should be real near now :-)
> >> >>>>>
> >> >>>>>
> >> >>>>> br,
> >> >>>>> juan pablo
> >> >>>>>
> >> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
> >> >> florian@holeczek.de>wrote:
> >> >>>>>
> >> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
> >> >>>>>>
> >> >>>>>> Regards
> >> >>>>>> Florian
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> ----- Ursprüngliche Mail -----
> >> >>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> >>>>>> An: jspwiki-dev@incubator.apache.org
> >> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
> >> >>>>>> Betreff: Re: 3rd RC?
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> Just tag it and I'll build it from that tag :-)
> >> >>>>>>
> >> >>>>>> /Janne
> >> >>>>>>
> >> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
> >> >>>>>>
> >> >>>>>>> Hi all,
> >> >>>>>>>
> >> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
> >> >>>>>>>
> >> >>>>>>> Regards
> >> >>>>>>> Florian
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> ----- Ursprüngliche Mail -----
> >> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> >> >>>>>>> An: jspwiki-dev@incubator.apache.org
> >> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
> >> >>>>>>> Betreff: 3rd RC?
> >> >>>>>>>
> >> >>>>>>> Hi,
> >> >>>>>>>
> >> >>>>>>> couple of days ago I was finally able to solve my problems
> >> regarding
> >> >> the
> >> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
> >> >> windows-way:
> >> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was
> >> >> feeling
> >> >>>>>> now
> >> >>>>>>> would be a good moment to push a new RC, hoping that this time
> it
> >> >> will
> >> >>>>>>> become the first ASF release. Before doing that however, I was
> >> >> thinking
> >> >>>>>> of
> >> >>>>>>> pushing a coulpe of small changes:
> >> >>>>>>>
> >> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code,
> >> this
> >> >>>>>> could
> >> >>>>>>> imply upgrading other commons-* libraries, if they do depend on
> >> >>>>>>> commons-lang and don't know if that would cause to 3rd party
> >> >> plugins, if
> >> >>>>>>> they do depend on that library. Another possibility could be
> >> simply
> >> >>>>>> upgrade
> >> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most
> >> probably
> >> >> won't
> >> >>>>>>> break anything.
> >> >>>>>>>
> >> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
> >> >> 505-530, to
> >> >>>>>>> retrieve and close Lucene indexes. Have that small change from
> >> days
> >> >> ago,
> >> >>>>>>> when I was pursuing ghosts; the functionally of the class
> remains
> >> >> exactly
> >> >>>>>>> the same, it's just a bit tinier.
> >> >>>>>>>
> >> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other
> >> thing
> >> >>>>>> before
> >> >>>>>>> making the next RC?
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> br,
> >> >>>>>>> juan pablo
> >> >>>>>>>
> >> >>>>>>> [#1]
> >> >>>>>>>
> >> >>>>>>
> >> >>
> >>
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
> >> >>>>>>
> >> >>>>>>
> >> >>
> >> >>
> >>
> >>
> >
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi!

just remembered - could you run ant clean clean-deps [signeddist|tests war]
in
the "old" workspace? just to see if it's a lib's issue..

Will take a closer look at UtilJ2eeCompatTest later today. What does say
the
trace inside the junit report?


thx!

rgrds,
juan pablo


On Sat, Aug 25, 2012 at 4:12 PM, Harry Metske <ha...@gmail.com>wrote:

> I got the same exception as Janne when I did an svn update and ran "ant
> clean tests war" in the "old" wokspace project directory.
> Running the same "ant clean tests war" in a freshly svn checked out
> directory runs fine (except UtilJ2eeCompatTest.testGlassfish() :-( ) .
> The UtilJ2eeCompatTest.testGlassfish() runs fine from eclipse, can't figure
> out why it fails with ant....
>
> kind regards,
> Harry
>
>
> 2012/8/25 Juan Pablo Santos Rodríguez <ju...@gmail.com>
>
> > Hello Janne,
> >
> > done a fresh checkout of rc3 + ant clean dist without problems.
> >
> > We look for jars in lib and /tests/lib in order to download them or not,
> > but we're not looking if there are any other jars on those directories,
> and
> > we don't delete their content in the clean target (to avoid downloading
> > them every time). If you have svn switched, maybe there're some old jars
> > there? Not real sure though, as the jars themselves haven't changed
> much, I
> > recall upgrading hsqldb and commons-lang a few days/weeks ago, but other
> > than that..
> >
> >
> > regards,
> > juan pablo
> >
> >
> > On Sat, Aug 25, 2012 at 12:41 PM, Janne Jalkanen
> > <ja...@ecyrd.com>wrote:
> >
> > >
> > > Trying to build this breaks with
> > >
> > > buildjar:
> > >     [junit] WARNING: multiple versions of ant detected in path for
> junit
> > >     [junit]
> > >
> >
>  jar:file:/opt/local/share/java/apache-ant/lib/ant.jar!/org/apache/tools/ant/Project.class
> > >     [junit]      and
> > >
> >
> jar:file:/Users/jalkanen/Eclipse/JSPWiki-svn/tests/lib/selenium-server-1.0-beta1.jar!/org/apache/tools/ant/Project.class
> > >     [junit] Running org.apache.wiki.FileUtilTest
> > >     [junit] Exception in thread "main" java.lang.NoSuchFieldError:
> > > fFeatures
> > >     [junit]     at
> > > org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
> > >     [junit]     at
> > > org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
> > >     [junit]     at
> > > sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> > >     [junit]     at
> > >
> >
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
> > >     [junit]     at
> > >
> >
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
> > >     [junit]     at
> > > java.lang.reflect.Constructor.newInstance(Constructor.java:513)
> > >     [junit]     at java.lang.Class.newInstance0(Class.java:355)
> > >     [junit]     at java.lang.Class.newInstance(Class.java:308)
> > >     [junit]     at
> > > org.apache.xerces.parsers.ObjectFactory.newInstance(Unknown Source)
> > >     [junit]     at
> > > org.apache.xerces.parsers.ObjectFactory.findJarServiceProvider(Unknown
> > > Source)
> > >     [junit]     at
> > > org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
> > >     [junit]     at
> > > org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
> > >     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> > > Source)
> > >     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> > > Source)
> > >     [junit]     at
> > > org.apache.xerces.jaxp.DocumentBuilderImpl.<init>(Unknown Source)
> > >     [junit]     at
> > >
> >
> org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(Unknown
> > > Source)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.getDocumentBuilder(XMLJUnitResultFormatter.java:60)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.startTestSuite(XMLJUnitResultFormatter.java:115)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireStartTestSuite(JUnitTestRunner.java:623)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:410)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
> > >     [junit]     at
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
> > >
> > > Quick googling suggests that this has something to do with either Ant
> or
> > > Xerces versions, but I'm a bit stymied here. Switching Xerces to 2.7.1
> > has
> > > no effect, so this is probably again an environment issue, but just to
> > > check: can others run ant tests ok?
> > >
> > > /Janne
> > >
> > > On Aug 21, 2012, at 23:12 , Juan Pablo Santos Rodríguez wrote:
> > >
> > > >
> > >
> >
> http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3
> > >
> > >
> >
>

Re: 3rd RC?

Posted by Harry Metske <ha...@gmail.com>.
I got the same exception as Janne when I did an svn update and ran "ant
clean tests war" in the "old" wokspace project directory.
Running the same "ant clean tests war" in a freshly svn checked out
directory runs fine (except UtilJ2eeCompatTest.testGlassfish() :-( ) .
The UtilJ2eeCompatTest.testGlassfish() runs fine from eclipse, can't figure
out why it fails with ant....

kind regards,
Harry


2012/8/25 Juan Pablo Santos Rodríguez <ju...@gmail.com>

> Hello Janne,
>
> done a fresh checkout of rc3 + ant clean dist without problems.
>
> We look for jars in lib and /tests/lib in order to download them or not,
> but we're not looking if there are any other jars on those directories, and
> we don't delete their content in the clean target (to avoid downloading
> them every time). If you have svn switched, maybe there're some old jars
> there? Not real sure though, as the jars themselves haven't changed much, I
> recall upgrading hsqldb and commons-lang a few days/weeks ago, but other
> than that..
>
>
> regards,
> juan pablo
>
>
> On Sat, Aug 25, 2012 at 12:41 PM, Janne Jalkanen
> <ja...@ecyrd.com>wrote:
>
> >
> > Trying to build this breaks with
> >
> > buildjar:
> >     [junit] WARNING: multiple versions of ant detected in path for junit
> >     [junit]
> >
>  jar:file:/opt/local/share/java/apache-ant/lib/ant.jar!/org/apache/tools/ant/Project.class
> >     [junit]      and
> >
> jar:file:/Users/jalkanen/Eclipse/JSPWiki-svn/tests/lib/selenium-server-1.0-beta1.jar!/org/apache/tools/ant/Project.class
> >     [junit] Running org.apache.wiki.FileUtilTest
> >     [junit] Exception in thread "main" java.lang.NoSuchFieldError:
> > fFeatures
> >     [junit]     at
> > org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
> >     [junit]     at
> > org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
> >     [junit]     at
> > sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> >     [junit]     at
> >
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
> >     [junit]     at
> >
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
> >     [junit]     at
> > java.lang.reflect.Constructor.newInstance(Constructor.java:513)
> >     [junit]     at java.lang.Class.newInstance0(Class.java:355)
> >     [junit]     at java.lang.Class.newInstance(Class.java:308)
> >     [junit]     at
> > org.apache.xerces.parsers.ObjectFactory.newInstance(Unknown Source)
> >     [junit]     at
> > org.apache.xerces.parsers.ObjectFactory.findJarServiceProvider(Unknown
> > Source)
> >     [junit]     at
> > org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
> >     [junit]     at
> > org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
> >     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> > Source)
> >     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> > Source)
> >     [junit]     at
> > org.apache.xerces.jaxp.DocumentBuilderImpl.<init>(Unknown Source)
> >     [junit]     at
> >
> org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(Unknown
> > Source)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.getDocumentBuilder(XMLJUnitResultFormatter.java:60)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.startTestSuite(XMLJUnitResultFormatter.java:115)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireStartTestSuite(JUnitTestRunner.java:623)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:410)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
> >     [junit]     at
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
> >
> > Quick googling suggests that this has something to do with either Ant or
> > Xerces versions, but I'm a bit stymied here. Switching Xerces to 2.7.1
> has
> > no effect, so this is probably again an environment issue, but just to
> > check: can others run ant tests ok?
> >
> > /Janne
> >
> > On Aug 21, 2012, at 23:12 , Juan Pablo Santos Rodríguez wrote:
> >
> > >
> >
> http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3
> >
> >
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hello Janne,

done a fresh checkout of rc3 + ant clean dist without problems.

We look for jars in lib and /tests/lib in order to download them or not,
but we're not looking if there are any other jars on those directories, and
we don't delete their content in the clean target (to avoid downloading
them every time). If you have svn switched, maybe there're some old jars
there? Not real sure though, as the jars themselves haven't changed much, I
recall upgrading hsqldb and commons-lang a few days/weeks ago, but other
than that..


regards,
juan pablo


On Sat, Aug 25, 2012 at 12:41 PM, Janne Jalkanen
<ja...@ecyrd.com>wrote:

>
> Trying to build this breaks with
>
> buildjar:
>     [junit] WARNING: multiple versions of ant detected in path for junit
>     [junit]
>  jar:file:/opt/local/share/java/apache-ant/lib/ant.jar!/org/apache/tools/ant/Project.class
>     [junit]      and
> jar:file:/Users/jalkanen/Eclipse/JSPWiki-svn/tests/lib/selenium-server-1.0-beta1.jar!/org/apache/tools/ant/Project.class
>     [junit] Running org.apache.wiki.FileUtilTest
>     [junit] Exception in thread "main" java.lang.NoSuchFieldError:
> fFeatures
>     [junit]     at
> org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
>     [junit]     at
> org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
>     [junit]     at
> sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
>     [junit]     at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
>     [junit]     at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>     [junit]     at
> java.lang.reflect.Constructor.newInstance(Constructor.java:513)
>     [junit]     at java.lang.Class.newInstance0(Class.java:355)
>     [junit]     at java.lang.Class.newInstance(Class.java:308)
>     [junit]     at
> org.apache.xerces.parsers.ObjectFactory.newInstance(Unknown Source)
>     [junit]     at
> org.apache.xerces.parsers.ObjectFactory.findJarServiceProvider(Unknown
> Source)
>     [junit]     at
> org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
>     [junit]     at
> org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
>     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> Source)
>     [junit]     at org.apache.xerces.parsers.DOMParser.<init>(Unknown
> Source)
>     [junit]     at
> org.apache.xerces.jaxp.DocumentBuilderImpl.<init>(Unknown Source)
>     [junit]     at
> org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(Unknown
> Source)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.getDocumentBuilder(XMLJUnitResultFormatter.java:60)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.startTestSuite(XMLJUnitResultFormatter.java:115)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireStartTestSuite(JUnitTestRunner.java:623)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:410)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
>     [junit]     at
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
>
> Quick googling suggests that this has something to do with either Ant or
> Xerces versions, but I'm a bit stymied here. Switching Xerces to 2.7.1 has
> no effect, so this is probably again an environment issue, but just to
> check: can others run ant tests ok?
>
> /Janne
>
> On Aug 21, 2012, at 23:12 , Juan Pablo Santos Rodríguez wrote:
>
> >
> http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3
>
>

Re: 3rd RC?

Posted by Janne Jalkanen <ja...@ecyrd.com>.
Trying to build this breaks with

buildjar:
    [junit] WARNING: multiple versions of ant detected in path for junit 
    [junit]          jar:file:/opt/local/share/java/apache-ant/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/Users/jalkanen/Eclipse/JSPWiki-svn/tests/lib/selenium-server-1.0-beta1.jar!/org/apache/tools/ant/Project.class
    [junit] Running org.apache.wiki.FileUtilTest
    [junit] Exception in thread "main" java.lang.NoSuchFieldError: fFeatures
    [junit] 	at org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.XML11Configuration.<init>(Unknown Source)
    [junit] 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    [junit] 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
    [junit] 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
    [junit] 	at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
    [junit] 	at java.lang.Class.newInstance0(Class.java:355)
    [junit] 	at java.lang.Class.newInstance(Class.java:308)
    [junit] 	at org.apache.xerces.parsers.ObjectFactory.newInstance(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.ObjectFactory.findJarServiceProvider(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.ObjectFactory.createObject(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.DOMParser.<init>(Unknown Source)
    [junit] 	at org.apache.xerces.parsers.DOMParser.<init>(Unknown Source)
    [junit] 	at org.apache.xerces.jaxp.DocumentBuilderImpl.<init>(Unknown Source)
    [junit] 	at org.apache.xerces.jaxp.DocumentBuilderFactoryImpl.newDocumentBuilder(Unknown Source)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.getDocumentBuilder(XMLJUnitResultFormatter.java:60)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.XMLJUnitResultFormatter.startTestSuite(XMLJUnitResultFormatter.java:115)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireStartTestSuite(JUnitTestRunner.java:623)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:410)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
    [junit] 	at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)

Quick googling suggests that this has something to do with either Ant or Xerces versions, but I'm a bit stymied here. Switching Xerces to 2.7.1 has no effect, so this is probably again an environment issue, but just to check: can others run ant tests ok?

/Janne

On Aug 21, 2012, at 23:12 , Juan Pablo Santos Rodríguez wrote:

> http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3


Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,

as we didn't have a vote on it, I've recreated the rc3 tag with current
trunk. So, the url for the svn tag is:
http://svn.apache.org/repos/asf/incubator/jspwiki/tags/jspwiki_2_9_0_incubating_rc3

Hopefully, this will become the 2.9.0 release :-)


regards,
juan pablo


On Tue, Aug 21, 2012 at 12:58 PM, Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:

> Hello Janne,
>
> just landed from holidays, I'll do it this afternoon :-)
>
>
> thanks & br
> juan pablo
>
>
>
> On Mon, Aug 20, 2012 at 11:32 PM, Janne Jalkanen <Janne.Jalkanen@ecyrd.com
> > wrote:
>
>> > 1) what RC3 should be: as we haven't voted on it yet, I'd like that
>> > 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
>> > specially for Janne who is building and pushing the signed artifacts all
>> > along, so it would be ok for me if we vote on current RC3 tag /
>> generated
>> > artifacts.
>>
>> To get back to this - since there are no comments, it looks like this is
>> the way to go... Juan Pablo, can you tag the right svn release and I'll
>> roll it?
>>
>> /Janne
>
>
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hello Janne,

just landed from holidays, I'll do it this afternoon :-)


thanks & br
juan pablo


On Mon, Aug 20, 2012 at 11:32 PM, Janne Jalkanen
<Ja...@ecyrd.com>wrote:

> > 1) what RC3 should be: as we haven't voted on it yet, I'd like that
> > 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
> > specially for Janne who is building and pushing the signed artifacts all
> > along, so it would be ok for me if we vote on current RC3 tag / generated
> > artifacts.
>
> To get back to this - since there are no comments, it looks like this is
> the way to go... Juan Pablo, can you tag the right svn release and I'll
> roll it?
>
> /Janne

Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
> 1) what RC3 should be: as we haven't voted on it yet, I'd like that
> 2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
> specially for Janne who is building and pushing the signed artifacts all
> along, so it would be ok for me if we vote on current RC3 tag / generated
> artifacts.

To get back to this - since there are no comments, it looks like this is the way to go... Juan Pablo, can you tag the right svn release and I'll roll it?

/Janne

Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Hi Juan Pablo,

haven't been looking at incubating-10 yet, but replying on 2):

According to your answer in the related JIRA issue, we should return to the previous libs place for the ones which can't be downloaded from maven central. There doesn't seem to be any requirement saying that the libs aren't allowed in the repository; they're just not allowed in the src artifact, which can be achieved by excluding them from packaging.
In build.xml, one can then for the libraries refer to the svn.tag, like it's done for the src checkout, too. The current solution means that there is no versioning in the libs directory, so it would have to stay there forever (i.e. as long as related releases should be buildable) and would probably grow over time.
WDYT?

Regarding upgrading: Fully agree! Not now, but definitely later. There are even some libraries which aren't maintained anymore.

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Donnerstag, 9. August 2012 22:38:40
Betreff: Re: 3rd RC?

Hi,

2.9.0-incubating-10 should run cleanly everytime, fixes the clean and
hsqldb issues. Also, the libraries are downloaded from Central whenever is
possible. Which leads me to a couple of questions:

1) what RC3 should be: as we haven't voted on it yet, I'd like that
2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
specially for Janne who is building and pushing the signed artifacts all
along, so it would be ok for me if we vote on current RC3 tag / generated
artifacts.

2) what to do with the jars placed at libs folder in svn: if we vote on
current RC3 tag / artifacts, they should all remain there. If we vote on a
tag based on 2.9.0-incubating-10, we could delete a big bunch of files. In
any case, the jars remaining there after the release, should be there like,
forever. As there are a few jars that aren't present on Central (i.e. jrcs,
sandler and a few others), some jars are going to be in svn anyways.

Also, there are some jars that could be downloaded from Central if we
upgrade them to newer versions, but I think it's safer to do this later on,
just to freeze the release..

thoughts?


rgrds,
juan pablo


On Mon, Aug 6, 2012 at 12:54 AM, Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:

> Hi,
>
> just added some comments there. Regarding the clean target + hsqldb
> shutdown, I'll take a look at it this week [1], plus downloading the jars
> from Central (whenever is possible), to avoid having a big libs folder in
> our svn. No need to have this in the 3rd rc, but I'd like to have this
> before graduating
>
>
> br,
> juan pablo
>
> [1]: the clean target should be a no-brainer, for hsqldb I was thinking of
> pulling from build.xml into the appropiate setUp/tearDown methods, in order
> to ensure it gets properly closed.
>
>
>
> On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>
>> Thanks Janne,
>>
>> true, I had already written down some notes on that before. There's
>> pretty much to clean and simplify in our build process. But it's obviously
>> been good enough until now, so that can wait till after graduation, I'd
>> think.
>>
>> However, I'm wondering whether the library handling introduced in
>> JSPWIKI-738 could lead to problems later on. I've added some notes in JIRA.
>>
>> Regards
>>  Florian
>>
>>
>> ----- Ursprüngliche Mail -----
>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> An: jspwiki-dev@incubator.apache.org
>> Gesendet: Sonntag, 5. August 2012 13:20:59
>> Betreff: Re: 3rd RC?
>>
>>
>> Okay, got it building. Artifacts are now again at
>> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>>
>> The problem is that the ant scripts (nor ant clean) don't seem to do a
>> proper cleanup. I don't check out a clean copy, I just svn switch my
>> working copy around, and since ant clean doesn't really clean everything,
>> old stuff is still out there.  For example, hsqldb is not properly
>> terminated at the end of run nor by ant clean.
>>
>> By running "svn status" and manually removing all the files that were
>> autogenerated I can rebuild it without problem.
>>
>> /Janne
>>
>> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:
>>
>> > Hi!
>> >
>> > done a fresh checkout from rc3 and could finish the ant clean signeddist
>> > without problems
>> >
>> >
>> > br,
>> > juan pablo
>> >
>> >
>> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <
>> Janne.Jalkanen@ecyrd.com>wrote:
>> >
>> >>
>> >> checked out the rc3, ant signeddist, no worky.
>> >>
>> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
>> >>
>> >>> Hi Janne,
>> >>>
>> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
>> >> Windows. Both are working fine.
>> >>>
>> >>> Name  Status  Type    Time(s)
>> >>> testIfPluginUserAllowed       Success         0.946
>> >>> testIfPluginUserNotAllowed    Success         0.126
>> >>> testIfPluginIPAllowed Success         0.083
>> >>> testIfPluginIPNotAllowed      Success         0.115
>> >>>
>> >>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737).
>> Is
>> >> v2.9.0-incubating-9 running in your test environment?
>> >>>
>> >>> Regards
>> >>> Florian
>> >>>
>> >>>
>> >>> ----- Ursprüngliche Mail -----
>> >>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>> An: jspwiki-dev@incubator.apache.org
>> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
>> >>> Betreff: Re: 3rd RC?
>> >>>
>> >>>
>> >>> D'oh... I'd roll a new release but I've got failing unit tests
>> >> (IfPluginTest).
>> >>>
>> >>> /Janne
>> >>>
>> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
>> >>>
>> >>>> Now that's funny: What should have avoided confusion obviously led to
>> >> confusion :-)
>> >>>>
>> >>>> Janne, these are the old artifacts!
>> >>>>
>> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
>> >> tags/jspwiki_2_9_0_incubating_rc2.
>> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
>> >>>>
>> >>>> Regards
>> >>>> Florian
>> >>>>
>> >>>>
>> >>>> ----- Ursprüngliche Mail -----
>> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>>> An: jspwiki-dev@incubator.apache.org
>> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02
>> >>>> Betreff: Re: 3rd RC?
>> >>>>
>> >>>>
>> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>> >>>>
>> >>>> /Janne
>> >>>>
>> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
>> >>>>
>> >>>>> Hi!
>> >>>>>
>> >>>>> I've just renamed rc2 to avoid confusion.
>> >>>>>
>> >>>>> 2.9.0 should be real near now :-)
>> >>>>>
>> >>>>>
>> >>>>> br,
>> >>>>> juan pablo
>> >>>>>
>> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
>> >> florian@holeczek.de>wrote:
>> >>>>>
>> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>> >>>>>>
>> >>>>>> Regards
>> >>>>>> Florian
>> >>>>>>
>> >>>>>>
>> >>>>>> ----- Ursprüngliche Mail -----
>> >>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>>>>> An: jspwiki-dev@incubator.apache.org
>> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>> >>>>>> Betreff: Re: 3rd RC?
>> >>>>>>
>> >>>>>>
>> >>>>>> Just tag it and I'll build it from that tag :-)
>> >>>>>>
>> >>>>>> /Janne
>> >>>>>>
>> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>> >>>>>>
>> >>>>>>> Hi all,
>> >>>>>>>
>> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>> >>>>>>>
>> >>>>>>> Regards
>> >>>>>>> Florian
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> ----- Ursprüngliche Mail -----
>> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>> >>>>>>> An: jspwiki-dev@incubator.apache.org
>> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>> >>>>>>> Betreff: 3rd RC?
>> >>>>>>>
>> >>>>>>> Hi,
>> >>>>>>>
>> >>>>>>> couple of days ago I was finally able to solve my problems
>> regarding
>> >> the
>> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
>> >> windows-way:
>> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was
>> >> feeling
>> >>>>>> now
>> >>>>>>> would be a good moment to push a new RC, hoping that this time it
>> >> will
>> >>>>>>> become the first ASF release. Before doing that however, I was
>> >> thinking
>> >>>>>> of
>> >>>>>>> pushing a coulpe of small changes:
>> >>>>>>>
>> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code,
>> this
>> >>>>>> could
>> >>>>>>> imply upgrading other commons-* libraries, if they do depend on
>> >>>>>>> commons-lang and don't know if that would cause to 3rd party
>> >> plugins, if
>> >>>>>>> they do depend on that library. Another possibility could be
>> simply
>> >>>>>> upgrade
>> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most
>> probably
>> >> won't
>> >>>>>>> break anything.
>> >>>>>>>
>> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
>> >> 505-530, to
>> >>>>>>> retrieve and close Lucene indexes. Have that small change from
>> days
>> >> ago,
>> >>>>>>> when I was pursuing ghosts; the functionally of the class remains
>> >> exactly
>> >>>>>>> the same, it's just a bit tinier.
>> >>>>>>>
>> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other
>> thing
>> >>>>>> before
>> >>>>>>> making the next RC?
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> br,
>> >>>>>>> juan pablo
>> >>>>>>>
>> >>>>>>> [#1]
>> >>>>>>>
>> >>>>>>
>> >>
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>> >>>>>>
>> >>>>>>
>> >>
>> >>
>>
>>
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,

2.9.0-incubating-10 should run cleanly everytime, fixes the clean and
hsqldb issues. Also, the libraries are downloaded from Central whenever is
possible. Which leads me to a couple of questions:

1) what RC3 should be: as we haven't voted on it yet, I'd like that
2.9.0-incubating-10 would become to RC3/2.9.0-final. I know is a PITA,
specially for Janne who is building and pushing the signed artifacts all
along, so it would be ok for me if we vote on current RC3 tag / generated
artifacts.

2) what to do with the jars placed at libs folder in svn: if we vote on
current RC3 tag / artifacts, they should all remain there. If we vote on a
tag based on 2.9.0-incubating-10, we could delete a big bunch of files. In
any case, the jars remaining there after the release, should be there like,
forever. As there are a few jars that aren't present on Central (i.e. jrcs,
sandler and a few others), some jars are going to be in svn anyways.

Also, there are some jars that could be downloaded from Central if we
upgrade them to newer versions, but I think it's safer to do this later on,
just to freeze the release..

thoughts?


rgrds,
juan pablo


On Mon, Aug 6, 2012 at 12:54 AM, Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:

> Hi,
>
> just added some comments there. Regarding the clean target + hsqldb
> shutdown, I'll take a look at it this week [1], plus downloading the jars
> from Central (whenever is possible), to avoid having a big libs folder in
> our svn. No need to have this in the 3rd rc, but I'd like to have this
> before graduating
>
>
> br,
> juan pablo
>
> [1]: the clean target should be a no-brainer, for hsqldb I was thinking of
> pulling from build.xml into the appropiate setUp/tearDown methods, in order
> to ensure it gets properly closed.
>
>
>
> On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>
>> Thanks Janne,
>>
>> true, I had already written down some notes on that before. There's
>> pretty much to clean and simplify in our build process. But it's obviously
>> been good enough until now, so that can wait till after graduation, I'd
>> think.
>>
>> However, I'm wondering whether the library handling introduced in
>> JSPWIKI-738 could lead to problems later on. I've added some notes in JIRA.
>>
>> Regards
>>  Florian
>>
>>
>> ----- Ursprüngliche Mail -----
>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> An: jspwiki-dev@incubator.apache.org
>> Gesendet: Sonntag, 5. August 2012 13:20:59
>> Betreff: Re: 3rd RC?
>>
>>
>> Okay, got it building. Artifacts are now again at
>> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>>
>> The problem is that the ant scripts (nor ant clean) don't seem to do a
>> proper cleanup. I don't check out a clean copy, I just svn switch my
>> working copy around, and since ant clean doesn't really clean everything,
>> old stuff is still out there.  For example, hsqldb is not properly
>> terminated at the end of run nor by ant clean.
>>
>> By running "svn status" and manually removing all the files that were
>> autogenerated I can rebuild it without problem.
>>
>> /Janne
>>
>> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:
>>
>> > Hi!
>> >
>> > done a fresh checkout from rc3 and could finish the ant clean signeddist
>> > without problems
>> >
>> >
>> > br,
>> > juan pablo
>> >
>> >
>> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <
>> Janne.Jalkanen@ecyrd.com>wrote:
>> >
>> >>
>> >> checked out the rc3, ant signeddist, no worky.
>> >>
>> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
>> >>
>> >>> Hi Janne,
>> >>>
>> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
>> >> Windows. Both are working fine.
>> >>>
>> >>> Name  Status  Type    Time(s)
>> >>> testIfPluginUserAllowed       Success         0.946
>> >>> testIfPluginUserNotAllowed    Success         0.126
>> >>> testIfPluginIPAllowed Success         0.083
>> >>> testIfPluginIPNotAllowed      Success         0.115
>> >>>
>> >>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737).
>> Is
>> >> v2.9.0-incubating-9 running in your test environment?
>> >>>
>> >>> Regards
>> >>> Florian
>> >>>
>> >>>
>> >>> ----- Ursprüngliche Mail -----
>> >>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>> An: jspwiki-dev@incubator.apache.org
>> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
>> >>> Betreff: Re: 3rd RC?
>> >>>
>> >>>
>> >>> D'oh... I'd roll a new release but I've got failing unit tests
>> >> (IfPluginTest).
>> >>>
>> >>> /Janne
>> >>>
>> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
>> >>>
>> >>>> Now that's funny: What should have avoided confusion obviously led to
>> >> confusion :-)
>> >>>>
>> >>>> Janne, these are the old artifacts!
>> >>>>
>> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
>> >> tags/jspwiki_2_9_0_incubating_rc2.
>> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
>> >>>>
>> >>>> Regards
>> >>>> Florian
>> >>>>
>> >>>>
>> >>>> ----- Ursprüngliche Mail -----
>> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>>> An: jspwiki-dev@incubator.apache.org
>> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02
>> >>>> Betreff: Re: 3rd RC?
>> >>>>
>> >>>>
>> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>> >>>>
>> >>>> /Janne
>> >>>>
>> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
>> >>>>
>> >>>>> Hi!
>> >>>>>
>> >>>>> I've just renamed rc2 to avoid confusion.
>> >>>>>
>> >>>>> 2.9.0 should be real near now :-)
>> >>>>>
>> >>>>>
>> >>>>> br,
>> >>>>> juan pablo
>> >>>>>
>> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
>> >> florian@holeczek.de>wrote:
>> >>>>>
>> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>> >>>>>>
>> >>>>>> Regards
>> >>>>>> Florian
>> >>>>>>
>> >>>>>>
>> >>>>>> ----- Ursprüngliche Mail -----
>> >>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> >>>>>> An: jspwiki-dev@incubator.apache.org
>> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>> >>>>>> Betreff: Re: 3rd RC?
>> >>>>>>
>> >>>>>>
>> >>>>>> Just tag it and I'll build it from that tag :-)
>> >>>>>>
>> >>>>>> /Janne
>> >>>>>>
>> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>> >>>>>>
>> >>>>>>> Hi all,
>> >>>>>>>
>> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>> >>>>>>>
>> >>>>>>> Regards
>> >>>>>>> Florian
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> ----- Ursprüngliche Mail -----
>> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>> >>>>>>> An: jspwiki-dev@incubator.apache.org
>> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>> >>>>>>> Betreff: 3rd RC?
>> >>>>>>>
>> >>>>>>> Hi,
>> >>>>>>>
>> >>>>>>> couple of days ago I was finally able to solve my problems
>> regarding
>> >> the
>> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
>> >> windows-way:
>> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was
>> >> feeling
>> >>>>>> now
>> >>>>>>> would be a good moment to push a new RC, hoping that this time it
>> >> will
>> >>>>>>> become the first ASF release. Before doing that however, I was
>> >> thinking
>> >>>>>> of
>> >>>>>>> pushing a coulpe of small changes:
>> >>>>>>>
>> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code,
>> this
>> >>>>>> could
>> >>>>>>> imply upgrading other commons-* libraries, if they do depend on
>> >>>>>>> commons-lang and don't know if that would cause to 3rd party
>> >> plugins, if
>> >>>>>>> they do depend on that library. Another possibility could be
>> simply
>> >>>>>> upgrade
>> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most
>> probably
>> >> won't
>> >>>>>>> break anything.
>> >>>>>>>
>> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
>> >> 505-530, to
>> >>>>>>> retrieve and close Lucene indexes. Have that small change from
>> days
>> >> ago,
>> >>>>>>> when I was pursuing ghosts; the functionally of the class remains
>> >> exactly
>> >>>>>>> the same, it's just a bit tinier.
>> >>>>>>>
>> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other
>> thing
>> >>>>>> before
>> >>>>>>> making the next RC?
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> br,
>> >>>>>>> juan pablo
>> >>>>>>>
>> >>>>>>> [#1]
>> >>>>>>>
>> >>>>>>
>> >>
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>> >>>>>>
>> >>>>>>
>> >>
>> >>
>>
>>
>

Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,

just added some comments there. Regarding the clean target + hsqldb
shutdown, I'll take a look at it this week [1], plus downloading the jars
from Central (whenever is possible), to avoid having a big libs folder in
our svn. No need to have this in the 3rd rc, but I'd like to have this
before graduating


br,
juan pablo

[1]: the clean target should be a no-brainer, for hsqldb I was thinking of
pulling from build.xml into the appropiate setUp/tearDown methods, in order
to ensure it gets properly closed.


On Sun, Aug 5, 2012 at 11:09 PM, Florian Holeczek <fl...@holeczek.de>wrote:

> Thanks Janne,
>
> true, I had already written down some notes on that before. There's pretty
> much to clean and simplify in our build process. But it's obviously been
> good enough until now, so that can wait till after graduation, I'd think.
>
> However, I'm wondering whether the library handling introduced in
> JSPWIKI-738 could lead to problems later on. I've added some notes in JIRA.
>
> Regards
>  Florian
>
>
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Sonntag, 5. August 2012 13:20:59
> Betreff: Re: 3rd RC?
>
>
> Okay, got it building. Artifacts are now again at
> http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>
> The problem is that the ant scripts (nor ant clean) don't seem to do a
> proper cleanup. I don't check out a clean copy, I just svn switch my
> working copy around, and since ant clean doesn't really clean everything,
> old stuff is still out there.  For example, hsqldb is not properly
> terminated at the end of run nor by ant clean.
>
> By running "svn status" and manually removing all the files that were
> autogenerated I can rebuild it without problem.
>
> /Janne
>
> On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:
>
> > Hi!
> >
> > done a fresh checkout from rc3 and could finish the ant clean signeddist
> > without problems
> >
> >
> > br,
> > juan pablo
> >
> >
> > On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <
> Janne.Jalkanen@ecyrd.com>wrote:
> >
> >>
> >> checked out the rc3, ant signeddist, no worky.
> >>
> >> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
> >>
> >>> Hi Janne,
> >>>
> >>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
> >> Windows. Both are working fine.
> >>>
> >>> Name  Status  Type    Time(s)
> >>> testIfPluginUserAllowed       Success         0.946
> >>> testIfPluginUserNotAllowed    Success         0.126
> >>> testIfPluginIPAllowed Success         0.083
> >>> testIfPluginIPNotAllowed      Success         0.115
> >>>
> >>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737).
> Is
> >> v2.9.0-incubating-9 running in your test environment?
> >>>
> >>> Regards
> >>> Florian
> >>>
> >>>
> >>> ----- Ursprüngliche Mail -----
> >>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >>> An: jspwiki-dev@incubator.apache.org
> >>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
> >>> Betreff: Re: 3rd RC?
> >>>
> >>>
> >>> D'oh... I'd roll a new release but I've got failing unit tests
> >> (IfPluginTest).
> >>>
> >>> /Janne
> >>>
> >>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
> >>>
> >>>> Now that's funny: What should have avoided confusion obviously led to
> >> confusion :-)
> >>>>
> >>>> Janne, these are the old artifacts!
> >>>>
> >>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
> >> tags/jspwiki_2_9_0_incubating_rc2.
> >>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> >>>>
> >>>> Regards
> >>>> Florian
> >>>>
> >>>>
> >>>> ----- Ursprüngliche Mail -----
> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >>>> An: jspwiki-dev@incubator.apache.org
> >>>> Gesendet: Montag, 23. Juli 2012 21:32:02
> >>>> Betreff: Re: 3rd RC?
> >>>>
> >>>>
> >>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >>>>
> >>>> /Janne
> >>>>
> >>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> >>>>
> >>>>> Hi!
> >>>>>
> >>>>> I've just renamed rc2 to avoid confusion.
> >>>>>
> >>>>> 2.9.0 should be real near now :-)
> >>>>>
> >>>>>
> >>>>> br,
> >>>>> juan pablo
> >>>>>
> >>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
> >> florian@holeczek.de>wrote:
> >>>>>
> >>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
> >>>>>>
> >>>>>> Regards
> >>>>>> Florian
> >>>>>>
> >>>>>>
> >>>>>> ----- Ursprüngliche Mail -----
> >>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >>>>>> An: jspwiki-dev@incubator.apache.org
> >>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
> >>>>>> Betreff: Re: 3rd RC?
> >>>>>>
> >>>>>>
> >>>>>> Just tag it and I'll build it from that tag :-)
> >>>>>>
> >>>>>> /Janne
> >>>>>>
> >>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
> >>>>>>
> >>>>>>> Hi all,
> >>>>>>>
> >>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
> >>>>>>>
> >>>>>>> Regards
> >>>>>>> Florian
> >>>>>>>
> >>>>>>>
> >>>>>>> ----- Ursprüngliche Mail -----
> >>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> >>>>>>> An: jspwiki-dev@incubator.apache.org
> >>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
> >>>>>>> Betreff: 3rd RC?
> >>>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> couple of days ago I was finally able to solve my problems
> regarding
> >> the
> >>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
> >> windows-way:
> >>>>>>> rebooting (computer at home is up 99% of the time..). So I was
> >> feeling
> >>>>>> now
> >>>>>>> would be a good moment to push a new RC, hoping that this time it
> >> will
> >>>>>>> become the first ASF release. Before doing that however, I was
> >> thinking
> >>>>>> of
> >>>>>>> pushing a coulpe of small changes:
> >>>>>>>
> >>>>>>> - upgrading commons-lang to commons-lang3: aside from the code,
> this
> >>>>>> could
> >>>>>>> imply upgrading other commons-* libraries, if they do depend on
> >>>>>>> commons-lang and don't know if that would cause to 3rd party
> >> plugins, if
> >>>>>>> they do depend on that library. Another possibility could be simply
> >>>>>> upgrade
> >>>>>>> commons-lang to 2.6, which is the latest from 2.x and most probably
> >> won't
> >>>>>>> break anything.
> >>>>>>>
> >>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
> >> 505-530, to
> >>>>>>> retrieve and close Lucene indexes. Have that small change from days
> >> ago,
> >>>>>>> when I was pursuing ghosts; the functionally of the class remains
> >> exactly
> >>>>>>> the same, it's just a bit tinier.
> >>>>>>>
> >>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other
> thing
> >>>>>> before
> >>>>>>> making the next RC?
> >>>>>>>
> >>>>>>>
> >>>>>>> br,
> >>>>>>> juan pablo
> >>>>>>>
> >>>>>>> [#1]
> >>>>>>>
> >>>>>>
> >>
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
> >>>>>>
> >>>>>>
> >>
> >>
>
>

Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Thanks Janne,

true, I had already written down some notes on that before. There's pretty much to clean and simplify in our build process. But it's obviously been good enough until now, so that can wait till after graduation, I'd think.

However, I'm wondering whether the library handling introduced in JSPWIKI-738 could lead to problems later on. I've added some notes in JIRA.

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Janne Jalkanen" <Ja...@ecyrd.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Sonntag, 5. August 2012 13:20:59
Betreff: Re: 3rd RC?


Okay, got it building. Artifacts are now again at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/

The problem is that the ant scripts (nor ant clean) don't seem to do a proper cleanup. I don't check out a clean copy, I just svn switch my working copy around, and since ant clean doesn't really clean everything, old stuff is still out there.  For example, hsqldb is not properly terminated at the end of run nor by ant clean.

By running "svn status" and manually removing all the files that were autogenerated I can rebuild it without problem.

/Janne

On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:

> Hi!
> 
> done a fresh checkout from rc3 and could finish the ant clean signeddist
> without problems
> 
> 
> br,
> juan pablo
> 
> 
> On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <Ja...@ecyrd.com>wrote:
> 
>> 
>> checked out the rc3, ant signeddist, no worky.
>> 
>> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
>> 
>>> Hi Janne,
>>> 
>>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
>> Windows. Both are working fine.
>>> 
>>> Name  Status  Type    Time(s)
>>> testIfPluginUserAllowed       Success         0.946
>>> testIfPluginUserNotAllowed    Success         0.126
>>> testIfPluginIPAllowed Success         0.083
>>> testIfPluginIPNotAllowed      Success         0.115
>>> 
>>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737). Is
>> v2.9.0-incubating-9 running in your test environment?
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
>>> Betreff: Re: 3rd RC?
>>> 
>>> 
>>> D'oh... I'd roll a new release but I've got failing unit tests
>> (IfPluginTest).
>>> 
>>> /Janne
>>> 
>>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
>>> 
>>>> Now that's funny: What should have avoided confusion obviously led to
>> confusion :-)
>>>> 
>>>> Janne, these are the old artifacts!
>>>> 
>>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
>> tags/jspwiki_2_9_0_incubating_rc2.
>>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Montag, 23. Juli 2012 21:32:02
>>>> Betreff: Re: 3rd RC?
>>>> 
>>>> 
>>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>>>> 
>>>> /Janne
>>>> 
>>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
>>>> 
>>>>> Hi!
>>>>> 
>>>>> I've just renamed rc2 to avoid confusion.
>>>>> 
>>>>> 2.9.0 should be real near now :-)
>>>>> 
>>>>> 
>>>>> br,
>>>>> juan pablo
>>>>> 
>>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
>> florian@holeczek.de>wrote:
>>>>> 
>>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>>>>> 
>>>>>> Regards
>>>>>> Florian
>>>>>> 
>>>>>> 
>>>>>> ----- Ursprüngliche Mail -----
>>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>>>>> An: jspwiki-dev@incubator.apache.org
>>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>>>>> Betreff: Re: 3rd RC?
>>>>>> 
>>>>>> 
>>>>>> Just tag it and I'll build it from that tag :-)
>>>>>> 
>>>>>> /Janne
>>>>>> 
>>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>>>>> 
>>>>>>> Regards
>>>>>>> Florian
>>>>>>> 
>>>>>>> 
>>>>>>> ----- Ursprüngliche Mail -----
>>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>>>>> An: jspwiki-dev@incubator.apache.org
>>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>>>>> Betreff: 3rd RC?
>>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> couple of days ago I was finally able to solve my problems regarding
>> the
>>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
>> windows-way:
>>>>>>> rebooting (computer at home is up 99% of the time..). So I was
>> feeling
>>>>>> now
>>>>>>> would be a good moment to push a new RC, hoping that this time it
>> will
>>>>>>> become the first ASF release. Before doing that however, I was
>> thinking
>>>>>> of
>>>>>>> pushing a coulpe of small changes:
>>>>>>> 
>>>>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>>>>> could
>>>>>>> imply upgrading other commons-* libraries, if they do depend on
>>>>>>> commons-lang and don't know if that would cause to 3rd party
>> plugins, if
>>>>>>> they do depend on that library. Another possibility could be simply
>>>>>> upgrade
>>>>>>> commons-lang to 2.6, which is the latest from 2.x and most probably
>> won't
>>>>>>> break anything.
>>>>>>> 
>>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
>> 505-530, to
>>>>>>> retrieve and close Lucene indexes. Have that small change from days
>> ago,
>>>>>>> when I was pursuing ghosts; the functionally of the class remains
>> exactly
>>>>>>> the same, it's just a bit tinier.
>>>>>>> 
>>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>>>>> before
>>>>>>> making the next RC?
>>>>>>> 
>>>>>>> 
>>>>>>> br,
>>>>>>> juan pablo
>>>>>>> 
>>>>>>> [#1]
>>>>>>> 
>>>>>> 
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>>>>> 
>>>>>> 
>> 
>> 


Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Okay, got it building. Artifacts are now again at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/

The problem is that the ant scripts (nor ant clean) don't seem to do a proper cleanup. I don't check out a clean copy, I just svn switch my working copy around, and since ant clean doesn't really clean everything, old stuff is still out there.  For example, hsqldb is not properly terminated at the end of run nor by ant clean.

By running "svn status" and manually removing all the files that were autogenerated I can rebuild it without problem.

/Janne

On Jul 29, 2012, at 23:47 , Juan Pablo Santos Rodríguez wrote:

> Hi!
> 
> done a fresh checkout from rc3 and could finish the ant clean signeddist
> without problems
> 
> 
> br,
> juan pablo
> 
> 
> On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <Ja...@ecyrd.com>wrote:
> 
>> 
>> checked out the rc3, ant signeddist, no worky.
>> 
>> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
>> 
>>> Hi Janne,
>>> 
>>> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
>> Windows. Both are working fine.
>>> 
>>> Name  Status  Type    Time(s)
>>> testIfPluginUserAllowed       Success         0.946
>>> testIfPluginUserNotAllowed    Success         0.126
>>> testIfPluginIPAllowed Success         0.083
>>> testIfPluginIPNotAllowed      Success         0.115
>>> 
>>> These tests will fail on older versions of JSPWiki (see JSPWIKI-737). Is
>> v2.9.0-incubating-9 running in your test environment?
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
>>> Betreff: Re: 3rd RC?
>>> 
>>> 
>>> D'oh... I'd roll a new release but I've got failing unit tests
>> (IfPluginTest).
>>> 
>>> /Janne
>>> 
>>> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
>>> 
>>>> Now that's funny: What should have avoided confusion obviously led to
>> confusion :-)
>>>> 
>>>> Janne, these are the old artifacts!
>>>> 
>>>> Juan Pablo renamed tags/jspwiki_2_9_0 to
>> tags/jspwiki_2_9_0_incubating_rc2.
>>>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Montag, 23. Juli 2012 21:32:02
>>>> Betreff: Re: 3rd RC?
>>>> 
>>>> 
>>>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>>>> 
>>>> /Janne
>>>> 
>>>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
>>>> 
>>>>> Hi!
>>>>> 
>>>>> I've just renamed rc2 to avoid confusion.
>>>>> 
>>>>> 2.9.0 should be real near now :-)
>>>>> 
>>>>> 
>>>>> br,
>>>>> juan pablo
>>>>> 
>>>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
>> florian@holeczek.de>wrote:
>>>>> 
>>>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>>>>> 
>>>>>> Regards
>>>>>> Florian
>>>>>> 
>>>>>> 
>>>>>> ----- Ursprüngliche Mail -----
>>>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>>>>> An: jspwiki-dev@incubator.apache.org
>>>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>>>>> Betreff: Re: 3rd RC?
>>>>>> 
>>>>>> 
>>>>>> Just tag it and I'll build it from that tag :-)
>>>>>> 
>>>>>> /Janne
>>>>>> 
>>>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>>>>> 
>>>>>>> Hi all,
>>>>>>> 
>>>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>>>>> 
>>>>>>> Regards
>>>>>>> Florian
>>>>>>> 
>>>>>>> 
>>>>>>> ----- Ursprüngliche Mail -----
>>>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>>>>> An: jspwiki-dev@incubator.apache.org
>>>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>>>>> Betreff: 3rd RC?
>>>>>>> 
>>>>>>> Hi,
>>>>>>> 
>>>>>>> couple of days ago I was finally able to solve my problems regarding
>> the
>>>>>>> Lucene exceptions, as sad as it looks, in the most ancient
>> windows-way:
>>>>>>> rebooting (computer at home is up 99% of the time..). So I was
>> feeling
>>>>>> now
>>>>>>> would be a good moment to push a new RC, hoping that this time it
>> will
>>>>>>> become the first ASF release. Before doing that however, I was
>> thinking
>>>>>> of
>>>>>>> pushing a coulpe of small changes:
>>>>>>> 
>>>>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>>>>> could
>>>>>>> imply upgrading other commons-* libraries, if they do depend on
>>>>>>> commons-lang and don't know if that would cause to 3rd party
>> plugins, if
>>>>>>> they do depend on that library. Another possibility could be simply
>>>>>> upgrade
>>>>>>> commons-lang to 2.6, which is the latest from 2.x and most probably
>> won't
>>>>>>> break anything.
>>>>>>> 
>>>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
>> 505-530, to
>>>>>>> retrieve and close Lucene indexes. Have that small change from days
>> ago,
>>>>>>> when I was pursuing ghosts; the functionally of the class remains
>> exactly
>>>>>>> the same, it's just a bit tinier.
>>>>>>> 
>>>>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>>>>> before
>>>>>>> making the next RC?
>>>>>>> 
>>>>>>> 
>>>>>>> br,
>>>>>>> juan pablo
>>>>>>> 
>>>>>>> [#1]
>>>>>>> 
>>>>>> 
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>>>>> 
>>>>>> 
>> 
>> 


Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi!

done a fresh checkout from rc3 and could finish the ant clean signeddist
without problems


br,
juan pablo


On Thu, Jul 26, 2012 at 9:47 AM, Janne Jalkanen <Ja...@ecyrd.com>wrote:

>
> checked out the rc3, ant signeddist, no worky.
>
> On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:
>
> > Hi Janne,
> >
> > just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on
> Windows. Both are working fine.
> >
> > Name  Status  Type    Time(s)
> > testIfPluginUserAllowed       Success         0.946
> > testIfPluginUserNotAllowed    Success         0.126
> > testIfPluginIPAllowed Success         0.083
> > testIfPluginIPNotAllowed      Success         0.115
> >
> > These tests will fail on older versions of JSPWiki (see JSPWIKI-737). Is
> v2.9.0-incubating-9 running in your test environment?
> >
> > Regards
> > Florian
> >
> >
> > ----- Ursprüngliche Mail -----
> > Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> > An: jspwiki-dev@incubator.apache.org
> > Gesendet: Mittwoch, 25. Juli 2012 21:15:11
> > Betreff: Re: 3rd RC?
> >
> >
> > D'oh... I'd roll a new release but I've got failing unit tests
> (IfPluginTest).
> >
> > /Janne
> >
> > On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
> >
> >> Now that's funny: What should have avoided confusion obviously led to
> confusion :-)
> >>
> >> Janne, these are the old artifacts!
> >>
> >> Juan Pablo renamed tags/jspwiki_2_9_0 to
> tags/jspwiki_2_9_0_incubating_rc2.
> >> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> >>
> >> Regards
> >> Florian
> >>
> >>
> >> ----- Ursprüngliche Mail -----
> >> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >> An: jspwiki-dev@incubator.apache.org
> >> Gesendet: Montag, 23. Juli 2012 21:32:02
> >> Betreff: Re: 3rd RC?
> >>
> >>
> >> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> >>
> >> /Janne
> >>
> >> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> >>
> >>> Hi!
> >>>
> >>> I've just renamed rc2 to avoid confusion.
> >>>
> >>> 2.9.0 should be real near now :-)
> >>>
> >>>
> >>> br,
> >>> juan pablo
> >>>
> >>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <
> florian@holeczek.de>wrote:
> >>>
> >>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
> >>>>
> >>>> Regards
> >>>> Florian
> >>>>
> >>>>
> >>>> ----- Ursprüngliche Mail -----
> >>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> >>>> An: jspwiki-dev@incubator.apache.org
> >>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
> >>>> Betreff: Re: 3rd RC?
> >>>>
> >>>>
> >>>> Just tag it and I'll build it from that tag :-)
> >>>>
> >>>> /Janne
> >>>>
> >>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
> >>>>
> >>>>> Hi all,
> >>>>>
> >>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
> >>>>>
> >>>>> Regards
> >>>>> Florian
> >>>>>
> >>>>>
> >>>>> ----- Ursprüngliche Mail -----
> >>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> >>>>> An: jspwiki-dev@incubator.apache.org
> >>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
> >>>>> Betreff: 3rd RC?
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> couple of days ago I was finally able to solve my problems regarding
> the
> >>>>> Lucene exceptions, as sad as it looks, in the most ancient
> windows-way:
> >>>>> rebooting (computer at home is up 99% of the time..). So I was
> feeling
> >>>> now
> >>>>> would be a good moment to push a new RC, hoping that this time it
> will
> >>>>> become the first ASF release. Before doing that however, I was
> thinking
> >>>> of
> >>>>> pushing a coulpe of small changes:
> >>>>>
> >>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
> >>>> could
> >>>>> imply upgrading other commons-* libraries, if they do depend on
> >>>>> commons-lang and don't know if that would cause to 3rd party
> plugins, if
> >>>>> they do depend on that library. Another possibility could be simply
> >>>> upgrade
> >>>>> commons-lang to 2.6, which is the latest from 2.x and most probably
> won't
> >>>>> break anything.
> >>>>>
> >>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines
> 505-530, to
> >>>>> retrieve and close Lucene indexes. Have that small change from days
> ago,
> >>>>> when I was pursuing ghosts; the functionally of the class remains
> exactly
> >>>>> the same, it's just a bit tinier.
> >>>>>
> >>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
> >>>> before
> >>>>> making the next RC?
> >>>>>
> >>>>>
> >>>>> br,
> >>>>> juan pablo
> >>>>>
> >>>>> [#1]
> >>>>>
> >>>>
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
> >>>>
> >>>>
>
>

Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
checked out the rc3, ant signeddist, no worky.

On Jul 26, 2012, at 00:42 , Florian Holeczek wrote:

> Hi Janne,
> 
> just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on Windows. Both are working fine.
> 
> Name	Status	Type	Time(s)
> testIfPluginUserAllowed	Success		0.946
> testIfPluginUserNotAllowed	Success		0.126
> testIfPluginIPAllowed	Success		0.083
> testIfPluginIPNotAllowed	Success		0.115
> 
> These tests will fail on older versions of JSPWiki (see JSPWIKI-737). Is v2.9.0-incubating-9 running in your test environment?
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Mittwoch, 25. Juli 2012 21:15:11
> Betreff: Re: 3rd RC?
> 
> 
> D'oh... I'd roll a new release but I've got failing unit tests (IfPluginTest).
> 
> /Janne
> 
> On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:
> 
>> Now that's funny: What should have avoided confusion obviously led to confusion :-)
>> 
>> Janne, these are the old artifacts!
>> 
>> Juan Pablo renamed tags/jspwiki_2_9_0 to tags/jspwiki_2_9_0_incubating_rc2.
>> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
>> 
>> Regards
>> Florian
>> 
>> 
>> ----- Ursprüngliche Mail -----
>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> An: jspwiki-dev@incubator.apache.org
>> Gesendet: Montag, 23. Juli 2012 21:32:02
>> Betreff: Re: 3rd RC?
>> 
>> 
>> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
>> 
>> /Janne
>> 
>> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
>> 
>>> Hi!
>>> 
>>> I've just renamed rc2 to avoid confusion.
>>> 
>>> 2.9.0 should be real near now :-)
>>> 
>>> 
>>> br,
>>> juan pablo
>>> 
>>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>>> 
>>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>>> Betreff: Re: 3rd RC?
>>>> 
>>>> 
>>>> Just tag it and I'll build it from that tag :-)
>>>> 
>>>> /Janne
>>>> 
>>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>>> 
>>>>> Hi all,
>>>>> 
>>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>>> 
>>>>> Regards
>>>>> Florian
>>>>> 
>>>>> 
>>>>> ----- Ursprüngliche Mail -----
>>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>>> An: jspwiki-dev@incubator.apache.org
>>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>>> Betreff: 3rd RC?
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> couple of days ago I was finally able to solve my problems regarding the
>>>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>>>> now
>>>>> would be a good moment to push a new RC, hoping that this time it will
>>>>> become the first ASF release. Before doing that however, I was thinking
>>>> of
>>>>> pushing a coulpe of small changes:
>>>>> 
>>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>>> could
>>>>> imply upgrading other commons-* libraries, if they do depend on
>>>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>>>> they do depend on that library. Another possibility could be simply
>>>> upgrade
>>>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>>>> break anything.
>>>>> 
>>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>>>> the same, it's just a bit tinier.
>>>>> 
>>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>>> before
>>>>> making the next RC?
>>>>> 
>>>>> 
>>>>> br,
>>>>> juan pablo
>>>>> 
>>>>> [#1]
>>>>> 
>>>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>>> 
>>>> 


Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Hi Janne,

just tried it again with JDK 1.5.0_22 on Linux and JDK 1.6.0_33 on Windows. Both are working fine.

Name	Status	Type	Time(s)
testIfPluginUserAllowed	Success		0.946
testIfPluginUserNotAllowed	Success		0.126
testIfPluginIPAllowed	Success		0.083
testIfPluginIPNotAllowed	Success		0.115

These tests will fail on older versions of JSPWiki (see JSPWIKI-737). Is v2.9.0-incubating-9 running in your test environment?

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Janne Jalkanen" <Ja...@ecyrd.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Mittwoch, 25. Juli 2012 21:15:11
Betreff: Re: 3rd RC?


D'oh... I'd roll a new release but I've got failing unit tests (IfPluginTest).

/Janne

On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:

> Now that's funny: What should have avoided confusion obviously led to confusion :-)
> 
> Janne, these are the old artifacts!
> 
> Juan Pablo renamed tags/jspwiki_2_9_0 to tags/jspwiki_2_9_0_incubating_rc2.
> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Montag, 23. Juli 2012 21:32:02
> Betreff: Re: 3rd RC?
> 
> 
> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> 
> /Janne
> 
> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> 
>> Hi!
>> 
>> I've just renamed rc2 to avoid confusion.
>> 
>> 2.9.0 should be real near now :-)
>> 
>> 
>> br,
>> juan pablo
>> 
>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>> 
>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>> Betreff: Re: 3rd RC?
>>> 
>>> 
>>> Just tag it and I'll build it from that tag :-)
>>> 
>>> /Janne
>>> 
>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>> Betreff: 3rd RC?
>>>> 
>>>> Hi,
>>>> 
>>>> couple of days ago I was finally able to solve my problems regarding the
>>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>>> now
>>>> would be a good moment to push a new RC, hoping that this time it will
>>>> become the first ASF release. Before doing that however, I was thinking
>>> of
>>>> pushing a coulpe of small changes:
>>>> 
>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>> could
>>>> imply upgrading other commons-* libraries, if they do depend on
>>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>>> they do depend on that library. Another possibility could be simply
>>> upgrade
>>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>>> break anything.
>>>> 
>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>>> the same, it's just a bit tinier.
>>>> 
>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>> before
>>>> making the next RC?
>>>> 
>>>> 
>>>> br,
>>>> juan pablo
>>>> 
>>>> [#1]
>>>> 
>>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>> 
>>> 


Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Huh... Weird. Which build target are you executing?
There has been a fix to IfPlugin, but all tests were running fine in my environment.

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Janne Jalkanen" <Ja...@ecyrd.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Mittwoch, 25. Juli 2012 21:15:11
Betreff: Re: 3rd RC?


D'oh... I'd roll a new release but I've got failing unit tests (IfPluginTest).

/Janne

On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:

> Now that's funny: What should have avoided confusion obviously led to confusion :-)
> 
> Janne, these are the old artifacts!
> 
> Juan Pablo renamed tags/jspwiki_2_9_0 to tags/jspwiki_2_9_0_incubating_rc2.
> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Montag, 23. Juli 2012 21:32:02
> Betreff: Re: 3rd RC?
> 
> 
> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> 
> /Janne
> 
> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> 
>> Hi!
>> 
>> I've just renamed rc2 to avoid confusion.
>> 
>> 2.9.0 should be real near now :-)
>> 
>> 
>> br,
>> juan pablo
>> 
>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>> 
>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>> Betreff: Re: 3rd RC?
>>> 
>>> 
>>> Just tag it and I'll build it from that tag :-)
>>> 
>>> /Janne
>>> 
>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>> Betreff: 3rd RC?
>>>> 
>>>> Hi,
>>>> 
>>>> couple of days ago I was finally able to solve my problems regarding the
>>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>>> now
>>>> would be a good moment to push a new RC, hoping that this time it will
>>>> become the first ASF release. Before doing that however, I was thinking
>>> of
>>>> pushing a coulpe of small changes:
>>>> 
>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>> could
>>>> imply upgrading other commons-* libraries, if they do depend on
>>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>>> they do depend on that library. Another possibility could be simply
>>> upgrade
>>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>>> break anything.
>>>> 
>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>>> the same, it's just a bit tinier.
>>>> 
>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>> before
>>>> making the next RC?
>>>> 
>>>> 
>>>> br,
>>>> juan pablo
>>>> 
>>>> [#1]
>>>> 
>>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>> 
>>> 


Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
D'oh... I'd roll a new release but I've got failing unit tests (IfPluginTest).

/Janne

On Jul 24, 2012, at 10:39 , Florian Holeczek wrote:

> Now that's funny: What should have avoided confusion obviously led to confusion :-)
> 
> Janne, these are the old artifacts!
> 
> Juan Pablo renamed tags/jspwiki_2_9_0 to tags/jspwiki_2_9_0_incubating_rc2.
> The current one is still tags/jspwiki_2_9_0_incubating_rc3!
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Montag, 23. Juli 2012 21:32:02
> Betreff: Re: 3rd RC?
> 
> 
> Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/
> 
> /Janne
> 
> On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:
> 
>> Hi!
>> 
>> I've just renamed rc2 to avoid confusion.
>> 
>> 2.9.0 should be real near now :-)
>> 
>> 
>> br,
>> juan pablo
>> 
>> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
>> 
>>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>>> Betreff: Re: 3rd RC?
>>> 
>>> 
>>> Just tag it and I'll build it from that tag :-)
>>> 
>>> /Janne
>>> 
>>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>>> 
>>>> Hi all,
>>>> 
>>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>>> 
>>>> Regards
>>>> Florian
>>>> 
>>>> 
>>>> ----- Ursprüngliche Mail -----
>>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>>> An: jspwiki-dev@incubator.apache.org
>>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>>> Betreff: 3rd RC?
>>>> 
>>>> Hi,
>>>> 
>>>> couple of days ago I was finally able to solve my problems regarding the
>>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>>> now
>>>> would be a good moment to push a new RC, hoping that this time it will
>>>> become the first ASF release. Before doing that however, I was thinking
>>> of
>>>> pushing a coulpe of small changes:
>>>> 
>>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>>> could
>>>> imply upgrading other commons-* libraries, if they do depend on
>>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>>> they do depend on that library. Another possibility could be simply
>>> upgrade
>>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>>> break anything.
>>>> 
>>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>>> the same, it's just a bit tinier.
>>>> 
>>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>>> before
>>>> making the next RC?
>>>> 
>>>> 
>>>> br,
>>>> juan pablo
>>>> 
>>>> [#1]
>>>> 
>>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>>> 
>>> 


Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Now that's funny: What should have avoided confusion obviously led to confusion :-)

Janne, these are the old artifacts!

Juan Pablo renamed tags/jspwiki_2_9_0 to tags/jspwiki_2_9_0_incubating_rc2.
The current one is still tags/jspwiki_2_9_0_incubating_rc3!

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Janne Jalkanen" <Ja...@ecyrd.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Montag, 23. Juli 2012 21:32:02
Betreff: Re: 3rd RC?


Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/

/Janne

On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:

> Hi!
> 
> I've just renamed rc2 to avoid confusion.
> 
> 2.9.0 should be real near now :-)
> 
> 
> br,
> juan pablo
> 
> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
> 
>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>> 
>> Regards
>> Florian
>> 
>> 
>> ----- Ursprüngliche Mail -----
>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> An: jspwiki-dev@incubator.apache.org
>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>> Betreff: Re: 3rd RC?
>> 
>> 
>> Just tag it and I'll build it from that tag :-)
>> 
>> /Janne
>> 
>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>> 
>>> Hi all,
>>> 
>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>> Betreff: 3rd RC?
>>> 
>>> Hi,
>>> 
>>> couple of days ago I was finally able to solve my problems regarding the
>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>> now
>>> would be a good moment to push a new RC, hoping that this time it will
>>> become the first ASF release. Before doing that however, I was thinking
>> of
>>> pushing a coulpe of small changes:
>>> 
>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>> could
>>> imply upgrading other commons-* libraries, if they do depend on
>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>> they do depend on that library. Another possibility could be simply
>> upgrade
>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>> break anything.
>>> 
>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>> the same, it's just a bit tinier.
>>> 
>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>> before
>>> making the next RC?
>>> 
>>> 
>>> br,
>>> juan pablo
>>> 
>>> [#1]
>>> 
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>> 
>> 


Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Artifacts now at http://people.apache.org/~jalkanen/JSPWiki/2.9.0/

/Janne

On Jul 23, 2012, at 01:20 , Juan Pablo Santos Rodríguez wrote:

> Hi!
> 
> I've just renamed rc2 to avoid confusion.
> 
> 2.9.0 should be real near now :-)
> 
> 
> br,
> juan pablo
> 
> On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:
> 
>> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>> 
>> Regards
>> Florian
>> 
>> 
>> ----- Ursprüngliche Mail -----
>> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
>> An: jspwiki-dev@incubator.apache.org
>> Gesendet: Sonntag, 22. Juli 2012 21:38:20
>> Betreff: Re: 3rd RC?
>> 
>> 
>> Just tag it and I'll build it from that tag :-)
>> 
>> /Janne
>> 
>> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>> 
>>> Hi all,
>>> 
>>> I'd consider 2.9.0-incubating-9 to be the third RC.
>>> 
>>> Regards
>>> Florian
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
>>> An: jspwiki-dev@incubator.apache.org
>>> Gesendet: Freitag, 6. Juli 2012 00:05:03
>>> Betreff: 3rd RC?
>>> 
>>> Hi,
>>> 
>>> couple of days ago I was finally able to solve my problems regarding the
>>> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
>>> rebooting (computer at home is up 99% of the time..). So I was feeling
>> now
>>> would be a good moment to push a new RC, hoping that this time it will
>>> become the first ASF release. Before doing that however, I was thinking
>> of
>>> pushing a coulpe of small changes:
>>> 
>>> - upgrading commons-lang to commons-lang3: aside from the code, this
>> could
>>> imply upgrading other commons-* libraries, if they do depend on
>>> commons-lang and don't know if that would cause to 3rd party plugins, if
>>> they do depend on that library. Another possibility could be simply
>> upgrade
>>> commons-lang to 2.6, which is the latest from 2.x and most probably won't
>>> break anything.
>>> 
>>> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
>>> retrieve and close Lucene indexes. Have that small change from days ago,
>>> when I was pursuing ghosts; the functionally of the class remains exactly
>>> the same, it's just a bit tinier.
>>> 
>>> WDYT? Does anyone want to push in (or get pushed in) any other thing
>> before
>>> making the next RC?
>>> 
>>> 
>>> br,
>>> juan pablo
>>> 
>>> [#1]
>>> 
>> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>> 
>> 


Re: 3rd RC?

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi!

I've just renamed rc2 to avoid confusion.

2.9.0 should be real near now :-)


br,
juan pablo

On Sun, Jul 22, 2012 at 10:52 PM, Florian Holeczek <fl...@holeczek.de>wrote:

> Done! The tag is named jspwiki_2_9_0_incubating_rc3
>
> Regards
>  Florian
>
>
> ----- Ursprüngliche Mail -----
> Von: "Janne Jalkanen" <Ja...@ecyrd.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Sonntag, 22. Juli 2012 21:38:20
> Betreff: Re: 3rd RC?
>
>
> Just tag it and I'll build it from that tag :-)
>
> /Janne
>
> On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:
>
> > Hi all,
> >
> > I'd consider 2.9.0-incubating-9 to be the third RC.
> >
> > Regards
> > Florian
> >
> >
> > ----- Ursprüngliche Mail -----
> > Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> > An: jspwiki-dev@incubator.apache.org
> > Gesendet: Freitag, 6. Juli 2012 00:05:03
> > Betreff: 3rd RC?
> >
> > Hi,
> >
> > couple of days ago I was finally able to solve my problems regarding the
> > Lucene exceptions, as sad as it looks, in the most ancient windows-way:
> > rebooting (computer at home is up 99% of the time..). So I was feeling
> now
> > would be a good moment to push a new RC, hoping that this time it will
> > become the first ASF release. Before doing that however, I was thinking
> of
> > pushing a coulpe of small changes:
> >
> > - upgrading commons-lang to commons-lang3: aside from the code, this
> could
> > imply upgrading other commons-* libraries, if they do depend on
> > commons-lang and don't know if that would cause to 3rd party plugins, if
> > they do depend on that library. Another possibility could be simply
> upgrade
> > commons-lang to 2.6, which is the latest from 2.x and most probably won't
> > break anything.
> >
> > - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
> > retrieve and close Lucene indexes. Have that small change from days ago,
> > when I was pursuing ghosts; the functionally of the class remains exactly
> > the same, it's just a bit tinier.
> >
> > WDYT? Does anyone want to push in (or get pushed in) any other thing
> before
> > making the next RC?
> >
> >
> > br,
> > juan pablo
> >
> > [#1]
> >
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html
>
>

Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Done! The tag is named jspwiki_2_9_0_incubating_rc3

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Janne Jalkanen" <Ja...@ecyrd.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Sonntag, 22. Juli 2012 21:38:20
Betreff: Re: 3rd RC?


Just tag it and I'll build it from that tag :-)

/Janne

On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:

> Hi all,
> 
> I'd consider 2.9.0-incubating-9 to be the third RC.
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Freitag, 6. Juli 2012 00:05:03
> Betreff: 3rd RC?
> 
> Hi,
> 
> couple of days ago I was finally able to solve my problems regarding the
> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
> rebooting (computer at home is up 99% of the time..). So I was feeling now
> would be a good moment to push a new RC, hoping that this time it will
> become the first ASF release. Before doing that however, I was thinking of
> pushing a coulpe of small changes:
> 
> - upgrading commons-lang to commons-lang3: aside from the code, this could
> imply upgrading other commons-* libraries, if they do depend on
> commons-lang and don't know if that would cause to 3rd party plugins, if
> they do depend on that library. Another possibility could be simply upgrade
> commons-lang to 2.6, which is the latest from 2.x and most probably won't
> break anything.
> 
> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
> retrieve and close Lucene indexes. Have that small change from days ago,
> when I was pursuing ghosts; the functionally of the class remains exactly
> the same, it's just a bit tinier.
> 
> WDYT? Does anyone want to push in (or get pushed in) any other thing before
> making the next RC?
> 
> 
> br,
> juan pablo
> 
> [#1]
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html


Re: 3rd RC?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Just tag it and I'll build it from that tag :-)

/Janne

On Jul 22, 2012, at 20:46 , Florian Holeczek wrote:

> Hi all,
> 
> I'd consider 2.9.0-incubating-9 to be the third RC.
> 
> Regards
> Florian
> 
> 
> ----- Ursprüngliche Mail -----
> Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
> An: jspwiki-dev@incubator.apache.org
> Gesendet: Freitag, 6. Juli 2012 00:05:03
> Betreff: 3rd RC?
> 
> Hi,
> 
> couple of days ago I was finally able to solve my problems regarding the
> Lucene exceptions, as sad as it looks, in the most ancient windows-way:
> rebooting (computer at home is up 99% of the time..). So I was feeling now
> would be a good moment to push a new RC, hoping that this time it will
> become the first ASF release. Before doing that however, I was thinking of
> pushing a coulpe of small changes:
> 
> - upgrading commons-lang to commons-lang3: aside from the code, this could
> imply upgrading other commons-* libraries, if they do depend on
> commons-lang and don't know if that would cause to 3rd party plugins, if
> they do depend on that library. Another possibility could be simply upgrade
> commons-lang to 2.6, which is the latest from 2.x and most probably won't
> break anything.
> 
> - a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
> retrieve and close Lucene indexes. Have that small change from days ago,
> when I was pursuing ghosts; the functionally of the class remains exactly
> the same, it's just a bit tinier.
> 
> WDYT? Does anyone want to push in (or get pushed in) any other thing before
> making the next RC?
> 
> 
> br,
> juan pablo
> 
> [#1]
> http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html


Re: 3rd RC?

Posted by Florian Holeczek <fl...@holeczek.de>.
Hi all,

I'd consider 2.9.0-incubating-9 to be the third RC.

Regards
 Florian


----- Ursprüngliche Mail -----
Von: "Juan Pablo Santos Rodríguez" <ju...@gmail.com>
An: jspwiki-dev@incubator.apache.org
Gesendet: Freitag, 6. Juli 2012 00:05:03
Betreff: 3rd RC?

Hi,

couple of days ago I was finally able to solve my problems regarding the
Lucene exceptions, as sad as it looks, in the most ancient windows-way:
rebooting (computer at home is up 99% of the time..). So I was feeling now
would be a good moment to push a new RC, hoping that this time it will
become the first ASF release. Before doing that however, I was thinking of
pushing a coulpe of small changes:

- upgrading commons-lang to commons-lang3: aside from the code, this could
imply upgrading other commons-* libraries, if they do depend on
commons-lang and don't know if that would cause to 3rd party plugins, if
they do depend on that library. Another possibility could be simply upgrade
commons-lang to 2.6, which is the latest from 2.x and most probably won't
break anything.

- a small refactor on LuceneSearchProvider (#1), mainly lines 505-530, to
retrieve and close Lucene indexes. Have that small change from days ago,
when I was pursuing ghosts; the functionally of the class remains exactly
the same, it's just a bit tinier.

WDYT? Does anyone want to push in (or get pushed in) any other thing before
making the next RC?


br,
juan pablo

[#1]
http://people.apache.org/~juanpablo/coverage_2.9.0-incubating-3/org.apache.wiki.search.LuceneSearchProvider.html