You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/08/06 00:24:37 UTC

[GitHub] spark pull request #22002: [FOLLOW-UP][SPARK-23772][SQL] Provide an option t...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22002#discussion_r207754359
  
    --- Diff: python/pyspark/sql/readwriter.py ---
    @@ -267,7 +267,7 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,
                 mode=mode, columnNameOfCorruptRecord=columnNameOfCorruptRecord, dateFormat=dateFormat,
                 timestampFormat=timestampFormat, multiLine=multiLine,
                 allowUnquotedControlChars=allowUnquotedControlChars, lineSep=lineSep,
    -            samplingRatio=samplingRatio, encoding=encoding)
    +            samplingRatio=samplingRatio, dropFieldIfAllNull=dropFieldIfAllNull, encoding=encoding)
    --- End diff --
    
    oh... good catch. thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org