You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2024/12/06 14:10:54 UTC
[PR] upgrade-log4j2-2.24.2 [solr]
risdenk opened a new pull request, #2895:
URL: https://github.com/apache/solr/pull/2895
https://issues.apache.org/jira/browse/SOLR-XXXXX
This is a follow on to https://github.com/apache/solr/pull/2047 where `biz.aQute.bnd` doesn't need to be upgraded.
However running into some test failures due to concurrent modification exceptions when updating loggers in some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-2530882606
> * [jul-to-slf4j](https://github.com/qos-ch/slf4j/blob/v_2.0.16/jul-to-slf4j/LICENSE.txt)
Since you use Log4j Core in your binary distribution, you should consider using the [JUL-to-Log4j API bridge](https://logging.apache.org/log4j/2.x/log4j-jul.html) instead. The artifact has two _modi operandi_:
* A fast bridge, which replace JUL entirely, but requires the setting of the `java.util.logging.manager` Java system property in your startup scripts (see [Using LogManager](https://logging.apache.org/log4j/2.x/log4j-jul.html#bridge-logmanager)).
* A slower bridge, similar to the one in `jul-to-slf4j`, but it provides direct bridging between JUL and Log4j API (without passing through SLF4J). See [Using Log4jBridgeHandler](https://logging.apache.org/log4j/2.x/log4j-jul.html#bridge-handler).
> * jcl-over-slf4j, this changed from MIT to ASL in [repo](https://github.com/qos-ch/slf4j/blob/v_2.0.16/jcl-over-slf4j/LICENSE.txt), but is still using the [base license](https://github.com/qos-ch/slf4j/blob/v_2.0.16/LICENSE.txt) in downloaded package. Not sure which one to use in this case. @janhoy any idea how to handle these cases? Prefer ASL?
Since the release of `commons-logging` 1.3.0, `jcl-over-slf4j` (as well as `spring-jcl` and `log4j-jcl`) are no longer necessary. We made [a blog post about it](https://logging.apache.org/blog/2023/12/02/apache-common-logging-1.3.0.html) last year.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-2530705029
I have no preference when license is ambiguous. Guess whatever is in the download tar for that version is safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-3250078461
Closing in favor of https://github.com/apache/solr/pull/3603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-2523609338
@risdenk,
I'll cut a `2.24.3` release on Monday. The RC should solve your problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-2523371681
Looks like we are running into:
* https://github.com/apache/logging-log4j2/issues/3234
* https://github.com/apache/logging-log4j2/issues/3283
Once those are fixed (there is a PR it looks like) should be ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #2895:
URL: https://github.com/apache/solr/pull/2895#issuecomment-2546456414
Thanks @malliaridis will fix in new branch for 2.24.3 and @ppkarwasz for the release w/ the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] upgrade-log4j2-2.24.2 [solr]
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk closed pull request #2895: upgrade-log4j2-2.24.2
URL: https://github.com/apache/solr/pull/2895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org