You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/03 06:54:37 UTC

[GitHub] flink pull request #5406: [hotfix] Fix typos in comments.

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5406#discussion_r165807220
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolGateway.java ---
    @@ -90,11 +90,11 @@
     	CompletableFuture<Acknowledge> releaseTaskManager(final ResourceID resourceId);
     
     	/**
    -	 * Offers a slot to the {@link SlotPool}. The slot offer can be accepted or
    +	 * Offers a slot to the {@link SlotPool}. The slot offers can be accepted or
     	 * rejected.
     	 *
    -	 * @param taskManagerLocation from which the slot offer originates
    -	 * @param taskManagerGateway to talk to the slot offerer
    +	 * @param taskManagerLocation from which the slot offers originate
    --- End diff --
    
    given that this method offers a single slot using singular makes more sense


---