[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5847: Support for transformation from jakartaee8 to jakartaee10 applications

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on code in PR #5847:
URL: https://github.com/apache/netbeans/pull/5847#discussion_r1262761321


##########
enterprise/jakarta.transformer/manifest.mf:
##########
@@ -0,0 +1,8 @@
+Manifest-Version: 1.0
+OpenIDE-Module: org.netbeans.modules.jakarta.transformer/0
+OpenIDE-Module-Layer: org/netbeans/modules/fish/payara/jakarta/transformer/layer.xml
+OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/fish/payara/jakarta/transformer/Bundle.properties
+AutoUpdate-Show-In-Client: true
+AutoUpdate-Essential-Module: true
+OpenIDE-Module-Specification-Version: 2.15

Review Comment:
   Only reading code I see:
   - an essential module can't be deleted
   - an essential module can't be disabled



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists