[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6636: Modify TP init script to be systemd compliant

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #6636:
URL: https://github.com/apache/trafficcontrol/pull/6636#discussion_r824786259



##########
File path: traffic_portal/build/etc/init.d/traffic_portal
##########
@@ -46,14 +62,14 @@ start() {
       -l $LOGFILE \
       --restart-delay $RESTART_TIME \
       --time \
-      --name "$NAME"
+      --name "$NAME" 2>&1 > /dev/null
     RETVAL=$?
 }
 
 stop() {
     if pm2 list | grep -q "$NAME"; then
         echo "Shutting down $NAME"
-        pm2 stop $APPLICATION_PATH
+        pm2 stop $APPLICATION_PATH 2>&1 > /dev/null

Review comment:
       `2>&1` needs to go after `> /dev/null` or it doesn't redirect `/dev/stderr` to `/dev/null`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org