You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/06/13 07:49:58 UTC

[kudu-CR] KUDU-2850: fix thrift comparison

Hello Alexey Serbin, Adar Dembo, Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13608

to review the following change.


Change subject: KUDU-2850: fix thrift comparison
......................................................................

KUDU-2850: fix thrift comparison

In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.

I added a test for each operator I updated that would fail without this
patch.

Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13608/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13608

to look at the new patch set (#2).

Change subject: KUDU-2850: fix thrift comparison
......................................................................

KUDU-2850: fix thrift comparison

In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.

I added a test for each operator I updated that would fail without this
patch.

Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13608/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc
File src/kudu/sentry/thrift_operators.cc:

http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc@35
PS1, Line 35:   if ((lhs) != (rhs)) { \
> warning: macro argument should be enclosed in parentheses [misc-macro-paren
Done


http://gerrit.cloudera.org:8080/#/c/13608/1/src/kudu/sentry/thrift_operators.cc@36
PS1, Line 36:     return (lhs) < (rhs); \
> warning: macro argument should be enclosed in parentheses [misc-macro-paren
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 08:23:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> (2 comments)
> 
> I'm late with at the party, but anyways.

Addressed both of these here: https://gerrit.cloudera.org/c/13638/


-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 18:12:52 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc
File src/kudu/sentry/thrift_operators-test.cc:

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc@143
PS3, Line 143:   ASSERT_EQ(5, authorizables.size()) << authorizables;
> I think in addition to that, it would make sense to populate a vector of TS
Sure, I'll pick that up in a follow-up.


http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc
File src/kudu/sentry/thrift_operators.cc:

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc@34
PS3, Line 34: { \
            :   if ((lhs) != (rhs)) { \
            :     return (lhs) < (rhs); \
            :   } \
            : }
> nit: w.r.t. trailing semicolon when used, it might be a better fit to wrap 
Sure, I'll pick that up in a follow-up.



-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:35:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 3:

(2 comments)

I'm late with at the party, but anyways.

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc
File src/kudu/sentry/thrift_operators-test.cc:

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc@143
PS3, Line 143:   ASSERT_EQ(5, authorizables.size()) << authorizables;
I think in addition to that, it would make sense to populate a vector of TSentryAuthorizable out of the set and then compare the result with the reference vector.  That's to have cover the total ordering of the elements in the set.


http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc
File src/kudu/sentry/thrift_operators.cc:

http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc@34
PS3, Line 34: { \
            :   if ((lhs) != (rhs)) { \
            :     return (lhs) < (rhs); \
            :   } \
            : }
nit: w.r.t. trailing semicolon when used, it might be a better fit to wrap the if() clause into 'do {} while (false)':

do {
  ...
} while (false)



-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:32:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13608/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13608/2//COMMIT_MSG@7
PS2, Line 7: KUDU-2850: fix thrift comparison
> I've read through the JIRA and while I think I understand the issue, I don'
I'll add details to the Jira in closing it out.

The symptom Hao saw when she tried to use her new Sentry API was that when she tried to use a map<TSentryAuthorizable, string>, she wasn't able to find() some results when iterating through the map showed their existence. In debugging, I also ran into a SEGFAULT while deserializing a response via the Sentry client:

#0  0x00007fffe81678ac in std::string::compare(std::string const&) const () from /lib64/libstdc++.so.6
#1  0x00000000004f71fe in std::operator< <char, std::char_traits<char>, std::allocator<char> > (__lhs=<error reading variable: Cannot access memory at address 0xffffffffffffffe8>, __rhs="server1")
    at /usr/include/c++/4.8.2/bits/basic_string.h:2571
#2  0x00007ffff54cf547 in sentry::TSentryAuthorizable::operator< (this=0x7fffffffcf88, other=...) at ../../src/kudu/sentry/thrift_operators.cc:63
#3  0x00007ffff7159479 in std::less<sentry::TSentryAuthorizable>::operator() (this=0x7fffffffcf60, __x=..., __y=...) at /usr/include/c++/4.8.2/bits/stl_function.h:235
#4  0x00007ffff5490aa0 in std::_Rb_tree<sentry::TSentryAuthorizable, std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > >, std::_Select1st<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > >, std::less<sentry::TSentryAuthorizable>, std::allocator<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > > >::_M_get_insert_hint_unique_pos (this=0x7fffffffcf60, __position=..., __k=...) at /usr/include/c++/4.8.2/bits/stl_tree.h:1433
#5  0x00007ffff548ad3c in std::_Rb_tree<sentry::TSentryAuthorizable, std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > >, std::_Select1st<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > >, std::less<sentry::TSentryAuthorizable>, std::allocator<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > > >::_M_emplace_hint_unique<std::piecewise_construct_t const&, std::tuple<sentry::TSentryAuthorizable const&>, std::tuple<> >(std::_Rb_tree_const_iterator<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > >, std::piecewise_construct_t const&, std::tuple<sentry::TSentryAuthorizable const&>&&, std::tuple<>&&) (this=0x7fffffffcf60, __pos=...)
    at /usr/include/c++/4.8.2/bits/stl_tree.h:1673
#6  0x00007ffff54876ea in std::map<sentry::TSentryAuthorizable, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> >, std::less<sentry::TSentryAuthorizable>, ---Type <return> to continue, or q <return> to quit---
std::allocator<std::pair<sentry::TSentryAuthorizable const, std::set<sentry::TSentryPrivilege, std::less<sentry::TSentryPrivilege>, std::allocator<sentry::TSentryPrivilege> > > > >::operator[] (this=0x7fffffffcf60,
    __k=...) at /usr/include/c++/4.8.2/bits/stl_map.h:465
#7  0x00007ffff5478166 in sentry::TListSentryPrivilegesByAuthUserResponse::read (this=0x7fffffffcf30, iprot=0x7fffd8000d78) at src/kudu/sentry/sentry_policy_service_types.cpp:6215
#8  0x00007ffff54a0f74 in sentry::SentryPolicyService_list_sentry_privileges_by_authorizable_and_user_presult::read (this=0x7fffe280b8a0, iprot=0x7fffd8000d78) at src/kudu/sentry/SentryPolicyService.cpp:3546
#9  0x00007ffff54ab7f9 in sentry::SentryPolicyServiceClient::recv_list_sentry_privileges_by_authorizable_and_user (this=0x80ae78, _return=...) at src/kudu/sentry/SentryPolicyService.cpp:5964
#10 0x00007ffff54ab3fc in sentry::SentryPolicyServiceClient::list_sentry_privileges_by_authorizable_and_user (this=0x80ae78, _return=..., request=...) at src/kudu/sentry/SentryPolicyService.cpp:5920
#11 0x00007ffff571faf6 in kudu::sentry::SentryClient::ListPrivilegesByAuthoriablesAndUser (this=0x80ae78, request=..., response=0x7fffffffcf30) at ../../src/kudu/sentry/sentry_client.cc:183
#12 0x00007ffff7148db3 in kudu::master::SentryPrivilegesFetcher::__lambda5::operator() (__closure=0x181e6f0, client=0x80ae78) at ../../src/kudu/master/sentry_privileges_fetcher.cc:1040



-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:29:09 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13608/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13608/2//COMMIT_MSG@7
PS2, Line 7: KUDU-2850: fix thrift comparison
I've read through the JIRA and while I think I understand the issue, I don't understand its effects on the product. Could you elaborate, perhaps with an example?



-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 16:58:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................

KUDU-2850: fix thrift comparison

In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.

I added a test for each operator I updated that would fail without this
patch.

Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Reviewed-on: http://gerrit.cloudera.org:8080/13608
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:04:15 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2850: fix thrift comparison

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )

Change subject: KUDU-2850: fix thrift comparison
......................................................................


Patch Set 3:

oops, sorry I merged and missed Adar's comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:09:50 +0000
Gerrit-HasComments: No