[jira] [Resolved] (CALCITE-4436) Use the fields order from the struct type for 'ITEM(STRUCT, INDEX)' access

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stamatis Zampetakis resolved CALCITE-4436.
------------------------------------------
    Fix Version/s: 1.27.0
       Resolution: Fixed

Fixed in [67b41cea21203b1c7541d04dc0ff6ee6b65fbe35|https://github.com/apache/calcite/commit/67b41cea21203b1c7541d04dc0ff6ee6b65fbe35]. Thanks for the PR [~asolimando]!

> Use the fields order from the struct type for 'ITEM(STRUCT, INDEX)' access
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-4436
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4436
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.27.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The index-based access via the "ITEM" operator for operands of row/struct type is currently experimental and disabled by default (introduced in CALCITE-4354).
> Its implementation uses the fields order from `getDeclaredFields()`, a JVM-specific feature, this might lead to silent data corruption (see [PR-2230|https://github.com/apache/calcite/pull/2230]).
> The aim of the ticket is to improve the feature by relying on the safer fields order 
>  from the struct field type itself (_i.e._, `relType.getFields()[index]`) so that we can enable it by default.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)