You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/02/12 17:19:30 UTC
Re: svn commit: r12974 - branches/locking/subversion/libsvn_client
On Fri, 11 Feb 2005 fitz@tigris.org wrote:
> Author: fitz
> Date: Fri Feb 11 16:33:09 2005
> New Revision: 12974
>
> Modified:
> branches/locking/subversion/libsvn_client/locking_commands.c
> Log:
> Continue work on implementing the behaviors of the svn:needs-lock
> property: When locking and unlocking a file, flip the perms on the
> file if it has the svn:needs-lock property.
>
> * libsvn_client/locking_commands.c (svn_client_lock): If
> svn:needs-lock is set on a path that was just locked, change the
> file to read-write.
>
> (svn_client_unlock): If svn:needs-lock is set on a path that was
> just unlocked, change the file to read-only.
>
>
I think this belongs in svn_wc_add_lock and svn_wc_remove_lock. Parts of
the read-only flipping needs to be in libsvn_wc, so I think all knowledge
of it should go there.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r12974 - branches/locking/subversion/libsvn_client
Posted by "Brian W. Fitzpatrick" <fi...@collab.net>.
On Feb 12, 2005, at 11:19 AM, Peter N. Lundblad wrote:
> On Fri, 11 Feb 2005 fitz@tigris.org wrote:
>
>> Author: fitz
>> Date: Fri Feb 11 16:33:09 2005
>> New Revision: 12974
>>
>> Modified:
>> branches/locking/subversion/libsvn_client/locking_commands.c
>> Log:
>> Continue work on implementing the behaviors of the svn:needs-lock
>> property: When locking and unlocking a file, flip the perms on the
>> file if it has the svn:needs-lock property.
>>
>> * libsvn_client/locking_commands.c (svn_client_lock): If
>> svn:needs-lock is set on a path that was just locked, change the
>> file to read-write.
>>
>> (svn_client_unlock): If svn:needs-lock is set on a path that was
>> just unlocked, change the file to read-only.
>>
>>
> I think this belongs in svn_wc_add_lock and svn_wc_remove_lock. Parts
> of
> the read-only flipping needs to be in libsvn_wc, so I think all
> knowledge
> of it should go there.
Yep, you're right. I'll take care of that this morning.
Thanks,
-Fitz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org