You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/13 03:19:56 UTC
[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1346:
LUCENE-9276: Use same code-path for updateDocuments and updateDocument
dnhatn commented on a change in pull request #1346: LUCENE-9276: Use same code-path for updateDocuments and updateDocument
URL: https://github.com/apache/lucene-solr/pull/1346#discussion_r392011485
##########
File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java
##########
@@ -346,7 +285,7 @@ public long updateDocuments(Iterable<? extends Iterable<? extends IndexableField
}
}
- private long finishDocument(DocumentsWriterDeleteQueue.Node<?> deleteNode) {
+ private long finishDocument(DocumentsWriterDeleteQueue.Node<?> deleteNode, int docCount) {
Review comment:
Should we call this finishDocument**S** ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org