You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lécharny (Jira)" <ji...@apache.org> on 2021/04/19 14:52:00 UTC
[jira] [Commented] (DIRAPI-369) DSML needsBase64Encoding
[ https://issues.apache.org/jira/browse/DIRAPI-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325101#comment-17325101 ]
Emmanuel Lécharny commented on DIRAPI-369:
------------------------------------------
We are probably overdoing here. The idea is to escape brutally the text as we assume it will be properly processed on the other side. Any char which is not a pure ASCII will then require the full value to be base 64 encoded.
We could be 'smarter', and only check if there are some chars that really need to be escaped (like '<' or '>'), but in any case, beside the extra work for the CPU, the request should be valid.
> DSML needsBase64Encoding
> ------------------------
>
> Key: DIRAPI-369
> URL: https://issues.apache.org/jira/browse/DIRAPI-369
> Project: Directory Client API
> Issue Type: Bug
> Reporter: Florian Kimmann
> Priority: Major
>
> Why does the method needsBase64Encoding in the dsml ParserUtils check for LDIF safety?
> DSML doesnt have to be LDIF safe? We get Base64 encoded strings in our application all the time, because of common german characters like äöüß etc.
> XML can handle those characters. Or am I overlooking something?
>
> [https://github.com/apache/directory-ldap-api/blob/275b9830b8b974dc19fb3b8d38c68061211fb5f7/dsml/parser/src/main/java/org/apache/directory/api/dsmlv2/ParserUtils.java#L167]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org