You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "AnnJoy23 (via GitHub)" <gi...@apache.org> on 2026/09/24 05:28:01 UTC
[PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
AnnJoy23 opened a new pull request, #7128:
URL: https://github.com/apache/incubator-kie/pull/7128
## Summary
Upgrades Spring Boot from `4.0.8` to `4.1.1`.
## Changes
- `kogito-springboot/bom/pom.xml`:
- `version.org.springframework.boot`: `4.0.8` → `4.1.1`
- `version.org.springframework.cloud`: `2025.1.1` → `2025.1.2`
- `version.io.netty`: pinned to `4.2.18.Final` (Spring Boot 4.1.1 brings `4.2.17.Final` which is vulnerable)
## Notes
- `version.org.apache.logging.log4j` override (`2.26.1`) retained — SB 4.1.1 only provides `2.25.5`
- `version.tools.jackson.core` override (`3.1.6`) retained — SB 4.1.1 still carries `jackson-bom:3.1.5`
- MongoDB driver overrides retained — SB 4.1.1 only provides `5.8.1` vs pinned `5.9.2`
- Netty override retained — SB 4.1.1 bundles `4.2.17.Final` (vulnerable); pinned to `4.2.18.Final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "AnnJoy23 (via GitHub)" <gi...@apache.org>.
AnnJoy23 commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4102274891
##########
kogito-springboot/bom/pom.xml:
##########
@@ -34,20 +34,20 @@
<properties>
<!-- Used to define which poms are allowed to have dependencyManagement sections. This is to enforce the convention that only the root pom should have dependencyManagement, and all other poms should inherit from it. -->
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
- <!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1 declares fabric8 7.4.0) -->
- <version.io.fabric8>7.4.0</version.io.fabric8>
- <version.io.netty>4.2.17.Final</version.io.netty>
+ <!-- Aligned with Spring Cloud (spring-cloud-kubernetes-fabric8 5.0.2 declares fabric8 7.4.1) -->
Review Comment:
The 5.0.2 version comes from spring-cloud-dependencies:${version.org.springframework.cloud} . That BOM declares spring-cloud-kubernetes-fabric8:5.0.2, which in turn requires io.fabric8:7.4.1. This pin is also overriding the 7.3.1 set in kie-parent to align with what Spring Cloud Kubernetes actually needs at runtime.
I've expanded the comment to make this traceable and to guide future maintainers when upgrading version.org.springframework.cloud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4105730279
##########
kogito-springboot/addons/kubernetes/README.md:
##########
@@ -34,9 +34,16 @@ When using this add-on is important to set the following properties in your test
```properties
spring.main.cloud-platform=KUBERNETES
spring.cloud.bootstrap.enabled=true
+# Required when running tests outside a real Kubernetes cluster (Spring Cloud Kubernetes 5.0.2+).
Review Comment:
Thanks @AnnJoy23 !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "jomarko (via GitHub)" <gi...@apache.org>.
jomarko commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4101633292
##########
kogito-springboot/bom/pom.xml:
##########
@@ -34,20 +34,20 @@
<properties>
<!-- Used to define which poms are allowed to have dependencyManagement sections. This is to enforce the convention that only the root pom should have dependencyManagement, and all other poms should inherit from it. -->
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
- <!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1 declares fabric8 7.4.0) -->
- <version.io.fabric8>7.4.0</version.io.fabric8>
- <version.io.netty>4.2.17.Final</version.io.netty>
+ <!-- Aligned with Spring Cloud (spring-cloud-kubernetes-fabric8 5.0.2 declares fabric8 7.4.1) -->
Review Comment:
`5.0.2` - where this version comes from? from my point of view would help for the future maintenance to mention where it is defined so we can check hat `fabric8` we need to have here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4090983533
##########
kogito-springboot/addons/kubernetes/src/test/resources/application.properties:
##########
@@ -18,4 +18,5 @@
#
spring.main.cloud-platform=KUBERNETES
-spring.cloud.bootstrap.enabled=true
\ No newline at end of file
+spring.cloud.bootstrap.enabled=true
+spring.cloud.kubernetes.discovery.enabled=false
Review Comment:
This new test-only setting is required to prevent Spring Cloud Kubernetes 5.0.2 from connecting to a live cluster during tests, but `kogito-springboot/addons/kubernetes/README.md` still documents only the two settings at lines 35-36. Users following that documented test setup can still hit the same ApplicationContext/401 failure; please add this property to the test configuration guidance and clarify that it is test-only.
##########
kogito-springboot/bom/pom.xml:
##########
@@ -36,18 +36,18 @@
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
<!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1 declares fabric8 7.4.0) -->
Review Comment:
The alignment comment above still says `spring-cloud-kubernetes-fabric8 5.0.1`, but this upgrade moves the Spring Cloud BOM to 2025.1.2, which brings 5.0.2. Leaving the old version here makes the rationale for the Fabric8 pin inaccurate; please update the comment to match the dependency being managed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "AnnJoy23 (via GitHub)" <gi...@apache.org>.
AnnJoy23 commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4102274891
##########
kogito-springboot/bom/pom.xml:
##########
@@ -34,20 +34,20 @@
<properties>
<!-- Used to define which poms are allowed to have dependencyManagement sections. This is to enforce the convention that only the root pom should have dependencyManagement, and all other poms should inherit from it. -->
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
- <!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1 declares fabric8 7.4.0) -->
- <version.io.fabric8>7.4.0</version.io.fabric8>
- <version.io.netty>4.2.17.Final</version.io.netty>
+ <!-- Aligned with Spring Cloud (spring-cloud-kubernetes-fabric8 5.0.2 declares fabric8 7.4.1) -->
Review Comment:
Hi @jomarko ,Thank you for reviewing.
The 5.0.2 version comes from spring-cloud-dependencies:${version.org.springframework.cloud} . That BOM declares spring-cloud-kubernetes-fabric8:5.0.2, which in turn requires io.fabric8:7.4.1. This pin is also overriding the 7.3.1 set in kie-parent to align with what Spring Cloud Kubernetes actually needs at runtime.
I've expanded the comment to make this traceable and to guide future maintainers when upgrading version.org.springframework.cloud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Upgrade Spring Boot from 4.0.8 to 4.1.1 [incubator-kie]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org