You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "digital-nomad-cheng (via GitHub)" <gi...@apache.org> on 2023/05/31 20:56:30 UTC

[GitHub] [tvm] digital-nomad-cheng opened a new pull request, #15001: [Unity][CUTLASS] Fix bug

digital-nomad-cheng opened a new pull request, #15001:
URL: https://github.com/apache/tvm/pull/15001

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #15001: [Unity][CUTLASS] Fix circular import bug in relax cutlass backend

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #15001:
URL: https://github.com/apache/tvm/pull/15001#issuecomment-1571110012

   I think it is better to remove `from .cutlass import partition_for_cutlass` from `backend/contrib/__init__.py` since doing `import relax` shouldn't cause `contrib/cutlass/build.py` to depend on `contrib/cutlass.py`. cc @yelite 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #15001: [Unity][CUTLASS] Fix bug

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15001:
URL: https://github.com/apache/tvm/pull/15001#issuecomment-1570943006

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on a diff in pull request #15001: [Unity][CUTLASS] Fix circular import bug in relax cutlass backend

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #15001:
URL: https://github.com/apache/tvm/pull/15001#discussion_r1212871648


##########
python/tvm/relax/backend/contrib/__init__.py:
##########
@@ -17,4 +17,3 @@
 
 """External backend codegen modules for Relax."""
 

Review Comment:
   You can remove this file now that it is not used at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] digital-nomad-cheng commented on pull request #15001: [Unity][CUTLASS] Fix circular import bug in relax cutlass backend

Posted by "digital-nomad-cheng (via GitHub)" <gi...@apache.org>.
digital-nomad-cheng commented on PR #15001:
URL: https://github.com/apache/tvm/pull/15001#issuecomment-1571685232

   Import removed from `__init__` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #15001: [Unity][CUTLASS] Fix circular import bug in relax cutlass backend

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #15001:
URL: https://github.com/apache/tvm/pull/15001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] digital-nomad-cheng commented on a diff in pull request #15001: [Unity][CUTLASS] Fix circular import bug in relax cutlass backend

Posted by "digital-nomad-cheng (via GitHub)" <gi...@apache.org>.
digital-nomad-cheng commented on code in PR #15001:
URL: https://github.com/apache/tvm/pull/15001#discussion_r1212876348


##########
python/tvm/relax/backend/contrib/__init__.py:
##########
@@ -17,4 +17,3 @@
 
 """External backend codegen modules for Relax."""
 

Review Comment:
   Thanks for the feedback, file removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org