[incubator-superset] branch hugh/bad-comments created (now 6ccd8a2)

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a change to branch hugh/bad-comments
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git.


      at 6ccd8a2  bad comments

This branch includes the following new commits:

     new 6ccd8a2  bad comments

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[incubator-superset] 01/01: bad comments

[hu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch hugh/bad-comments
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit 6ccd8a2dbbc86f61834d92e6e1f3aca4d5e4ca3d
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Dec 3 15:27:02 2020 -0800

    bad comments
---
 superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx | 2 --
 1 file changed, 2 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
index c100dff..01906b7 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
@@ -96,8 +96,6 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
     inputValue: string,
     option: { value: string; datasetId: number },
   ) => {
-    // We need to add "es7" to tsconfig for this to error to go way
-    // https://stackoverflow.com/questions/51811239/ts2339-property-includes-does-not-exist-on-type-string/51811417
     return option.value.includes(inputValue);
   };