You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2015/03/20 01:13:40 UTC
Review Request 32268: HIVE-9998 Vectorization support for interval types

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32268/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Matt McCline.


Bugs: HIVE-9998
    https://issues.apache.org/jira/browse/HIVE-9998


Repository: hive-git


Description
-------

Enables support for vectorized interval types
This also fixes some vectorized comparisons for Date, when one of the left or right side is a constant expression.


Diffs
-----

  ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 375c173 
  common/src/java/org/apache/hive/common/util/DateTimeMath.java 28030e6 
  common/src/java/org/apache/hive/common/util/DateUtils.java b4159d3 
  common/src/test/org/apache/hive/common/util/TestDateTimeMath.java 4886576 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumnWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalarWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt 6bf6def 
  ql/src/gen/vectorization/ExpressionTemplates/DTIColumnArithmeticDTIColumnNoConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DTIColumnArithmeticDTIScalarNoConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DTIColumnCompareScalar.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DTIScalarArithmeticDTIColumnNoConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DTIScalarCompareColumn.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DateTimeColumnArithmeticIntervalColumnWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DateTimeColumnArithmeticIntervalScalarWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/DateTimeScalarArithmeticIntervalColumnWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/FilterDTIColumnCompareScalar.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/FilterDTIScalarCompareColumn.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/IntervalColumnArithmeticDateTimeColumnWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/IntervalColumnArithmeticDateTimeScalarWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/IntervalScalarArithmeticDateTimeColumnWithConvert.txt PRE-CREATION 
  ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumnWithConvert.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampUtils.java 352e43e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java c915f72 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java bb18b32 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 5201c57 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java e304cf8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java 88ec2b2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToIntervalDayTime.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToIntervalYearMonth.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java d7ace6d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java 94a47e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 10bf2bd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java aca4273 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDTIMinus.java a32c133 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDTIPlus.java 9a5c3a9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java 3870b51 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java 65e1835 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java 3e4a1d2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java df7a857 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java fafd99b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java 18fbb5a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java 0436488 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java bfac5a8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToIntervalDayTime.java 89c3988 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToIntervalYearMonth.java 5c05655 
  ql/src/java/org/apache/hadoop/hive/ql/util/DateTimeMath.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java efe2efe 
  ql/src/test/org/apache/hadoop/hive/ql/util/TestDateTimeMath.java PRE-CREATION 
  ql/src/test/queries/clientpositive/vector_date_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/vector_interval_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/vector_interval_2.q PRE-CREATION 
  ql/src/test/results/clientpositive/vector_date_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/vector_interval_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/vector_interval_2.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java 2b0b550 

Diff: https://reviews.apache.org/r/32268/diff/


Testing
-------

qfile tests


Thanks,

Jason Dere